Skip to content

✅ Add test that runs select with 3 or 4 arguments #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

✅ Add test that runs select with 3 or 4 arguments #1590

wants to merge 6 commits into from
+65 −0

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Oct 6, 2025 •
edited
Loading

Ensure that _expression_select_gen.py works properly and provides the right type hints for code that calls select() with 3 or 4 arguments.

Note that I already provided some code to call select with 5 arguments as well. This works and runs, but won't succeed on a mypy check, as reported before.

While I think this PR is useful on its own, it's also in preparation of #1560.

@svlandeg svlandeg marked this pull request as ready for review October 6, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svlandeg @YuriiMotov