Add type of _TScalar at expression.py.jinja2 #776
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Csaba1205
approved these changes
Apr 23, 2024
Csaba1205
approved these changes
May 4, 2024
Csaba1205
approved these changes
May 4, 2024
Member
|
Seems that this PR is outdated. |
github-actions
bot
added
the
conflicts
Contributor
|
This pull request has a merge conflict that needs to be resolved. |
Contributor
|
As this PR has been waiting for the original user for a while but seems to be inactive, it's now going to be closed. But if there's anyone interested, feel free to create a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most SQL languages support datetime, date, and time as different data types.
Nevertheless, SQLModel's expression.py supports only datetime type. Since you can also use date and other types in model building, you cannot get proper completion when using
select()function and so on.Therefore, I propose to add date and time types from datetime module.