Try to get CLANG on Windows working

mdboom · mdboom · commit 2fd3804d7419 · 2025-04-11T12:14:21.000-04:00
diff --git a/bench_runner/scripts/workflow.py b/bench_runner/scripts/workflow.py
@@ -202,9 +202,9 @@ def compile_windows(
     if "CLANG" in flags:
         args.extend(
             [
-                r'"/p:PlatformToolset=clangcl"',
-                r'"/p:LLVMInstallDir=C:\Program Files\LLVM"',
-                r'"/p:LLVMToolsVersion=19.1.6"',
+                r"/p:PlatformToolset=clangcl",
+                r"/p:LLVMInstallDir=C:\Program Files\LLVM",
+                r"/p:LLVMToolsVersion=19.1.6",
                 "--tail-call-interp",
             ]
         )
@@ -214,7 +214,8 @@ def compile_windows(
             [
                 Path("PCbuild") / "build.bat",
                 *args,
-            ]
+            ],
+            shell=True,
         )
         shutil.copytree(get_windows_build_dir(force_32bit), "libs", dirs_exist_ok=True)
 

Original file line number	Diff line number	Diff line change
`@@ -202,9 +202,9 @@ def compile_windows(`
`202`	`202`	`if "CLANG" in flags:`
`203`	`203`	`args.extend(`
`204`	`204`	`[`
`205`		`- r'"/p:PlatformToolset=clangcl"',`
`206`		`- r'"/p:LLVMInstallDir=C:\Program Files\LLVM"',`
`207`		`- r'"/p:LLVMToolsVersion=19.1.6"',`
	`205`	`+ r"/p:PlatformToolset=clangcl",`
	`206`	`+ r"/p:LLVMInstallDir=C:\Program Files\LLVM",`
	`207`	`+ r"/p:LLVMToolsVersion=19.1.6",`
`208`	`208`	`"--tail-call-interp",`
`209`	`209`	`]`
`210`	`210`	`)`
`@@ -214,7 +214,8 @@ def compile_windows(`
`214`	`214`	`[`
`215`	`215`	`Path("PCbuild") / "build.bat",`
`216`	`216`	`*args,`
`217`		`- ]`
	`217`	`+ ],`
	`218`	`+ shell=True,`
`218`	`219`	`)`
`219`	`220`	`shutil.copytree(get_windows_build_dir(force_32bit), "libs", dirs_exist_ok=True)`
`220`	`221`