Skip to content

Commit 4532068

Browse files
committed
Merge branch 'dont-have-toplevel-runners-array' into dont-have-toplevel-weekly-array
2 parents f1dd121 + 1bb2be5 commit 4532068

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

CHANGELOG.md

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ specifying the runners to run on.
7373

7474
For example:
7575

76-
```toml
76+
````toml
7777
[[weekly]]
7878

7979
[weekly.default]
@@ -83,4 +83,15 @@ runners = ["linux", "darwin", "windows"]
8383
[weekly.tailcall]
8484
flags = ["TAILCALL"]
8585
runners = ["linux_clang", "darwin", "windows_clang"]
86+
87+
## v1.8.0
88+
89+
### bench_runner.toml change
90+
91+
The configuration no longer expects a top-level, single element `runners` array.
92+
93+
You should remove the following line from your `bench_runners.toml`:
94+
95+
```toml
96+
[[runners]]
8697
```

bench_runner/runners.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def display_name(self) -> str:
4848

4949
@functools.cache
5050
def get_runners() -> list[Runner]:
51-
conf = config.get_bench_runner_config().get("runners", [{}])[0]
51+
conf = config.get_bench_runner_config().get("runners", {})
5252
runners = []
5353
for nickname, section in conf.items():
5454
runners.append(

bench_runner/templates/bench_runner.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ notification_issue = 182
4242
# --enable-optimizations and --with-lto=full.
4343
# BUILD_DEST: (windows only) where to make build.bat install. This is
4444
# required for the Windows build to succeed.
45-
[[runners]]
4645

4746
[runners.linux]
4847
os = "linux"

tests/data/bench_runner.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
versions = ["base2", "base4"]
33
compare_to_default = ["NOGIL"]
44

5-
[[runners]]
65
[runners.linux]
76
os = "linux"
87
arch = "x86_64"

0 commit comments

Comments
 (0)