Make functions inline for the JIT

Author: markshannon

Include/internal/pycore_range.h

@@ -8,6 +8,14 @@ extern "C" {
 #  error "this header requires Py_BUILD_CORE define"
 #endif
 
+typedef struct {
+    PyObject_HEAD
+    PyObject *start;
+    PyObject *stop;
+    PyObject *step;
+    PyObject *length;
+} rangeobject;
+
 typedef struct {
     PyObject_HEAD
     long start;
@@ -16,9 +24,35 @@ typedef struct {
 } _PyRangeIterObject;
 
 // Does this range have step == 1 and both start and stop in compact int range?
-int _PyRange_IsSimpleCompact(PyObject *range);
-Py_ssize_t _PyRange_GetStartIfCompact(PyObject *range);
-Py_ssize_t _PyRange_GetStopIfCompact(PyObject *range);
+static inline int
+_PyRange_IsSimpleCompact(PyObject *range) {
+    assert(PyRange_Check(range));
+    rangeobject *r = (rangeobject*)range;
+    if (_PyLong_IsCompact((PyLongObject *)r->start) &&
+        _PyLong_IsCompact((PyLongObject *)r->stop) &&
+        r->step == _PyLong_GetOne()
+    ) {
+        return 1;
+    }
+    return 0;
+}
+
+static inline Py_ssize_t
+_PyRange_GetStartIfCompact(PyObject *range)
+{
+    assert(PyRange_Check(range));
+    rangeobject *r = (rangeobject*)range;
+    assert(_PyLong_IsCompact((PyLongObject *)r->start));
+    return _PyLong_CompactValue((PyLongObject *)r->start);
+}
+
+static inline Py_ssize_t
+_PyRange_GetStopIfCompact(PyObject *range) {
+    assert(PyRange_Check(range));
+    rangeobject *r = (rangeobject*)range;
+    assert(_PyLong_IsCompact((PyLongObject *)r->stop));
+    return _PyLong_CompactValue((PyLongObject *)r->stop);
+}
 
 #ifdef __cplusplus
 }

Objects/rangeobject.c

@@ -10,21 +10,6 @@
 #include "pycore_tuple.h"         // _PyTuple_ITEMS()
 
 
-/* Support objects whose length is > PY_SSIZE_T_MAX.
-
-   This could be sped up for small PyLongs if they fit in a Py_ssize_t.
-   This only matters on Win64.  Though we could use long long which
-   would presumably help perf.
-*/
-
-typedef struct {
-    PyObject_HEAD
-    PyObject *start;
-    PyObject *stop;
-    PyObject *step;
-    PyObject *length;
-} rangeobject;
-
 /* Helper function for validating step.  Always returns a new reference or
    NULL on error.
 */
@@ -156,34 +141,6 @@ range_vectorcall(PyObject *rangetype, PyObject *const *args,
     return range_from_array((PyTypeObject *)rangetype, args, nargs);
 }
 
-int
-_PyRange_IsSimpleCompact(PyObject *range) {
-    assert(PyRange_Check(range));
-    rangeobject *r = (rangeobject*)range;
-    if (_PyLong_IsCompact((PyLongObject *)r->start) &&
-        _PyLong_IsCompact((PyLongObject *)r->stop) &&
-        r->step == _PyLong_GetOne()
-    ) {
-        return 1;
-    }
-    return 0;
-}
-
-Py_ssize_t
-_PyRange_GetStartIfCompact(PyObject *range) {
-    assert(PyRange_Check(range));
-    rangeobject *r = (rangeobject*)range;
-    assert(_PyLong_IsCompact((PyLongObject *)r->start));
-    return _PyLong_CompactValue((PyLongObject *)r->start);
-}
-
-Py_ssize_t
-_PyRange_GetStopIfCompact(PyObject *range) {
-    assert(PyRange_Check(range));
-    rangeobject *r = (rangeobject*)range;
-    assert(_PyLong_IsCompact((PyLongObject *)r->stop));
-    return _PyLong_CompactValue((PyLongObject *)r->stop);
-}
 
 PyDoc_STRVAR(range_doc,
 "range(stop) -> range object\n\