Address review comments

Author: markshannon

Python/bytecodes.c

@@ -272,7 +272,7 @@ dummy_func(
         replicate(4) inst(LOAD_INT, (-- value)) {
             /* Tell code generator that this is a const load */
             (void)FRAME_CO_CONSTS;
-            assert(oparg < 256);
+            assert(oparg < _PY_NSMALLPOSINTS);
             PyObject *obj = (PyObject *)&_PyLong_SMALL_INTS[_PY_NSMALLNEGINTS + oparg];
             value = PyStackRef_FromPyObjectImmortal(obj);
         }

Python/codegen.c

@@ -283,7 +283,7 @@ codegen_addop_load_const(compiler *c, location loc, PyObject *o)
     if (PyLong_CheckExact(o)) {
         int overflow;
         long val = PyLong_AsLongAndOverflow(o, &overflow);
-        if (!overflow && val >= 0 && val < 256) {
+        if (!overflow && val >= 0 && val < 256 && val < _PY_NSMALLPOSINTS) {
             ADDOP_I(c, loc, LOAD_INT, val);
             return SUCCESS;
         }

Python/compile.c

@@ -447,8 +447,6 @@ _PyCompile_DictAddObj(PyObject *dict, PyObject *o)
 Py_ssize_t
 _PyCompile_AddConst(compiler *c, PyObject *o)
 {
-
-
     PyObject *key = merge_consts_recursive(c->c_const_cache, o);
     if (key == NULL) {
         return ERROR;

Python/executor_cases.c.h

@@ -283,7 +283,7 @@ dump_instr(cfg_instr *i)
 static inline int
 basicblock_returns(const basicblock *b) {
     cfg_instr *last = basicblock_last_instr(b);
-    return last && last->i_opcode == RETURN_VALUE);
+    return last && last->i_opcode == RETURN_VALUE;
 }
 
 static void