WM (Windows): detect version of DWM

CarterLi · CarterLi · commit 0fde8356296c · 2025-01-02T16:35:53.000+08:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1003,6 +1003,7 @@ elseif(WIN32)
         src/util/windows/registry.c
         src/util/windows/unicode.c
         src/util/windows/wmi.cpp
+        src/util/windows/version.c
         src/util/platform/FFPlatform_windows.c
         src/util/binary_windows.c
     )
diff --git a/src/detection/terminalshell/terminalshell.c b/src/detection/terminalshell/terminalshell.c
@@ -15,41 +15,18 @@
     #define _PATH_LOCALBASE "/usr/local"
 #elif __NetBSD__
     #define _PATH_LOCALBASE "/usr/pkg"
-#endif
-
-#ifdef _WIN32
-
-#include "util/mallocHelper.h"
+#elif _WIN32
 
-#include <winver.h>
+#include "util/windows/version.h"
+#include <windows.h>
 
-static bool getFileVersion(const char* exePath, FFstrbuf* version)
+static bool getFileVersion(const FFstrbuf* exePath, FFstrbuf* version)
 {
-    DWORD handle;
-    DWORD size = GetFileVersionInfoSizeA(exePath, &handle);
-    if(size > 0)
-    {
-        FF_AUTO_FREE void* versionData = malloc(size);
-        if(GetFileVersionInfoA(exePath, handle, size, versionData))
-        {
-            VS_FIXEDFILEINFO* verInfo;
-            UINT len;
-            if(VerQueryValueW(versionData, L"\\", (void**)&verInfo, &len) && len && verInfo->dwSignature == 0xFEEF04BD)
-            {
-                ffStrbufAppendF(version, "%u.%u.%u.%u",
-                    (unsigned)(( verInfo->dwFileVersionMS >> 16 ) & 0xffff),
-                    (unsigned)(( verInfo->dwFileVersionMS >>  0 ) & 0xffff),
-                    (unsigned)(( verInfo->dwFileVersionLS >> 16 ) & 0xffff),
-                    (unsigned)(( verInfo->dwFileVersionLS >>  0 ) & 0xffff)
-                );
-                return true;
-            }
-        }
-    }
-
-    return false;
+    wchar_t exePathW[PATH_MAX];
+    int len = MultiByteToWideChar(CP_UTF8, 0, exePath->chars, (int)exePath->length, exePathW, ARRAY_SIZE(exePathW));
+    if (len <= 0) return false;
+    return ffGetFileVersion(exePathW, version);
 }
-
 #endif
 
 static bool getExeVersionRaw(FFstrbuf* exe, FFstrbuf* version)
@@ -119,7 +96,7 @@ static bool getShellVersionPwsh(FFstrbuf* exe, FFstrbuf* version)
     }
 
     #ifdef _WIN32
-    if(getFileVersion(exe->chars, version))
+    if(getFileVersion(exe, version))
     {
         ffStrbufSubstrBeforeLastC(version, '.');
         return true;
@@ -312,7 +289,7 @@ bool fftsGetShellVersion(FFstrbuf* exe, const char* exeName, FFstrbuf* exePath,
     if(ffStrEqualsIgnCase(exeName, "powershell") || ffStrEqualsIgnCase(exeName, "powershell_ise"))
         return getShellVersionWinPowerShell(exe, version);
 
-    return getFileVersion(exe->chars, version);
+    return getFileVersion(exe, version);
     #endif
 
     return false;
@@ -706,7 +683,7 @@ static bool getTerminalVersionWindowsTerminal(FFstrbuf* exe, FFstrbuf* version)
         return true;
     }
 
-    return getFileVersion(exe->chars, version);
+    return getFileVersion(exe, version);
 }
 
 static bool getTerminalVersionConEmu(FFstrbuf* exe, FFstrbuf* version)
@@ -716,7 +693,7 @@ static bool getTerminalVersionConEmu(FFstrbuf* exe, FFstrbuf* version)
     if(version->length)
         return true;
 
-    return getFileVersion(exe->chars, version);
+    return getFileVersion(exe, version);
 }
 
 #endif
@@ -875,7 +852,7 @@ bool fftsGetTerminalVersion(FFstrbuf* processName, FF_MAYBE_UNUSED FFstrbuf* exe
 
     #ifdef _WIN32
 
-    return getFileVersion(exe->chars, version);
+    return getFileVersion(exe, version);
 
     #else
 
diff --git a/src/detection/terminalshell/terminalshell_windows.c b/src/detection/terminalshell/terminalshell_windows.c
@@ -5,39 +5,13 @@
 #include "util/mallocHelper.h"
 #include "util/windows/registry.h"
 #include "util/windows/unicode.h"
+#include "util/windows/version.h"
 #include "util/stringUtils.h"
 
 #include <windows.h>
 #include <wchar.h>
 #include <tlhelp32.h>
 
-static bool getProductVersion(const wchar_t* filePath, FFstrbuf* version)
-{
-    DWORD handle;
-    DWORD size = GetFileVersionInfoSizeW(filePath, &handle);
-    if(size > 0)
-    {
-        FF_AUTO_FREE void* versionData = malloc(size);
-        if(GetFileVersionInfoW(filePath, handle, size, versionData))
-        {
-            VS_FIXEDFILEINFO* verInfo;
-            UINT len;
-            if(VerQueryValueW(versionData, L"\\", (void**)&verInfo, &len) && len && verInfo->dwSignature == 0xFEEF04BD)
-            {
-                ffStrbufAppendF(version, "%u.%u.%u.%u",
-                    (unsigned)(( verInfo->dwProductVersionMS >> 16 ) & 0xffff),
-                    (unsigned)(( verInfo->dwProductVersionMS >>  0 ) & 0xffff),
-                    (unsigned)(( verInfo->dwProductVersionLS >> 16 ) & 0xffff),
-                    (unsigned)(( verInfo->dwProductVersionLS >>  0 ) & 0xffff)
-                );
-                return true;
-            }
-        }
-    }
-
-    return false;
-}
-
 bool fftsGetShellVersion(FFstrbuf* exe, const char* exeName, const FFstrbuf* exePath, FFstrbuf* version);
 
 static uint32_t getShellInfo(FFShellResult* result, uint32_t pid)
@@ -113,7 +87,7 @@ static void setShellInfoDetails(FFShellResult* result)
                     if(wcsncmp(module.szModule, L"clink_dll_", strlen("clink_dll_")) == 0)
                     {
                         ffStrbufAppendS(&result->prettyName, " (with Clink ");
-                        getProductVersion(module.szExePath, &result->prettyName);
+                        ffGetFileVersion(module.szExePath, &result->prettyName);
                         ffStrbufAppendC(&result->prettyName, ')');
                         break;
                     }
diff --git a/src/detection/wm/wm_windows.cpp b/src/detection/wm/wm_windows.cpp
@@ -3,6 +3,7 @@ extern "C"
 #include "wm.h"
 #include "common/io/io.h"
 #include "detection/terminalshell/terminalshell.h"
+#include "util/windows/version.h"
 }
 
 #include "util/windows/com.hpp"
@@ -65,7 +66,23 @@ const char* ffDetectWMPlugin(FFstrbuf* pluginName)
     return NULL;
 }
 
-const char* ffDetectWMVersion(FF_MAYBE_UNUSED const FFstrbuf* wmName, FF_MAYBE_UNUSED FFstrbuf* result, FF_MAYBE_UNUSED FFWMOptions* options)
+const char* ffDetectWMVersion(const FFstrbuf* wmName, FFstrbuf* result, FF_MAYBE_UNUSED FFWMOptions* options)
 {
+    if (!wmName)
+        return "No WM detected";
+
+    if (ffStrbufEqualS(wmName, "dwm.exe"))
+    {
+        PWSTR pPath = NULL;
+        if(SUCCEEDED(SHGetKnownFolderPath(FOLDERID_System, KF_FLAG_DEFAULT, NULL, &pPath)))
+        {
+            wchar_t fullPath[MAX_PATH];
+            wcscpy(fullPath, pPath);
+            wcscat(fullPath, L"\\dwm.exe");
+            ffGetFileVersion(fullPath, result);
+        }
+        CoTaskMemFree(pPath);
+        return NULL;
+    }
     return "Not supported on this platform";
 }
diff --git a/src/util/platform/FFPlatform_windows.c b/src/util/platform/FFPlatform_windows.c
@@ -31,51 +31,51 @@ static void getExePath(FFPlatform* platform)
 
 static void getHomeDir(FFPlatform* platform)
 {
-    PWSTR pPath;
+    PWSTR pPath = NULL;
     if(SUCCEEDED(SHGetKnownFolderPath(&FOLDERID_Profile, KF_FLAG_DEFAULT, NULL, &pPath)))
     {
         ffStrbufSetWS(&platform->homeDir, pPath);
         ffStrbufReplaceAllC(&platform->homeDir, '\\', '/');
         ffStrbufEnsureEndsWithC(&platform->homeDir, '/');
-        CoTaskMemFree(pPath);
     }
     else
     {
         ffStrbufSetS(&platform->homeDir, getenv("USERPROFILE"));
         ffStrbufReplaceAllC(&platform->homeDir, '\\', '/');
         ffStrbufEnsureEndsWithC(&platform->homeDir, '/');
     }
+    CoTaskMemFree(pPath);
 }
 
 static void getCacheDir(FFPlatform* platform)
 {
-    PWSTR pPath;
+    PWSTR pPath = NULL;
     if(SUCCEEDED(SHGetKnownFolderPath(&FOLDERID_LocalAppData, KF_FLAG_DEFAULT, NULL, &pPath)))
     {
         ffStrbufSetWS(&platform->cacheDir, pPath);
         ffStrbufReplaceAllC(&platform->cacheDir, '\\', '/');
         ffStrbufEnsureEndsWithC(&platform->cacheDir, '/');
-        CoTaskMemFree(pPath);
     }
     else
     {
         ffStrbufAppend(&platform->cacheDir, &platform->homeDir);
         ffStrbufAppendS(&platform->cacheDir, "AppData/Local/");
     }
+    CoTaskMemFree(pPath);
 }
 
 static void platformPathAddKnownFolder(FFlist* dirs, REFKNOWNFOLDERID folderId)
 {
-    PWSTR pPath;
+    PWSTR pPath = NULL;
     if(SUCCEEDED(SHGetKnownFolderPath(folderId, 0, NULL, &pPath)))
     {
         FF_STRBUF_AUTO_DESTROY buffer = ffStrbufCreateWS(pPath);
         ffStrbufReplaceAllC(&buffer, '\\', '/');
         ffStrbufEnsureEndsWithC(&buffer, '/');
         if (!ffListContains(dirs, &buffer, (void*) ffStrbufEqual))
             ffStrbufInitMove((FFstrbuf*) ffListAdd(dirs), &buffer);
-        CoTaskMemFree(pPath);
     }
+    CoTaskMemFree(pPath);
 }
 
 static void platformPathAddEnvSuffix(FFlist* dirs, const char* env, const char* suffix)
diff --git a/src/util/windows/version.c b/src/util/windows/version.c
@@ -0,0 +1,31 @@
+#include "util/windows/version.h"
+#include "util/mallocHelper.h"
+
+#include <windows.h>
+
+bool ffGetFileVersion(const wchar_t* filePath, FFstrbuf* version)
+{
+    DWORD handle;
+    DWORD size = GetFileVersionInfoSizeW(filePath, &handle);
+    if(size > 0)
+    {
+        FF_AUTO_FREE void* versionData = malloc(size);
+        if(GetFileVersionInfoW(filePath, handle, size, versionData))
+        {
+            VS_FIXEDFILEINFO* verInfo;
+            UINT len;
+            if(VerQueryValueW(versionData, L"\\", (void**)&verInfo, &len) && len && verInfo->dwSignature == 0xFEEF04BD)
+            {
+                ffStrbufAppendF(version, "%u.%u.%u.%u",
+                    (unsigned)(( verInfo->dwProductVersionMS >> 16 ) & 0xffff),
+                    (unsigned)(( verInfo->dwProductVersionMS >>  0 ) & 0xffff),
+                    (unsigned)(( verInfo->dwProductVersionLS >> 16 ) & 0xffff),
+                    (unsigned)(( verInfo->dwProductVersionLS >>  0 ) & 0xffff)
+                );
+                return true;
+            }
+        }
+    }
+
+    return false;
+}
diff --git a/src/util/windows/version.h b/src/util/windows/version.h
@@ -0,0 +1,3 @@
+#include "fastfetch.h"
+
+bool ffGetFileVersion(const wchar_t* filePath, FFstrbuf* version);

Original file line number	Diff line number	Diff line change
`@@ -1003,6 +1003,7 @@ elseif(WIN32)`
`1003`	`1003`	`src/util/windows/registry.c`
`1004`	`1004`	`src/util/windows/unicode.c`
`1005`	`1005`	`src/util/windows/wmi.cpp`
	`1006`	`+ src/util/windows/version.c`
`1006`	`1007`	`src/util/platform/FFPlatform_windows.c`
`1007`	`1008`	`src/util/binary_windows.c`
`1008`	`1009`	`)`
Original file line number	Diff line number	Diff line change
`@@ -31,51 +31,51 @@ static void getExePath(FFPlatform* platform)`
`31`	`31`
`32`	`32`	`static void getHomeDir(FFPlatform* platform)`
`33`	`33`	`{`
`34`		`- PWSTR pPath;`
	`34`	`+ PWSTR pPath = NULL;`
`35`	`35`	`if(SUCCEEDED(SHGetKnownFolderPath(&FOLDERID_Profile, KF_FLAG_DEFAULT, NULL, &pPath)))`
`36`	`36`	`{`
`37`	`37`	`ffStrbufSetWS(&platform->homeDir, pPath);`
`38`	`38`	`ffStrbufReplaceAllC(&platform->homeDir, '\\', '/');`
`39`	`39`	`ffStrbufEnsureEndsWithC(&platform->homeDir, '/');`
`40`		`- CoTaskMemFree(pPath);`
`41`	`40`	`}`
`42`	`41`	`else`
`43`	`42`	`{`
`44`	`43`	`ffStrbufSetS(&platform->homeDir, getenv("USERPROFILE"));`
`45`	`44`	`ffStrbufReplaceAllC(&platform->homeDir, '\\', '/');`
`46`	`45`	`ffStrbufEnsureEndsWithC(&platform->homeDir, '/');`
`47`	`46`	`}`
	`47`	`+ CoTaskMemFree(pPath);`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`static void getCacheDir(FFPlatform* platform)`
`51`	`51`	`{`
`52`		`- PWSTR pPath;`
	`52`	`+ PWSTR pPath = NULL;`
`53`	`53`	`if(SUCCEEDED(SHGetKnownFolderPath(&FOLDERID_LocalAppData, KF_FLAG_DEFAULT, NULL, &pPath)))`
`54`	`54`	`{`
`55`	`55`	`ffStrbufSetWS(&platform->cacheDir, pPath);`
`56`	`56`	`ffStrbufReplaceAllC(&platform->cacheDir, '\\', '/');`
`57`	`57`	`ffStrbufEnsureEndsWithC(&platform->cacheDir, '/');`
`58`		`- CoTaskMemFree(pPath);`
`59`	`58`	`}`
`60`	`59`	`else`
`61`	`60`	`{`
`62`	`61`	`ffStrbufAppend(&platform->cacheDir, &platform->homeDir);`
`63`	`62`	`ffStrbufAppendS(&platform->cacheDir, "AppData/Local/");`
`64`	`63`	`}`
	`64`	`+ CoTaskMemFree(pPath);`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`static void platformPathAddKnownFolder(FFlist* dirs, REFKNOWNFOLDERID folderId)`
`68`	`68`	`{`
`69`		`- PWSTR pPath;`
	`69`	`+ PWSTR pPath = NULL;`
`70`	`70`	`if(SUCCEEDED(SHGetKnownFolderPath(folderId, 0, NULL, &pPath)))`
`71`	`71`	`{`
`72`	`72`	`FF_STRBUF_AUTO_DESTROY buffer = ffStrbufCreateWS(pPath);`
`73`	`73`	`ffStrbufReplaceAllC(&buffer, '\\', '/');`
`74`	`74`	`ffStrbufEnsureEndsWithC(&buffer, '/');`
`75`	`75`	`if (!ffListContains(dirs, &buffer, (void*) ffStrbufEqual))`
`76`	`76`	`ffStrbufInitMove((FFstrbuf*) ffListAdd(dirs), &buffer);`
`77`		`- CoTaskMemFree(pPath);`
`78`	`77`	`}`
	`78`	`+ CoTaskMemFree(pPath);`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`static void platformPathAddEnvSuffix(FFlist* dirs, const char* env, const char* suffix)`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+#include "fastfetch.h"`
	`2`	`+`
	`3`	`+bool ffGetFileVersion(const wchar_t* filePath, FFstrbuf* version);`