GPU (FreeBSD): fix mem leaks

CarterLi · CarterLi · commit 4f42d38e4d0f · 2025-06-18T20:20:49.000+08:00
diff --git a/src/detection/gpu/gpu_bsd.c b/src/detection/gpu/gpu_bsd.c
@@ -45,9 +45,12 @@ static const char* detectByDrm(const FFGPUOptions* options, FFlist* gpus)
 {
     FF_LIBRARY_LOAD(libdrm, "dlopen libdrm" FF_LIBRARY_EXTENSION " failed", "libdrm" FF_LIBRARY_EXTENSION, 2)
     FF_LIBRARY_LOAD_SYMBOL_MESSAGE(libdrm, drmGetDevices)
+    FF_LIBRARY_LOAD_SYMBOL_MESSAGE(libdrm, drmFreeDevices)
 
     drmDevicePtr devices[64];
     int nDevices = ffdrmGetDevices(devices, ARRAY_SIZE(devices));
+    if (nDevices < 0)
+        return "drmGetDevices() failed";
 
     for (int iDev = 0; iDev < nDevices; ++iDev)
     {
@@ -136,6 +139,8 @@ static const char* detectByDrm(const FFGPUOptions* options, FFlist* gpus)
         fillGPUTypeGeneric(gpu);
     }
 
+    ffdrmFreeDevices(devices, nDevices);
+
     return NULL;
 }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -45,9 +45,12 @@ static const char* detectByDrm(const FFGPUOptions* options, FFlist* gpus)`
`45`	`45`	`{`
`46`	`46`	`FF_LIBRARY_LOAD(libdrm, "dlopen libdrm" FF_LIBRARY_EXTENSION " failed", "libdrm" FF_LIBRARY_EXTENSION, 2)`
`47`	`47`	`FF_LIBRARY_LOAD_SYMBOL_MESSAGE(libdrm, drmGetDevices)`
	`48`	`+ FF_LIBRARY_LOAD_SYMBOL_MESSAGE(libdrm, drmFreeDevices)`
`48`	`49`
`49`	`50`	`drmDevicePtr devices[64];`
`50`	`51`	`int nDevices = ffdrmGetDevices(devices, ARRAY_SIZE(devices));`
	`52`	`+ if (nDevices < 0)`
	`53`	`+ return "drmGetDevices() failed";`
`51`	`54`
`52`	`55`	`for (int iDev = 0; iDev < nDevices; ++iDev)`
`53`	`56`	`{`
`@@ -136,6 +139,8 @@ static const char* detectByDrm(const FFGPUOptions* options, FFlist* gpus)`
`136`	`139`	`fillGPUTypeGeneric(gpu);`
`137`	`140`	`}`
`138`	`141`
	`142`	`+ ffdrmFreeDevices(devices, nDevices);`
	`143`	`+`
`139`	`144`	`return NULL;`
`140`	`145`	`}`
`141`	`146`	`#endif`