Skip to content

Commit 505ff6f

Browse files
committed
Global: renames fractionTrailingZeros enum to always/never for consistance
1 parent 3905493 commit 505ff6f

File tree

6 files changed

+13
-13
lines changed

6 files changed

+13
-13
lines changed

doc/json_schema.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1356,11 +1356,11 @@
13561356
"description": "Use the behavior defined internally"
13571357
},
13581358
{
1359-
"const": "show",
1359+
"const": "always",
13601360
"description": "Always keep trailing zeros"
13611361
},
13621362
{
1363-
"const": "hide",
1363+
"const": "never",
13641364
"description": "Never keep trailing zeros"
13651365
}
13661366
],

src/common/format.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ void ffFormatAppendFormatArg(FFstrbuf* buffer, const FFformatarg* formatarg)
3232
ffStrbufAppend(buffer, (const FFstrbuf*)formatarg->value);
3333
break;
3434
case FF_FORMAT_ARG_TYPE_FLOAT:
35-
ffStrbufAppendDouble(buffer, *(float*)formatarg->value, instance.config.display.fractionNdigits, instance.config.display.fractionTrailingZeros != FF_FRACTION_TRAILING_ZEROS_TYPE_HIDE);
35+
ffStrbufAppendDouble(buffer, *(float*)formatarg->value, instance.config.display.fractionNdigits, instance.config.display.fractionTrailingZeros != FF_FRACTION_TRAILING_ZEROS_TYPE_NEVER);
3636
break;
3737
case FF_FORMAT_ARG_TYPE_DOUBLE:
38-
ffStrbufAppendDouble(buffer, *(double*)formatarg->value, instance.config.display.fractionNdigits, instance.config.display.fractionTrailingZeros != FF_FRACTION_TRAILING_ZEROS_TYPE_HIDE);
38+
ffStrbufAppendDouble(buffer, *(double*)formatarg->value, instance.config.display.fractionNdigits, instance.config.display.fractionTrailingZeros != FF_FRACTION_TRAILING_ZEROS_TYPE_NEVER);
3939
break;
4040
case FF_FORMAT_ARG_TYPE_BOOL:
4141
ffStrbufAppendS(buffer, *(bool*)formatarg->value ? "true" : "false");

src/modules/display/display.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ bool ffPrintDisplay(FFDisplayOptions* options)
114114
result->scaledHeight > 0 && result->scaledHeight != result->height)
115115
{
116116
ffStrbufAppendS(&buffer, " @ ");
117-
ffStrbufAppendDouble(&buffer, scaleFactor, instance.config.display.fractionNdigits, instance.config.display.fractionTrailingZeros == FF_FRACTION_TRAILING_ZEROS_TYPE_SHOW);
117+
ffStrbufAppendDouble(&buffer, scaleFactor, instance.config.display.fractionNdigits, instance.config.display.fractionTrailingZeros == FF_FRACTION_TRAILING_ZEROS_TYPE_ALWAYS);
118118
ffStrbufAppendC(&buffer, 'x');
119119
}
120120

src/modules/localip/localip.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@ static void appendSpeed(FFLocalIpResult* ip, FFstrbuf* strbuf)
3737
{
3838
if (ip->speed >= 1000000)
3939
{
40-
ffStrbufAppendDouble(strbuf, ip->speed / 1e6, instance.config.display.fractionNdigits, instance.config.display.fractionTrailingZeros == FF_FRACTION_TRAILING_ZEROS_TYPE_SHOW);
40+
ffStrbufAppendDouble(strbuf, ip->speed / 1e6, instance.config.display.fractionNdigits, instance.config.display.fractionTrailingZeros == FF_FRACTION_TRAILING_ZEROS_TYPE_ALWAYS);
4141
ffStrbufAppendS(strbuf, " Tbps");
4242
}
4343
else if (ip->speed >= 1000)
4444
{
45-
ffStrbufAppendDouble(strbuf, ip->speed / 1e3, instance.config.display.fractionNdigits, instance.config.display.fractionTrailingZeros == FF_FRACTION_TRAILING_ZEROS_TYPE_SHOW);
45+
ffStrbufAppendDouble(strbuf, ip->speed / 1e3, instance.config.display.fractionNdigits, instance.config.display.fractionTrailingZeros == FF_FRACTION_TRAILING_ZEROS_TYPE_ALWAYS);
4646
ffStrbufAppendS(strbuf, " Gbps");
4747
}
4848
else

src/options/display.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -420,8 +420,8 @@ const char* ffOptionsParseDisplayJsonConfig(FFOptionsDisplay* options, yyjson_va
420420
int value;
421421
const char* error = ffJsonConfigParseEnum(trailingZeros, &value, (FFKeyValuePair[]) {
422422
{ "default", FF_FRACTION_TRAILING_ZEROS_TYPE_DEFAULT },
423-
{ "show", FF_FRACTION_TRAILING_ZEROS_TYPE_SHOW },
424-
{ "hide", FF_FRACTION_TRAILING_ZEROS_TYPE_HIDE },
423+
{ "always", FF_FRACTION_TRAILING_ZEROS_TYPE_ALWAYS },
424+
{ "never", FF_FRACTION_TRAILING_ZEROS_TYPE_NEVER },
425425
{},
426426
});
427427
if (error) return error;
@@ -755,8 +755,8 @@ bool ffOptionsParseDisplayCommandLine(FFOptionsDisplay* options, const char* key
755755
{
756756
options->fractionTrailingZeros = (FFFractionTrailingZerosType) ffOptionParseEnum(key, value, (FFKeyValuePair[]) {
757757
{ "default", FF_FRACTION_TRAILING_ZEROS_TYPE_DEFAULT },
758-
{ "show", FF_FRACTION_TRAILING_ZEROS_TYPE_SHOW },
759-
{ "hide", FF_FRACTION_TRAILING_ZEROS_TYPE_HIDE },
758+
{ "always", FF_FRACTION_TRAILING_ZEROS_TYPE_ALWAYS },
759+
{ "never", FF_FRACTION_TRAILING_ZEROS_TYPE_NEVER },
760760
{},
761761
});
762762
}

src/options/display.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ typedef enum __attribute__((__packed__)) FFSpaceBeforeUnitType
2828
typedef enum __attribute__((__packed__)) FFFractionTrailingZerosType
2929
{
3030
FF_FRACTION_TRAILING_ZEROS_TYPE_DEFAULT,
31-
FF_FRACTION_TRAILING_ZEROS_TYPE_SHOW,
32-
FF_FRACTION_TRAILING_ZEROS_TYPE_HIDE,
31+
FF_FRACTION_TRAILING_ZEROS_TYPE_ALWAYS,
32+
FF_FRACTION_TRAILING_ZEROS_TYPE_NEVER,
3333
} FFFractionTrailingZerosType;
3434

3535
typedef struct FFOptionsDisplay

0 commit comments

Comments
 (0)