Skip to content

Commit 52715a0

Browse files
committed
Fastfetch: rename binaryPrefixType to sizeBinaryPrefix
1 parent 4a6209e commit 52715a0

File tree

3 files changed

+34
-36
lines changed

3 files changed

+34
-36
lines changed

src/common/parsing.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,15 +79,15 @@ static void parseSize(FFstrbuf* result, uint64_t bytes, uint32_t base, const cha
7979

8080
void ffParseSize(uint64_t bytes, FFstrbuf* result)
8181
{
82-
switch (instance.config.display.binaryPrefixType)
82+
switch (instance.config.display.sizeBinaryPrefix)
8383
{
84-
case FF_BINARY_PREFIX_TYPE_IEC:
84+
case FF_SIZE_BINARY_PREFIX_TYPE_IEC:
8585
parseSize(result, bytes, 1024, (const char*[]) {"B", "KiB", "MiB", "GiB", "TiB", "PiB", "EiB", "ZiB", "YiB", NULL});
8686
break;
87-
case FF_BINARY_PREFIX_TYPE_SI:
87+
case FF_SIZE_BINARY_PREFIX_TYPE_SI:
8888
parseSize(result, bytes, 1000, (const char*[]) {"B", "kB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB", NULL});
8989
break;
90-
case FF_BINARY_PREFIX_TYPE_JEDEC:
90+
case FF_SIZE_BINARY_PREFIX_TYPE_JEDEC:
9191
parseSize(result, bytes, 1024, (const char*[]) {"B", "KB", "MB", "GB", "TB", NULL});
9292
break;
9393
default:

src/options/display.c

Lines changed: 24 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -92,13 +92,13 @@ const char* ffOptionsParseDisplayJsonConfig(FFOptionsDisplay* options, yyjson_va
9292
{
9393
int value;
9494
const char* error = ffJsonConfigParseEnum(binaryPrefix, &value, (FFKeyValuePair[]) {
95-
{ "iec", FF_BINARY_PREFIX_TYPE_IEC },
96-
{ "si", FF_BINARY_PREFIX_TYPE_SI },
97-
{ "jedec", FF_BINARY_PREFIX_TYPE_JEDEC },
95+
{ "iec", FF_SIZE_BINARY_PREFIX_TYPE_IEC },
96+
{ "si", FF_SIZE_BINARY_PREFIX_TYPE_SI },
97+
{ "jedec", FF_SIZE_BINARY_PREFIX_TYPE_JEDEC },
9898
{},
9999
});
100100
if (error) return error;
101-
options->binaryPrefixType = (FFBinaryPrefixType) value;
101+
options->sizeBinaryPrefix = (FFSizeBinaryPrefixType) value;
102102
}
103103

104104
yyjson_val* ndigits = yyjson_obj_get(val, "ndigits");
@@ -300,10 +300,10 @@ bool ffOptionsParseDisplayCommandLine(FFOptionsDisplay* options, const char* key
300300
const char* subkey = key + strlen("--size-");
301301
if (ffStrEqualsIgnCase(subkey, "binary-prefix"))
302302
{
303-
options->binaryPrefixType = (FFBinaryPrefixType) ffOptionParseEnum(key, value, (FFKeyValuePair[]) {
304-
{ "iec", FF_BINARY_PREFIX_TYPE_IEC },
305-
{ "si", FF_BINARY_PREFIX_TYPE_SI },
306-
{ "jedec", FF_BINARY_PREFIX_TYPE_JEDEC },
303+
options->sizeBinaryPrefix = (FFSizeBinaryPrefixType) ffOptionParseEnum(key, value, (FFKeyValuePair[]) {
304+
{ "iec", FF_SIZE_BINARY_PREFIX_TYPE_IEC },
305+
{ "si", FF_SIZE_BINARY_PREFIX_TYPE_SI },
306+
{ "jedec", FF_SIZE_BINARY_PREFIX_TYPE_JEDEC },
307307
{}
308308
});
309309
}
@@ -417,7 +417,7 @@ void ffOptionsInitDisplay(FFOptionsDisplay* options)
417417
#endif
418418

419419
options->hideCursor = false;
420-
options->binaryPrefixType = FF_BINARY_PREFIX_TYPE_IEC;
420+
options->sizeBinaryPrefix = FF_SIZE_BINARY_PREFIX_TYPE_IEC;
421421
options->sizeNdigits = 2;
422422
options->sizeMaxPrefix = UINT8_MAX;
423423
options->stat = false;
@@ -506,23 +506,6 @@ void ffOptionsGenerateDisplayJsonConfig(FFOptionsDisplay* options, yyjson_mut_do
506506
if (options->brightColor != defaultOptions.brightColor)
507507
yyjson_mut_obj_add_bool(doc, obj, "brightColor", options->brightColor);
508508

509-
if (options->binaryPrefixType != defaultOptions.binaryPrefixType)
510-
{
511-
switch (options->binaryPrefixType)
512-
{
513-
case FF_BINARY_PREFIX_TYPE_IEC:
514-
yyjson_mut_obj_add_str(doc, obj, "binaryPrefix", "iec");
515-
break;
516-
case FF_BINARY_PREFIX_TYPE_SI:
517-
yyjson_mut_obj_add_str(doc, obj, "binaryPrefix", "si");
518-
break;
519-
case FF_BINARY_PREFIX_TYPE_JEDEC:
520-
yyjson_mut_obj_add_str(doc, obj, "binaryPrefix", "jedec");
521-
break;
522-
523-
}
524-
}
525-
526509
{
527510
yyjson_mut_val* size = yyjson_mut_obj(doc);
528511
if (options->sizeNdigits != defaultOptions.sizeNdigits)
@@ -541,6 +524,21 @@ void ffOptionsGenerateDisplayJsonConfig(FFOptionsDisplay* options, yyjson_mut_do
541524
"YB",
542525
})[options->sizeMaxPrefix]);
543526
}
527+
if (options->sizeBinaryPrefix != defaultOptions.sizeBinaryPrefix)
528+
{
529+
switch (options->sizeBinaryPrefix)
530+
{
531+
case FF_SIZE_BINARY_PREFIX_TYPE_IEC:
532+
yyjson_mut_obj_add_str(doc, size, "binaryPrefix", "iec");
533+
break;
534+
case FF_SIZE_BINARY_PREFIX_TYPE_SI:
535+
yyjson_mut_obj_add_str(doc, size, "binaryPrefix", "si");
536+
break;
537+
case FF_SIZE_BINARY_PREFIX_TYPE_JEDEC:
538+
yyjson_mut_obj_add_str(doc, size, "binaryPrefix", "jedec");
539+
break;
540+
}
541+
}
544542
if (yyjson_mut_obj_size(size) > 0)
545543
yyjson_mut_obj_add_val(doc, obj, "size", size);
546544
}

src/options/display.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22

33
#include "util/FFstrbuf.h"
44

5-
typedef enum FFBinaryPrefixType
5+
typedef enum FFSizeBinaryPrefixType
66
{
7-
FF_BINARY_PREFIX_TYPE_IEC, // 1024 Bytes = 1 KiB, 1024 KiB = 1 MiB, ... (standard)
8-
FF_BINARY_PREFIX_TYPE_SI, // 1000 Bytes = 1 KB, 1000 KB = 1 MB, ...
9-
FF_BINARY_PREFIX_TYPE_JEDEC, // 1024 Bytes = 1 kB, 1024 kB = 1 MB, ...
10-
} FFBinaryPrefixType;
7+
FF_SIZE_BINARY_PREFIX_TYPE_IEC, // 1024 Bytes = 1 KiB, 1024 KiB = 1 MiB, ... (standard)
8+
FF_SIZE_BINARY_PREFIX_TYPE_SI, // 1000 Bytes = 1 KB, 1000 KB = 1 MB, ...
9+
FF_SIZE_BINARY_PREFIX_TYPE_JEDEC, // 1024 Bytes = 1 kB, 1024 kB = 1 MB, ...
10+
} FFSizeBinaryPrefixType;
1111

1212
typedef enum FFTemperatureUnit
1313
{
@@ -33,7 +33,7 @@ typedef struct FFOptionsDisplay
3333
bool showErrors;
3434
bool disableLinewrap;
3535
bool hideCursor;
36-
FFBinaryPrefixType binaryPrefixType;
36+
FFSizeBinaryPrefixType sizeBinaryPrefix;
3737
uint8_t sizeNdigits;
3838
uint8_t sizeMaxPrefix;
3939
FFTemperatureUnit tempUnit;

0 commit comments

Comments
 (0)