StringUtils: fix a possible segfault

CarterLi · CarterLi · commit c081268b7cb6 · 2025-02-14T19:34:33.000+08:00
diff --git a/src/util/stringUtils.h b/src/util/stringUtils.h
@@ -83,7 +83,7 @@ static inline bool ffCharIsDigit(char c)
 // Copies at most (dstBufSiz - 1) bytes from src to dst; dst is always null-terminated
 static inline char* ffStrCopy(char* __restrict__ dst, const char* __restrict__ src, size_t dstBufSiz)
 {
-    if (__builtin_expect(dst == NULL, false)) return dst;
+    if (__builtin_expect(dst == NULL, false) || dstBufSiz == 0) return dst;
 
     size_t len = strnlen(src, dstBufSiz - 1);
     memcpy(dst, src, len);

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ static inline bool ffCharIsDigit(char c)`
`83`	`83`	`// Copies at most (dstBufSiz - 1) bytes from src to dst; dst is always null-terminated`
`84`	`84`	`static inline char* ffStrCopy(char* __restrict__ dst, const char* __restrict__ src, size_t dstBufSiz)`
`85`	`85`	`{`
`86`		`- if (__builtin_expect(dst == NULL, false)) return dst;`
	`86`	`+ if (__builtin_expect(dst == NULL, false) \|\| dstBufSiz == 0) return dst;`
`87`	`87`
`88`	`88`	`size_t len = strnlen(src, dstBufSiz - 1);`
`89`	`89`	`memcpy(dst, src, len);`