Skip to content

Commit dbe0c84

Browse files
committed
OS (Linux): don't display duplicate entries
1 parent 91724c0 commit dbe0c84

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ Bugfixes:
2020
* Correctly capitalize GNOME (#997, DE, Linux)
2121
* Fix segfault on system using turkish language (#995, InitSystem, Linux)
2222
* Fix kubuntu detection (#1000, OS, Linux)
23+
* Don't display duplicate entries (OS, Linux)
2324

2425
# 2.14.0
2526

src/modules/os/os.c

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
static void buildOutputDefault(const FFOSResult* os, FFstrbuf* result)
1313
{
14+
// asm ("int3");
1415
//Create the basic output
1516
if(os->name.length > 0)
1617
ffStrbufAppend(result, &os->name);
@@ -22,40 +23,40 @@ static void buildOutputDefault(const FFOSResult* os, FFstrbuf* result)
2223
ffStrbufAppend(result, &instance.state.platform.systemName);
2324

2425
//Append code name if it is missing
25-
if(os->codename.length > 0 && !ffStrbufContain(result, &os->codename))
26+
if(os->codename.length > 0 && !ffStrbufContainIgnCase(result, &os->codename))
2627
{
2728
ffStrbufAppendC(result, ' ');
2829
ffStrbufAppend(result, &os->codename);
2930
}
3031

3132
//Append version if it is missing
32-
if(os->versionID.length > 0 && !ffStrbufContain(result, &os->versionID))
33+
if(os->versionID.length > 0 && !ffStrbufContainIgnCase(result, &os->versionID))
3334
{
3435
ffStrbufAppendC(result, ' ');
3536
ffStrbufAppend(result, &os->versionID);
3637
}
37-
else if(os->versionID.length == 0 && os->version.length > 0 && !ffStrbufContain(result, &os->version))
38+
else if(os->versionID.length == 0 && os->version.length > 0 && !ffStrbufContainIgnCase(result, &os->version))
3839
{
3940
ffStrbufAppendC(result, ' ');
4041
ffStrbufAppend(result, &os->version);
4142
}
4243

4344
//Append variant if it is missing
44-
if(os->variant.length > 0 && ffStrbufFirstIndex(result, &os->variant) == result->length)
45+
if(os->variant.length > 0 && !ffStrbufContainIgnCase(result, &os->variant))
4546
{
4647
ffStrbufAppendS(result, " (");
4748
ffStrbufAppend(result, &os->variant);
4849
ffStrbufAppendC(result, ')');
4950
}
50-
else if(os->variant.length == 0 && os->variantID.length > 0 && ffStrbufFirstIndex(result, &os->variantID) == result->length)
51+
else if(os->variant.length == 0 && os->variantID.length > 0 && !ffStrbufContainIgnCase(result, &os->variantID))
5152
{
5253
ffStrbufAppendS(result, " (");
5354
ffStrbufAppend(result, &os->variantID);
5455
ffStrbufAppendC(result, ')');
5556
}
5657

5758
//Append architecture if it is missing
58-
if(ffStrbufFirstIndex(result, &instance.state.platform.systemArchitecture) == result->length)
59+
if(!ffStrbufContainIgnCase(result, &instance.state.platform.systemArchitecture))
5960
{
6061
ffStrbufAppendC(result, ' ');
6162
ffStrbufAppend(result, &instance.state.platform.systemArchitecture);

0 commit comments

Comments
 (0)