Terminal (Windows): fix file version detection

CarterLi · CarterLi · commit f34d51dddc3f · 2025-03-30T16:38:54.000+08:00
diff --git a/src/detection/terminalshell/terminalshell.c b/src/detection/terminalshell/terminalshell.c
@@ -22,9 +22,11 @@
 
 static bool getFileVersion(const FFstrbuf* exePath, const wchar_t* stringName, FFstrbuf* version)
 {
-    wchar_t exePathW[PATH_MAX];
+    wchar_t exePathW[PATH_MAX + 1];
     int len = MultiByteToWideChar(CP_UTF8, 0, exePath->chars, (int)exePath->length, exePathW, ARRAY_SIZE(exePathW));
     if (len <= 0) return false;
+    assert(len < (int) ARRAY_SIZE(exePathW));
+    exePathW[len] = L'\0';
     return ffGetFileVersion(exePathW, stringName, version);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -22,9 +22,11 @@`
`22`	`22`
`23`	`23`	`static bool getFileVersion(const FFstrbuf* exePath, const wchar_t* stringName, FFstrbuf* version)`
`24`	`24`	`{`
`25`		`- wchar_t exePathW[PATH_MAX];`
	`25`	`+ wchar_t exePathW[PATH_MAX + 1];`
`26`	`26`	`int len = MultiByteToWideChar(CP_UTF8, 0, exePath->chars, (int)exePath->length, exePathW, ARRAY_SIZE(exePathW));`
`27`	`27`	`if (len <= 0) return false;`
	`28`	`+ assert(len < (int) ARRAY_SIZE(exePathW));`
	`29`	`+ exePathW[len] = L'\0';`
`28`	`30`	`return ffGetFileVersion(exePathW, stringName, version);`
`29`	`31`	`}`
`30`	`32`