Release: v2.52.0 #1952
Release: v2.52.0 #1952
Conversation
…en specifying `null`
…er supported ... and provides guidance on transitioning to JSON config
Regression in v2.51.0 Fixes #1947
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
found by copilot
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This release bumps the version to v2.52.0 and introduces significant improvements to display detection, configuration handling, and Android platform support.
- Adds scale factor detection for X11 displays and introduces fraction trailing zeros configuration
- Removes dependency on libxfconf in favor of D-Bus for XFCE-related detection
- Enhances Android platform support with X11-related detection capabilities
Reviewed Changes
Copilot reviewed 55 out of 55 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/strbuf.c | Updates test cases to use new trailingZeros parameter in ffStrbufAppendDouble |
| src/util/FFstrbuf.h | Adds boolean trailingZeros parameter to ffStrbufAppendDouble function |
| src/util/FFstrbuf.c | Implements trailing zeros behavior in double formatting |
| src/options/display.h | Adds FFFractionTrailingZerosType enum for fraction formatting control |
| src/options/display.c | Implements parsing and validation for new fraction formatting options |
| src/modules/localip/localip.c | Migrates from printf formatting to ffStrbufAppendDouble for network speeds |
| src/modules/display/display.c | Updates display formatting to show scale factor instead of scaled resolution |
| src/modules/btrfs/btrfs.c | Changes allocation handling to support RAID profiles instead of simple duplication |
| src/logo/logo.c | Fixes width calculation for chafa logos |
| src/fastfetch.c | Adds module option parsing to command line processing |
| CMakeLists.txt | Updates version and Android platform dependencies |
Comments suppressed due to low confidence (2)
src/util/FFstrbuf.c:1
- The logic for handling trailing zeros is inverted. When
trailingZerosis true, the code removes trailing zeros, but it should preserve them. WhentrailingZerosis false, it should remove trailing zeros but only handles the ".0" case.
#include "FFstrbuf.h"
src/detection/btrfs/btrfs_linux.c:1
- The
copiesfield may be uninitialized when accessed here since the allocation detection happens later in the function. This could lead to using garbage values for multiplication.
#include "btrfs.h"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| options->percentWidth = 0; | ||
|
|
||
| options->freqNdigits = 2; | ||
| options->freqSpaceBeforeUnit = FF_SPACE_BEFORE_UNIT_DEFAULT; |
There was a problem hiding this comment.
[nitpick] The default value change from -1 to 2 should be documented in the code comment to explain the breaking change in behavior for fraction digit display.
Copilot uses AI. Check for mistakes.
No description provided.