* enable warning in GCC because PVS-Studio are also detect this. This is an error!

Author: IRainman

include/fast_float/ascii_number.h

@@ -71,7 +71,6 @@ read8_to_u64(UC const *chars) {
 #ifdef FASTFLOAT_SSE2
 
 fastfloat_really_inline uint64_t simd_read8_to_u64(__m128i const &data) {
-  FASTFLOAT_SIMD_DISABLE_WARNINGS
   // _mm_packus_epi16 is SSE2+, converts 8×u16 → 8×u8
   __m128i const packed = _mm_packus_epi16(data, data);
 #ifdef FASTFLOAT_64BIT
@@ -82,30 +81,23 @@ fastfloat_really_inline uint64_t simd_read8_to_u64(__m128i const &data) {
   _mm_storel_epi64(reinterpret_cast<__m128i *>(&value), packed);
   return value;
 #endif
-  FASTFLOAT_SIMD_RESTORE_WARNINGS
 }
 
 fastfloat_really_inline uint64_t simd_read8_to_u64(char16_t const *chars) {
-  FASTFLOAT_SIMD_DISABLE_WARNINGS
   return simd_read8_to_u64(
-      _mm_loadu_si128(reinterpret_cast<__m128i const *>(chars)));
-  FASTFLOAT_SIMD_RESTORE_WARNINGS
+      _mm_loadu_si128(reinterpret_cast<__m128i const *>(chars))); //TODO: V1032 https://pvs-studio.com/en/docs/warnings/v1032/ The pointer 'chars' is cast to a more strictly aligned pointer type.
 }
 
 #elif defined(FASTFLOAT_NEON)
 
 fastfloat_really_inline uint64_t simd_read8_to_u64(uint16x8_t const &data) {
-  FASTFLOAT_SIMD_DISABLE_WARNINGS
   uint8x8_t utf8_packed = vmovn_u16(data);
   return vget_lane_u64(vreinterpret_u64_u8(utf8_packed), 0);
-  FASTFLOAT_SIMD_RESTORE_WARNINGS
 }
 
 fastfloat_really_inline uint64_t simd_read8_to_u64(char16_t const *chars) {
-  FASTFLOAT_SIMD_DISABLE_WARNINGS
   return simd_read8_to_u64(
       vld1q_u16(reinterpret_cast<uint16_t const *>(chars)));
-  FASTFLOAT_SIMD_RESTORE_WARNINGS
 }
 
 #endif
@@ -162,10 +154,9 @@ simd_parse_if_eight_digits_unrolled(char16_t const *chars,
     return false;
   }
 #ifdef FASTFLOAT_SSE2
-  FASTFLOAT_SIMD_DISABLE_WARNINGS
   // Load 8 UTF-16 characters (16 bytes)
   __m128i const data =
-      _mm_loadu_si128(reinterpret_cast<__m128i const *>(chars));
+      _mm_loadu_si128(reinterpret_cast<__m128i const *>(chars)); //TODO: V1032 https://pvs-studio.com/en/docs/warnings/v1032/ The pointer 'chars' is cast to a more strictly aligned pointer type.
 
   // Branchless "are all digits?" trick from Lemire:
   // (x - '0') <= 9  <=> (x + 32720) <= 32729
@@ -179,9 +170,7 @@ simd_parse_if_eight_digits_unrolled(char16_t const *chars,
     i = i * 100000000 + parse_eight_digits_unrolled(simd_read8_to_u64(data));
     return true;
   }
-  FASTFLOAT_SIMD_RESTORE_WARNINGS
 #elif defined(FASTFLOAT_NEON)
-  FASTFLOAT_SIMD_DISABLE_WARNINGS
   uint16x8_t const data = vld1q_u16(reinterpret_cast<uint16_t const *>(chars));
 
   // (x - '0') <= 9
@@ -193,7 +182,6 @@ simd_parse_if_eight_digits_unrolled(char16_t const *chars,
     i = i * 100000000 + parse_eight_digits_unrolled(simd_read8_to_u64(data));
     return true;
   }
-  FASTFLOAT_SIMD_RESTORE_WARNINGS
 #else
   (void)chars;
   (void)i;

include/fast_float/float_common.h

@@ -205,19 +205,20 @@ FASTFLOAT_CONSTEXPR20 To bit_cast(const From &from) {
 #define FASTFLOAT_HAS_SIMD 1
 #endif
 
+// Don't silent this. This is an important warning!
 //#if defined(__GNUC__)
 // disable -Wcast-align=strict (GCC only)
 //#define FASTFLOAT_SIMD_DISABLE_WARNINGS                                        \
 //  _Pragma("GCC diagnostic push")                                               \
 //      _Pragma("GCC diagnostic ignored \"-Wcast-align\"")
 //#else
-#define FASTFLOAT_SIMD_DISABLE_WARNINGS
+//#define FASTFLOAT_SIMD_DISABLE_WARNINGS
 //#endif
 
 //#if defined(__GNUC__)
 //#define FASTFLOAT_SIMD_RESTORE_WARNINGS _Pragma("GCC diagnostic pop")
 //#else
-#define FASTFLOAT_SIMD_RESTORE_WARNINGS
+//#define FASTFLOAT_SIMD_RESTORE_WARNINGS
 //#endif
 
 #ifdef FASTFLOAT_VISUAL_STUDIO
@@ -336,8 +337,18 @@ template <typename T> struct span {
 };
 
 struct value128 {
-  uint64_t low;
-  uint64_t high;
+  union {
+      struct {
+      uint64_t low;
+      uint64_t high;
+    };
+#ifdef FASTFLOAT_SSE2
+    __m128i full; // trick for test only
+#endif
+#ifdef FASTFLOAT_NEON
+    uint16x8_t full; // trick for test only
+#endif
+  };
 
   constexpr value128(uint64_t _low, uint64_t _high) noexcept
       : low(_low), high(_high) {}