minor fixes for the yy PR

Author: lemire

benchmarks/CMakeLists.txt

@@ -67,7 +67,6 @@ endif()
 target_link_libraries(benchmark PUBLIC fmt)
 target_link_libraries(benchmark PUBLIC cxxopts)
 
-#target_link_libraries(benchmark PUBLIC grisu2)
 target_link_libraries(benchmark PUBLIC yy_double)
 target_link_libraries(benchmark PUBLIC double-conversion)
 target_link_libraries(benchmark PUBLIC ryu::ryu)

benchmarks/algorithms.h

@@ -32,8 +32,12 @@
 #include "ryu/ryu.h"
 #include "schubfach_32.h"
 #include "schubfach_64.h"
+#if (__SIZEOF_INT128__ == 16) && (defined(__GNUC__) || defined(__clang__) || defined(__INTEL_COMPILER))
 #include "yy_double.h"
-
+#define YY_DOUBLE_SUPPORTED 1
+#else
+#define YY_DOUBLE_SUPPORTED 0
+#endif
 namespace Benchmarks {
 
 enum Algorithm {
@@ -54,7 +58,7 @@ enum Algorithm {
   STD_TO_CHARS = 14,
   GRISU3 = 15,
   YY_DOUBLE = 16,
-  COUNT = 17,
+  COUNT // Keep last
 };
 
 template<typename T>
@@ -92,6 +96,7 @@ int errol3(T d, std::span<char>& buffer) {
   errol3_dtoa(d, buffer.data());  // returns the exponent
   return std::strlen(buffer.data());
 #else
+  std::cerr << "errol3 not supported" << std::endl;
   std::abort();
 #endif
 }
@@ -150,6 +155,7 @@ int netlib(T d, std::span<char>& buffer) {
     std::abort();
   }
 #else
+  std::cerr << "netlib not supported" << std::endl;
   std::abort();
 #endif
 }
@@ -224,11 +230,15 @@ int double_conversion(T d, std::span<char>& buffer) {
   return strlen(builder.Finalize());
 }
 
-// No yy_float implementation
 template<arithmetic_float T>
 int yy_double(T d, std::span<char>& buffer) {
+#if YY_DOUBLE_SUPPORTED
   const char* end_ptr = yy_double_to_string(d, buffer.data());
   return end_ptr - buffer.data();
+#else
+  std::cerr << "yy_double not supported" << std::endl;
+  std::abort();
+#endif
 }
 
 template<arithmetic_float T>
@@ -252,6 +262,7 @@ int std_to_chars(T d, std::span<char>& buffer) {
   }
   return p - buffer.data();
 #else
+  std::cerr << "std::to_chars not supported" << std::endl;
   std::abort();
 #endif
 }

benchmarks/benchmark.cpp

@@ -75,7 +75,6 @@ void process(const std::vector<T> &lines,
       std::cout << "# skipping " << algo.name << std::endl;
       continue;
     }
-
     pretty_print(lines, algo.name, [&algo](const std::vector<T> &lines) -> int {
       int volume = 0;
       char buf[100];
@@ -198,7 +197,7 @@ int main(int argc, char **argv) {
       args[Benchmarks::ABSEIL]            = { "abseil"            , Benchmarks::abseil<T>            , ABSEIL_SUPPORTED };
       args[Benchmarks::STD_TO_CHARS]      = { "std::to_chars"     , Benchmarks::std_to_chars<T>      , TO_CHARS_SUPPORTED };
       args[Benchmarks::GRISU3]            = { "grisu3"            , Benchmarks::grisu3<T>            , true };
-      args[Benchmarks::YY_DOUBLE]         = { "yy_double"         , Benchmarks::yy_double<T>         , true };
+      args[Benchmarks::YY_DOUBLE]         = { "yy_double"         , Benchmarks::yy_double<T>         , YY_DOUBLE_SUPPORTED };
       return args;
     };