fix some warnings shown by my linter

- Mostly missing and unused headers

Author: jaja360

.gitignore

@@ -1 +1,4 @@
 build
+build_debug
+build_script
+.cache

benchmarks/CMakeLists.txt

@@ -28,4 +28,4 @@ int main(void) {
 
 if (from_chars_double)
     target_compile_definitions(benchmark PUBLIC FROM_CHARS_DOUBLE_SUPPORTED=1)
-endif()
+endif()

benchmarks/benchmark.cpp

@@ -8,43 +8,35 @@
  */
 
 #ifndef __CYGWIN__
-#include "absl/strings/numbers.h"
 #include "absl/strings/str_cat.h"
 #endif
 
 #include "dragonbox/dragonbox_to_chars.h"
 #include "ryu/ryu.h"
-
 #include "double-conversion/double-conversion.h"
-#include "double-conversion/ieee.h"
 
 #define IEEE_8087
 #include "benchutil.h"
 #include "cxxopts.hpp"
+
 #if NETLIB_SUPPORTED
 #include "gdtoa.h"
 #endif
+
 #include "grisu2.h"
 #include "random_generators.h"
-#include <algorithm>
+
 #include <charconv>
-#include <chrono>
 #include <climits>
 #include <cmath>
-#include <cstdint>
 #include <cstdio>
 #include <cstdlib>
 #include <cstring>
-#include <ctype.h>
 #include <float.h>
 #include <fmt/format.h>
 #include <fstream>
-#include <iomanip>
 #include <iostream>
 #include <limits.h>
-#include <locale.h>
-#include <random>
-#include <sstream>
 #include <stdio.h>
 #include <string>
 #include <vector>
@@ -177,10 +169,10 @@ void fileload(const char *filename) {
     std::cerr << "can't open " << filename << std::endl;
     return;
   }
-  std::string line;
+
   std::vector<double> lines;
   lines.reserve(10000); // let us reserve plenty of memory.
-  while (getline(inputfile, line)) {
+  for (std::string line; getline(inputfile, line);) {
     try {
       lines.push_back(std::stod(line));
     } catch (...) {

benchmarks/benchutil.h

@@ -1,8 +1,8 @@
 #ifndef BENCHUTIL_H
 #define BENCHUTIL_H
+
 #include <cfloat>
 #include <cstdio>
-#include <chrono>
 
 #if defined(__linux__) || (__APPLE__ && __aarch64__)
 #define USING_COUNTERS
@@ -131,5 +131,6 @@ void pretty_print(std::vector<double> &lines, std::string name,
   printf("%8.2f Mfloat/s  ", number_of_floats * 1000 / result.first);
   printf(" %8.2f ns/f \n", double(result.first) / number_of_floats);
 }
+
 #endif
-#endif //// BENCHUTIL_H
+#endif //// BENCHUTIL_H

benchmarks/counters/event_counter.h

@@ -5,7 +5,6 @@
 #ifndef _MSC_VER
 #include <dirent.h>
 #endif
-#include <cinttypes>
 
 #include <cstring>
 

benchmarks/counters/linux-perf-events.h

@@ -8,9 +8,8 @@
 
 #include <cerrno>  // for errno
 #include <cstring> // for memset
-#include <stdexcept>
-
-#include <iostream>
+#include <cstdint> // for uint32_t, uint64_t
+#include <string>
 #include <vector>
 
 template <int TYPE = PERF_TYPE_HARDWARE> class LinuxEvents {
@@ -101,4 +100,4 @@ template <int TYPE = PERF_TYPE_HARDWARE> class LinuxEvents {
 private:
   void report_error(const std::string &) { working = false; }
 };
-#endif
+#endif

benchmarks/random_generators.h

@@ -1,12 +1,14 @@
 #ifndef RANDOM_GENERATORS_H
 #define RANDOM_GENERATORS_H
 
+#include <array>
+#include <memory>
 #include <random>
 #include <iostream>
 
 struct float_number_generator {
-  virtual double new_float() { return 0; }
-  virtual std::string describe() { return "abstract class"; }
+  virtual double new_float() = 0;
+  virtual std::string describe() = 0;
 };
 
 struct uniform_generator : float_number_generator {
@@ -80,16 +82,20 @@ struct simple_int64 : float_number_generator {
   double new_float() override { return gen(); }
 };
 
-std::vector<std::string> model_names = {"uniform",          "one_over_rand32",
-                                        "simple_uniform32", "simple_int32",
-                                        "int_e_int",        "simple_int64"};
-std::unique_ptr<float_number_generator>
+constexpr std::array<const char*, 6> model_names = {
+  "uniform",          "one_over_rand32",
+  "simple_uniform32", "simple_int32",
+  "int_e_int",        "simple_int64"
+};
+
+inline std::unique_ptr<float_number_generator>
 get_generator_by_name(std::string name) {
   std::cout << "available models (-m): ";
   for (std::string name : model_names) {
     std::cout << name << " ";
   }
   std::cout << std::endl;
+
   // This is naive, but also not very important.
   if (name == "uniform") {
     return std::unique_ptr<float_number_generator>(new uniform_generator());
@@ -111,4 +117,4 @@ get_generator_by_name(std::string name) {
   return std::unique_ptr<float_number_generator>(new uniform_generator());
 }
 
-#endif
+#endif

benchmarks/string_format.h

@@ -1,8 +1,9 @@
 #ifndef STRING_FORMAT_H
 #define STRING_FORMAT_H
 
-#include <iostream>
+#include <limits>
 #include <sstream>
+
 /**
  * This will generate a string with exactly the number of digits
  * that are required to always be able to recover the original
@@ -45,4 +46,4 @@ template <typename T> std::string accurate_to_string_concise(T d) {
   return answer;
 }
 
-#endif
+#endif

dependencies/CMakeLists.txt

@@ -34,7 +34,6 @@ FetchContent_GetProperties(doubleconversion)
 FetchContent_MakeAvailable(doubleconversion)
 
 #CPMAddPackage("gh:ulfjack/[email protected]")
-include(FetchContent)
 FetchContent_Declare(
         ryu
         GIT_REPOSITORY https://github.com/ulfjack/ryu