Merge pull request #8 from fastfloat/adding_errol

adding errol3 algorithm

Author: jaja360

CMakeLists.txt

@@ -6,7 +6,9 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 set(CMAKE_C_STANDARD 99)
 set(CMAKE_C_STANDARD_REQUIRED ON)
 
-cmake_policy(SET CMP0169 OLD) # Prevent warning when using FetchContent_Populate
+if(CMAKE_VERSION VERSION_GREATER_EQUAL "3.30")
+    cmake_policy(SET CMP0169 OLD) # Prevent warning when using FetchContent_Populate
+endif()
 
 include(CheckCXXCompilerFlag)
 unset(FASTPFOR_COMPILER_SUPPORTS_MARCH_NATIVE CACHE)

benchmarks/CMakeLists.txt

@@ -39,5 +39,7 @@ if(teju_has_float128)
 endif()
 target_link_libraries(benchmark PUBLIC dragonbox::dragonbox_to_chars)
 target_link_libraries(benchmark PUBLIC dragon_schubfach_lib)
-
+if(TARGET errol)
+    target_link_libraries(benchmark PUBLIC errol)
+endif()
 target_include_directories(benchmark PUBLIC ${grisu-exact_SOURCE_DIR})

benchmarks/benchmark.cpp

@@ -20,6 +20,12 @@
 #include "grisu_exact.h"
 #include "dragon4.h"
 #include "schubfach_64.h"
+#if __has_include("errol.h")
+#include "errol.h"
+#define ERROL_SUPPORTED 1
+#else
+#define ERROL_SUPPORTED 0
+#endif
 
 #define IEEE_8087
 #include "benchutil.h"
@@ -66,7 +72,20 @@ void process(std::vector<double> &lines) {
     }
     return volume;
   });
-
+  
+#if ERROL_SUPPORTED
+  pretty_print(lines, "errol3", [](const std::vector<double> &lines) {
+    double volume = 0;
+    char buffer[100];
+    for (const auto d : lines) {
+      errol3_dtoa(d, buffer); // returns the exponent?
+      volume += std::strlen(buffer);
+    }
+    return volume;
+  });
+#else
+  std::cout << "# errol not supported" << std::endl;
+#endif // ERROL_SUPPORTED
   pretty_print(lines, "std::to_string", [](const std::vector<double> &lines) {
     double volume = 0;
     for (const auto d : lines) {
@@ -136,24 +155,6 @@ void process(std::vector<double> &lines) {
     return volume;
   });
 
-#if FROM_CHARS_DOUBLE_SUPPORTED
-  pretty_print(lines, "std::to_chars", [](const std::vector<double> &lines) {
-    double volume = 0;
-    char buffer[100];
-    for (const auto d : lines) {
-      const auto [p, ec] = std::to_chars(buffer, buffer + sizeof(buffer), d);
-      if(ec != std::errc()) {
-        std::cerr << "problem with " << d << std::endl;
-        std::abort();
-      }
-      volume += p - buffer;
-    }
-    return volume;
-  });
-#else
-  std::cout << "# std::to_chars not supported" << std::endl;
-#endif
-
   pretty_print(lines, "schubfach", [](const std::vector<double> &lines) {
     double volume = 0;
     char buffer[100];
@@ -224,6 +225,26 @@ void process(std::vector<double> &lines) {
     }
     return volume;
   });
+
+
+#if FROM_CHARS_DOUBLE_SUPPORTED
+  pretty_print(lines, "std::to_chars", [](const std::vector<double> &lines) {
+    double volume = 0;
+    char buffer[100];
+    for (const auto d : lines) {
+      const auto [p, ec] = std::to_chars(buffer, buffer + sizeof(buffer), d);
+      if(ec != std::errc()) {
+        std::cerr << "problem with " << d << std::endl;
+        std::abort();
+      }
+      volume += p - buffer;
+    }
+    return volume;
+  });
+#else
+  std::cout << "# std::to_chars not supported" << std::endl;
+#endif
+
 }
 
 void fileload(const char *filename) {

dependencies/CMakeLists.txt

@@ -103,3 +103,16 @@ CPMAddPackage(
   VERSION 3.2.0
   OPTIONS "CXXOPTS_BUILD_EXAMPLES NO" "CXXOPTS_BUILD_TESTS NO" "CXXOPTS_ENABLE_INSTALL YES"
 )
+
+if(NOT WIN32)
+CPMAddPackage(
+  NAME errol
+  GITHUB_REPOSITORY marcandrysco/Errol
+  GIT_TAG 5364de4
+  DOWNLOAD_ONLY ON
+)
+
+
+add_library(errol STATIC "${errol_SOURCE_DIR}/lib/errol.c")
+target_include_directories(errol SYSTEM PUBLIC "${errol_SOURCE_DIR}/lib")
+endif()