remove bad pattern from tests suites (#248)

Author: L2jLiga

test/allof.test.js

@@ -55,26 +55,16 @@ test('object with allOf and multiple schema on the allOf', (t) => {
     t.is(e.message, '"id" is required!')
   }
 
-  try {
-    const value = stringify({
-      id: 1,
-      name: 'string'
-    })
-    t.is(value, '{"name":"string","id":1}')
-  } catch (e) {
-    t.fail()
-  }
+  t.is(stringify({
+    id: 1,
+    name: 'string'
+  }), '{"name":"string","id":1}')
 
-  try {
-    const value = stringify({
-      id: 1,
-      name: 'string',
-      tag: 'otherString'
-    })
-    t.is(value, '{"name":"string","tag":"otherString","id":1}')
-  } catch (e) {
-    t.fail()
-  }
+  t.is(stringify({
+    id: 1,
+    name: 'string',
+    tag: 'otherString'
+  }), '{"name":"string","tag":"otherString","id":1}')
 })
 
 test('object with allOf and one schema on the allOf', (t) => {
@@ -99,14 +89,10 @@ test('object with allOf and one schema on the allOf', (t) => {
   }
   const stringify = build(schema)
 
-  try {
-    const value = stringify({
-      id: 1
-    })
-    t.is(value, '{"id":1}')
-  } catch (e) {
-    t.fail()
-  }
+  const value = stringify({
+    id: 1
+  })
+  t.is(value, '{"id":1}')
 })
 
 test('object with allOf and no schema on the allOf', (t) => {
@@ -167,22 +153,14 @@ test('object with nested allOfs', (t) => {
     ]
   }
 
-  try {
-    const stringify = build(schema)
-    try {
-      const value = stringify({
-        id1: 1,
-        id2: 2,
-        id3: 3,
-        id4: 4 // extra prop shouldn't be in result
-      })
-      t.is(value, '{"id1":1,"id2":2,"id3":3}')
-    } catch (e) {
-      t.fail()
-    }
-  } catch (e) {
-    t.fail()
-  }
+  const stringify = build(schema)
+  const value = stringify({
+    id1: 1,
+    id2: 2,
+    id3: 3,
+    id4: 4 // extra prop shouldn't be in result
+  })
+  t.is(value, '{"id1":1,"id2":2,"id3":3}')
 })
 
 test('object with $ref in allOf', (t) => {
@@ -208,20 +186,12 @@ test('object with $ref in allOf', (t) => {
     ]
   }
 
-  try {
-    const stringify = build(schema)
-    try {
-      const value = stringify({
-        id1: 1,
-        id2: 2 // extra prop shouldn't be in result
-      })
-      t.is(value, '{"id1":1}')
-    } catch (e) {
-      t.fail()
-    }
-  } catch (e) {
-    t.fail()
-  }
+  const stringify = build(schema)
+  const value = stringify({
+    id1: 1,
+    id2: 2 // extra prop shouldn't be in result
+  })
+  t.is(value, '{"id1":1}')
 })
 
 test('object with $ref and other object in allOf', (t) => {
@@ -255,21 +225,13 @@ test('object with $ref and other object in allOf', (t) => {
     ]
   }
 
-  try {
-    const stringify = build(schema)
-    try {
-      const value = stringify({
-        id1: 1,
-        id2: 2,
-        id3: 3 // extra prop shouldn't be in result
-      })
-      t.is(value, '{"id1":1,"id2":2}')
-    } catch (e) {
-      t.fail()
-    }
-  } catch (e) {
-    t.fail()
-  }
+  const stringify = build(schema)
+  const value = stringify({
+    id1: 1,
+    id2: 2,
+    id3: 3 // extra prop shouldn't be in result
+  })
+  t.is(value, '{"id1":1,"id2":2}')
 })
 
 test('object with multiple $refs in allOf', (t) => {
@@ -306,21 +268,13 @@ test('object with multiple $refs in allOf', (t) => {
     ]
   }
 
-  try {
-    const stringify = build(schema)
-    try {
-      const value = stringify({
-        id1: 1,
-        id2: 2,
-        id3: 3 // extra prop shouldn't be in result
-      })
-      t.is(value, '{"id1":1,"id2":2}')
-    } catch (e) {
-      t.fail()
-    }
-  } catch (e) {
-    t.fail()
-  }
+  const stringify = build(schema)
+  const value = stringify({
+    id1: 1,
+    id2: 2,
+    id3: 3 // extra prop shouldn't be in result
+  })
+  t.is(value, '{"id1":1,"id2":2}')
 })
 
 test('object with external $refs in allOf', (t) => {
@@ -365,19 +319,11 @@ test('object with external $refs in allOf', (t) => {
     ]
   }
 
-  try {
-    const stringify = build(schema, { schema: externalSchema })
-    try {
-      const value = stringify({
-        id1: 1,
-        id2: 2,
-        id3: 3 // extra prop shouldn't be in result
-      })
-      t.is(value, '{"id1":1,"id2":2}')
-    } catch (e) {
-      t.fail()
-    }
-  } catch (e) {
-    t.fail()
-  }
+  const stringify = build(schema, { schema: externalSchema })
+  const value = stringify({
+    id1: 1,
+    id2: 2,
+    id3: 3 // extra prop shouldn't be in result
+  })
+  t.is(value, '{"id1":1,"id2":2}')
 })

test/any.test.js

@@ -10,53 +10,27 @@ test('object with nested random property', (t) => {
     title: 'empty schema to allow any object',
     type: 'object',
     properties: {
-      id: {
-        type: 'number'
-      },
+      id: { type: 'number' },
       name: {}
     }
   }
   const stringify = build(schema)
 
-  try {
-    const value = stringify({
-      id: 1,
-      name: 'string'
-    })
-    t.is(value, '{"id":1,"name":"string"}')
-  } catch (e) {
-    t.fail()
-  }
-  try {
-    const value = stringify({
-      id: 1,
-      name: {
-        first: 'name',
-        last: 'last'
-      }
-    })
-    t.is(value, '{"id":1,"name":{"first":"name","last":"last"}}')
-  } catch (e) {
-    t.fail()
-  }
-  try {
-    const value = stringify({
-      id: 1,
-      name: null
-    })
-    t.is(value, '{"id":1,"name":null}')
-  } catch (e) {
-    t.fail()
-  }
-  try {
-    const value = stringify({
-      id: 1,
-      name: ['first', 'last']
-    })
-    t.is(value, '{"id":1,"name":["first","last"]}')
-  } catch (e) {
-    t.fail()
-  }
+  t.is(stringify({
+    id: 1, name: 'string'
+  }), '{"id":1,"name":"string"}')
+
+  t.is(stringify({
+    id: 1, name: { first: 'name', last: 'last' }
+  }), '{"id":1,"name":{"first":"name","last":"last"}}')
+
+  t.is(stringify({
+    id: 1, name: null
+  }), '{"id":1,"name":null}')
+
+  t.is(stringify({
+    id: 1, name: ['first', 'last']
+  }), '{"id":1,"name":["first","last"]}')
 })
 
 test('array with random items', (t) => {
@@ -65,15 +39,10 @@ test('array with random items', (t) => {
   const schema = {
     title: 'empty schema to allow any object',
     type: 'array',
-    items: {
-    }
+    items: {}
   }
   const stringify = build(schema)
 
-  try {
-    const value = stringify([1, 'string', null])
-    t.is(value, '[1,"string",null]')
-  } catch (e) {
-    t.fail()
-  }
+  const value = stringify([1, 'string', null])
+  t.is(value, '[1,"string",null]')
 })