test: remove tap (#418)

* feat: base assertion migration

* chore: other assertions and imports

* chore: fix promises

* fix: test await and assertions

* fix: disable request logging permissions

* feat: configure c8

* fix: multipart assertions

* fix: assertions

* fix: assertions and plans

* fix: close callback

* fix: http2 https assertions

* fix: parsedLength assertion

* fix: onError assertions

* fix: header assertions

* fix: unix related tests

* fix: strictEqual

---------

Signed-off-by: Matteo Pietro Dazzi <[email protected]>

Author: ilteoood

package.json

@@ -9,7 +9,7 @@
     "lint": "eslint",
     "lint:fix": "eslint --fix",
     "test": "npm run test:unit && npm run test:typescript",
-    "test:unit": "tap",
+    "test:unit": "c8 node --test",
     "test:typescript": "tsd"
   },
   "repository": {
@@ -64,6 +64,7 @@
     "@sinonjs/fake-timers": "^14.0.0",
     "@types/node": "^22.0.0",
     "@types/tap": "^18.0.0",
+    "c8": "^10.1.3",
     "eslint": "^9.17.0",
     "fastify": "^5.0.0",
     "form-data": "^4.0.0",
@@ -73,7 +74,6 @@
     "proxy": "^2.1.1",
     "proxyquire": "^2.1.3",
     "split2": "^4.2.0",
-    "tap": "^18.7.2",
     "tsd": "^0.32.0"
   },
   "dependencies": {

test/async-route-handler.test.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const t = require('tap')
+const t = require('node:test')
 const Fastify = require('fastify')
 const From = require('..')
 const http = require('node:http')
@@ -10,12 +10,12 @@ const instance = Fastify()
 
 t.test('async route handler', async (t) => {
   t.plan(8)
-  t.teardown(instance.close.bind(instance))
+  t.after(() => instance.close())
 
   const target = http.createServer((req, res) => {
-    t.pass('request proxied')
-    t.equal(req.method, 'GET')
-    t.equal(req.url, '/')
+    t.assert.ok('request proxied')
+    t.assert.strictEqual(req.method, 'GET')
+    t.assert.strictEqual(req.url, '/')
     res.statusCode = 205
     res.setHeader('Content-Type', 'text/plain')
     res.setHeader('x-my-header', 'hello!')
@@ -24,11 +24,11 @@ t.test('async route handler', async (t) => {
 
   instance.get('/', async (_request, reply) => {
     const p = reply.from()
-    t.equal(p, reply)
+    t.assert.strictEqual(p, reply)
     return p
   })
 
-  t.teardown(target.close.bind(target))
+  t.after(() => target.close())
 
   await new Promise(resolve => target.listen({ port: 0 }, resolve))
 
@@ -40,8 +40,8 @@ t.test('async route handler', async (t) => {
 
   const result = await request(`http://localhost:${instance.server.address().port}`)
 
-  t.equal(result.headers['content-type'], 'text/plain')
-  t.equal(result.headers['x-my-header'], 'hello!')
-  t.equal(result.statusCode, 205)
-  t.equal(await result.body.text(), 'hello world')
+  t.assert.strictEqual(result.headers['content-type'], 'text/plain')
+  t.assert.strictEqual(result.headers['x-my-header'], 'hello!')
+  t.assert.strictEqual(result.statusCode, 205)
+  t.assert.strictEqual(await result.body.text(), 'hello world')
 })

test/base-get.test.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const t = require('tap')
+const t = require('node:test')
 const Fastify = require('fastify')
 const { request } = require('undici')
 const From = require('..')
@@ -10,12 +10,12 @@ const instance = Fastify()
 
 t.test('base get', async (t) => {
   t.plan(7)
-  t.teardown(instance.close.bind(instance))
+  t.after(() => instance.close())
 
   const target = http.createServer((req, res) => {
-    t.pass('request proxied')
-    t.equal(req.method, 'GET')
-    t.equal(req.url, '/')
+    t.assert.ok('request proxied')
+    t.assert.strictEqual(req.method, 'GET')
+    t.assert.strictEqual(req.url, '/')
     res.statusCode = 205
     res.setHeader('Content-Type', 'text/plain')
     res.setHeader('x-my-header', 'hello!')
@@ -26,7 +26,7 @@ t.test('base get', async (t) => {
     reply.from()
   })
 
-  t.teardown(target.close.bind(target))
+  t.after(() => target.close())
 
   await new Promise((resolve) => target.listen({ port: 0 }, resolve))
 
@@ -38,8 +38,8 @@ t.test('base get', async (t) => {
 
   const result = await request(`http://localhost:${instance.server.address().port}`)
 
-  t.equal(result.headers['content-type'], 'text/plain')
-  t.equal(result.headers['x-my-header'], 'hello!')
-  t.equal(result.statusCode, 205)
-  t.equal(await result.body.text(), 'hello world')
+  t.assert.strictEqual(result.headers['content-type'], 'text/plain')
+  t.assert.strictEqual(result.headers['x-my-header'], 'hello!')
+  t.assert.strictEqual(result.statusCode, 205)
+  t.assert.strictEqual(await result.body.text(), 'hello world')
 })

test/base-path.test.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const t = require('tap')
+const t = require('node:test')
 const Fastify = require('fastify')
 const { request, Agent } = require('undici')
 const From = require('..')
@@ -12,12 +12,12 @@ t.test('base path', async (t) => {
   nock('http://httpbin.org')
     .get('/ip')
     .reply(200, function () {
-      t.equal(this.req.headers.host, 'httpbin.org')
+      t.assert.strictEqual(this.req.headers.host, 'httpbin.org')
       return { origin: '127.0.0.1' }
     })
 
   t.plan(4)
-  t.teardown(instance.close.bind(instance))
+  t.after(() => instance.close())
 
   instance.get('/', (_request, reply) => {
     reply.from('http://httpbin.org/ip')
@@ -35,7 +35,7 @@ t.test('base path', async (t) => {
     })
   })
 
-  t.equal(result.statusCode, 200)
-  t.equal(result.headers['content-type'], 'application/json')
-  t.equal(typeof (await result.body.json()).origin, 'string')
+  t.assert.strictEqual(result.statusCode, 200)
+  t.assert.strictEqual(result.headers['content-type'], 'application/json')
+  t.assert.strictEqual(typeof (await result.body.json()).origin, 'string')
 })

test/base-querystring.test.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const t = require('tap')
+const t = require('node:test')
 const Fastify = require('fastify')
 const { request } = require('undici')
 const From = require('..')
@@ -10,12 +10,12 @@ const instance = Fastify()
 
 t.test('base querystring', async (t) => {
   t.plan(7)
-  t.teardown(instance.close.bind(instance))
+  t.after(() => instance.close())
 
   const target = http.createServer((req, res) => {
-    t.pass('request proxied')
-    t.equal(req.method, 'GET')
-    t.equal(req.url, '/hello?a=b')
+    t.assert.ok('request proxied')
+    t.assert.strictEqual(req.method, 'GET')
+    t.assert.strictEqual(req.url, '/hello?a=b')
     res.statusCode = 205
     res.setHeader('Content-Type', 'text/plain')
     res.setHeader('x-my-header', 'hello!')
@@ -26,7 +26,7 @@ t.test('base querystring', async (t) => {
     reply.from()
   })
 
-  t.teardown(target.close.bind(target))
+  t.after(() => target.close())
 
   await new Promise(resolve => target.listen({ port: 0 }, resolve))
 
@@ -38,8 +38,8 @@ t.test('base querystring', async (t) => {
 
   const result = await request(`http://localhost:${instance.server.address().port}/hello?a=b`)
 
-  t.equal(result.headers['content-type'], 'text/plain')
-  t.equal(result.headers['x-my-header'], 'hello!')
-  t.equal(result.statusCode, 205)
-  t.equal(await result.body.text(), 'hello world')
+  t.assert.strictEqual(result.headers['content-type'], 'text/plain')
+  t.assert.strictEqual(result.headers['x-my-header'], 'hello!')
+  t.assert.strictEqual(result.statusCode, 205)
+  t.assert.strictEqual(await result.body.text(), 'hello world')
 })

test/build-url.test.js

@@ -1,54 +1,54 @@
 'use strict'
 
-const { test } = require('tap')
+const { test } = require('node:test')
 const { buildURL } = require('../lib/utils')
 
 test('should produce valid URL', (t) => {
   t.plan(1)
   const url = buildURL('/hi', 'http://localhost')
-  t.equal(url.href, 'http://localhost/hi')
+  t.assert.strictEqual(url.href, 'http://localhost/hi')
 })
 
 test('should produce valid URL', (t) => {
   t.plan(1)
   const url = buildURL('http://localhost/hi', 'http://localhost')
-  t.equal(url.href, 'http://localhost/hi')
+  t.assert.strictEqual(url.href, 'http://localhost/hi')
 })
 
 test('should return same source when base is not specified', (t) => {
   t.plan(1)
   const url = buildURL('http://localhost/hi')
-  t.equal(url.href, 'http://localhost/hi')
+  t.assert.strictEqual(url.href, 'http://localhost/hi')
 })
 
 test('should handle lack of trailing slash in base', (t) => {
   t.plan(3)
   let url = buildURL('hi', 'http://localhost/hi')
-  t.equal(url.href, 'http://localhost/hi')
+  t.assert.strictEqual(url.href, 'http://localhost/hi')
 
   url = buildURL('hi/', 'http://localhost/hi')
-  t.equal(url.href, 'http://localhost/hi/')
+  t.assert.strictEqual(url.href, 'http://localhost/hi/')
 
   url = buildURL('hi/more', 'http://localhost/hi')
-  t.equal(url.href, 'http://localhost/hi/more')
+  t.assert.strictEqual(url.href, 'http://localhost/hi/more')
 })
 
 test('should handle default port in base', (t) => {
   t.plan(2)
   let url = buildURL('/hi', 'http://localhost:80/hi')
-  t.equal(url.href, 'http://localhost/hi')
+  t.assert.strictEqual(url.href, 'http://localhost/hi')
 
   url = buildURL('/hi', 'https://localhost:443/hi')
-  t.equal(url.href, 'https://localhost/hi')
+  t.assert.strictEqual(url.href, 'https://localhost/hi')
 })
 
 test('should append instead of override base', (t) => {
   t.plan(2)
   let url = buildURL('//10.0.0.10/hi', 'http://localhost')
-  t.equal(url.href, 'http://localhost//10.0.0.10/hi')
+  t.assert.strictEqual(url.href, 'http://localhost//10.0.0.10/hi')
 
   url = buildURL('//httpbin.org/hi', 'http://localhost')
-  t.equal(url.href, 'http://localhost//httpbin.org/hi')
+  t.assert.strictEqual(url.href, 'http://localhost//httpbin.org/hi')
 })
 
 const errorInputs = [
@@ -64,13 +64,15 @@ const errorInputs = [
   { source: 'exposed-extra', base: 'http://localhost/exposed' }
 ]
 
-test('should throw when trying to override base', (t) => {
+test('should throw when trying to override base', async (t) => {
   t.plan(errorInputs.length)
 
-  errorInputs.forEach(({ source, base }) => {
-    t.test(source, (t) => {
+  const promises = errorInputs.map(({ source, base }) => {
+    return t.test(source, (t) => {
       t.plan(1)
-      t.throws(() => buildURL(source, base))
+      t.assert.throws(() => buildURL(source, base))
     })
   })
+
+  await Promise.all(promises)
 })

test/core-with-path-in-base.test.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const t = require('tap')
+const t = require('node:test')
 const Fastify = require('fastify')
 const { request, Agent } = require('undici')
 const From = require('..')
@@ -10,13 +10,13 @@ const instance = Fastify()
 
 t.test('core with path in base', async (t) => {
   t.plan(8)
-  t.teardown(instance.close.bind(instance))
+  t.after(() => instance.close())
 
   const target = http.createServer((req, res) => {
-    t.pass('request proxied')
-    t.equal(req.method, 'GET')
-    t.equal(req.url, '/hello')
-    t.equal(req.headers.connection, 'close')
+    t.assert.ok('request proxied')
+    t.assert.strictEqual(req.method, 'GET')
+    t.assert.strictEqual(req.url, '/hello')
+    t.assert.strictEqual(req.headers.connection, 'close')
     res.statusCode = 205
     res.setHeader('Content-Type', 'text/plain')
     res.setHeader('x-my-header', 'hello!')
@@ -27,7 +27,7 @@ t.test('core with path in base', async (t) => {
     reply.from('/hello')
   })
 
-  t.teardown(target.close.bind(target))
+  t.after(() => target.close())
 
   await new Promise(resolve => target.listen({ port: 0 }, resolve))
 
@@ -43,8 +43,8 @@ t.test('core with path in base', async (t) => {
       pipelining: 0
     })
   })
-  t.equal(result.headers['content-type'], 'text/plain')
-  t.equal(result.headers['x-my-header'], 'hello!')
-  t.equal(result.statusCode, 205)
-  t.equal(await result.body.text(), 'hello world')
+  t.assert.strictEqual(result.headers['content-type'], 'text/plain')
+  t.assert.strictEqual(result.headers['x-my-header'], 'hello!')
+  t.assert.strictEqual(result.statusCode, 205)
+  t.assert.strictEqual(await result.body.text(), 'hello world')
 })