Skip to content

Commit 430d059

Browse files
committed
Hopefully better clarification why ESI includes need to be http:// URLs
1 parent e512a3b commit 430d059

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

Block/GeoIp/GetAction.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,9 @@ protected function _toHtml() // @codingStandardsIgnoreLine - required by parent
108108
if (empty($header)) {
109109
$this->response->setHeader("x-esi", "1");
110110
}
111-
// HTTPS ESIs are not supported so we need to turn them into HTTP
111+
// Due to Varnish parser limitations HTTPS ESIs are not supported so we need to turn them into HTTP URLs
112+
// This does not mean that request will go over HTTP. ESI subrequest will go out to the backend that is
113+
// currently specified so if it's HTTPS it will go over HTTPS
112114
return sprintf(
113115
'<esi:include src=\'%s\' />',
114116
preg_replace(

0 commit comments

Comments
 (0)