Skip to content

Commit 1820b0b

Browse files
authored
CI: Always run the build job, never cancel it (#868)
1 parent a3944d7 commit 1820b0b

File tree

1 file changed

+32
-5
lines changed

1 file changed

+32
-5
lines changed

.github/workflows/main.yml

Lines changed: 32 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
name: CI
2-
concurrency:
3-
group: ${{ github.head_ref }}-${{ github.workflow}}
4-
cancel-in-progress: true
52
on:
63
pull_request:
74
push:
@@ -17,6 +14,9 @@ env:
1714
jobs:
1815

1916
check-changelog:
17+
concurrency:
18+
group: ${{ github.head_ref }}-${{ github.workflow}}-check-changelog
19+
cancel-in-progress: true
2020
if: github.ref != 'refs/heads/main'
2121
runs-on: ubuntu-latest
2222
steps:
@@ -28,6 +28,9 @@ jobs:
2828
- run: npm run format-changelog
2929

3030
check-docusaurus:
31+
concurrency:
32+
group: ${{ github.head_ref }}-${{ github.workflow}}-check-docusaurus
33+
cancel-in-progress: true
3134
if: github.ref != 'refs/heads/main'
3235
runs-on: ubuntu-latest
3336
steps:
@@ -162,6 +165,9 @@ jobs:
162165
if: steps.cache-crate.outputs.cache-hit != 'true'
163166

164167
run_wpt:
168+
concurrency:
169+
group: ${{ github.head_ref }}-${{ github.workflow}}-run_wpt-${{matrix.profile}}
170+
cancel-in-progress: true
165171
if: github.ref != 'refs/heads/main'
166172
name: Run Web Platform Tests
167173
strategy:
@@ -223,6 +229,9 @@ jobs:
223229
# Consumes all published artifacts from all the previous build steps, and runs
224230
# the integration tests for the linux build.
225231
sdktest:
232+
concurrency:
233+
group: ${{ github.head_ref }}-${{ github.workflow}}-sdktest-${{matrix.profile}}
234+
cancel-in-progress: true
226235
if: github.ref != 'refs/heads/main'
227236
runs-on: ubuntu-latest
228237
needs: [build, ensure_cargo_installs]
@@ -279,6 +288,9 @@ jobs:
279288

280289

281290
shellcheck:
291+
concurrency:
292+
group: ${{ github.head_ref }}-${{ github.workflow}}-shellcheck
293+
cancel-in-progress: true
282294
env:
283295
SHELLCHECK_VERSION: v0.8.0
284296
runs-on: ubuntu-latest
@@ -310,6 +322,9 @@ jobs:
310322
run: ci/shellcheck.sh
311323

312324
format:
325+
concurrency:
326+
group: ${{ github.head_ref }}-${{ github.workflow}}-format
327+
cancel-in-progress: true
313328
if: github.ref != 'refs/heads/main'
314329
runs-on: ubuntu-latest
315330
steps:
@@ -329,6 +344,9 @@ jobs:
329344
ci/rustfmt.sh
330345
331346
test-npm-package:
347+
concurrency:
348+
group: ${{ github.head_ref }}-${{ github.workflow}}-test-npm-package-${{matrix.node-version}}
349+
cancel-in-progress: true
332350
if: github.ref != 'refs/heads/main'
333351
runs-on: ubuntu-latest
334352
needs: [build, starlingmonkey-build]
@@ -354,6 +372,9 @@ jobs:
354372
- run: npm test
355373

356374
e2e:
375+
concurrency:
376+
group: ${{ github.head_ref }}-${{ github.workflow}}-e2e
377+
cancel-in-progress: true
357378
if: github.ref != 'refs/heads/main'
358379
runs-on: ubuntu-latest
359380
needs: [build]
@@ -394,8 +415,11 @@ jobs:
394415
path: starling.wasm
395416

396417
starlingmonkey-run_wpt:
418+
concurrency:
419+
group: ${{ github.head_ref }}-${{ github.workflow}}-starlingmonkey-run_wpt
420+
cancel-in-progress: true
397421
if: github.ref != 'refs/heads/main'
398-
name: Run Web Platform Tests
422+
name: Run Web Platform Tests (starlingmonkey)
399423
needs: [starlingmonkey-build, ensure_cargo_installs]
400424
runs-on: ubuntu-latest
401425
steps:
@@ -447,6 +471,9 @@ jobs:
447471
run: node ./tests/wpt-harness/run-wpt.mjs --starlingmonkey -vv
448472

449473
starlingmonkey-sdktest:
474+
concurrency:
475+
group: ${{ github.head_ref }}-${{ github.workflow}}-starlingmonkey-sdktest-${{matrix.profile}}-${{matrix.platform}}
476+
cancel-in-progress: true
450477
if: github.ref != 'refs/heads/main'
451478
runs-on: ubuntu-latest
452479
strategy:
@@ -504,4 +531,4 @@ jobs:
504531

505532
- run: SUFFIX_STRING=${{matrix.profile}} node integration-tests/js-compute/test.js ${{ matrix.platform == 'viceroy' && '--local' || '' }}
506533
env:
507-
FASTLY_API_TOKEN: ${{ secrets.FASTLY_API_TOKEN }}
534+
FASTLY_API_TOKEN: ${{ secrets.FASTLY_API_TOKEN }}

0 commit comments

Comments
 (0)