Skip to content

Commit 1e6dce4

Browse files
committed
Update js-compute-runtime.cpp
1 parent 9b98461 commit 1e6dce4

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

c-dependencies/js-compute-runtime/js-compute-runtime.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ bool eval_stdin(JSContext *cx, MutableHandleValue result) {
264264
return false;
265265
}
266266

267-
// TODO: verify that it's better to perform a shrinking GC here, as manual
267+
// TODO(performance): verify that it's better to perform a shrinking GC here, as manual
268268
// testing indicates. Running a shrinking GC here causes *fewer* 4kb pages to
269269
// be written to when processing a request, at least for one fairly large
270270
// input script.
@@ -296,13 +296,13 @@ bool eval_stdin(JSContext *cx, MutableHandleValue result) {
296296
report_unhandled_promise_rejections(cx);
297297
}
298298

299-
// TODO: check if it makes sense to increase the empty chunk count *before*
299+
// TODO(performance): check if it makes sense to increase the empty chunk count *before*
300300
// running GC like this. The working theory is that otherwise the engine might
301301
// mark chunk pages as free that then later the allocator doesn't turn into
302302
// chunks without further fragmentation. But that might be wrong.
303303
// JS_SetGCParameter(cx, JSGC_MAX_EMPTY_CHUNK_COUNT, 10);
304304

305-
// TODO: verify that it's better to *not* perform a shrinking GC here, as
305+
// TODO(performance): verify that it's better to *not* perform a shrinking GC here, as
306306
// manual testing indicates. Running a shrinking GC here causes *more* 4kb
307307
// pages to be written to when processing a request, at least for one fairly
308308
// large input script.

0 commit comments

Comments
 (0)