feat: update to gecko-dev 123.0.1 (#744)

Author: JakeChampion

integration-tests/js-compute/fixtures/app/src/dynamic-backend.js

@@ -1626,42 +1626,6 @@ function createValidHttpMeBackend() {
       tlsMinVersion: 1.2,
       tlsMaxVersion: 1.2,
       certificateHostname: "http-me.glitch.me",
-      checkCertificate: true,
-      caCertificate: `-----BEGIN CERTIFICATE-----
-MIIGFTCCBP2gAwIBAgIQBWn2NbRr0RaO2KoKZawI3DANBgkqhkiG9w0BAQsFADA8
-MQswCQYDVQQGEwJVUzEPMA0GA1UEChMGQW1hem9uMRwwGgYDVQQDExNBbWF6b24g
-UlNBIDIwNDggTTAxMB4XDTIzMDIyMjAwMDAwMFoXDTI0MDIwMTIzNTk1OVowFTET
-MBEGA1UEAxMKZ2xpdGNoLmNvbTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoC
-ggEBAI9b/W4A/W6ayoqEgANycU0izvmZbTzcVzTA9+UsGKgsYRscIvc7hzx5LQ/v
-odG3ZN1d+j1hmE5BJVIU9T32ROJgj/fSV5flvW66B9mNMKndjVElC/bV+Gdaro3B
-QbwdgJnJhWZUQozCKuVB6bajIlbX7MM7zl8b1Iu0d+sXEBB/cYPfz97NM1HXDilg
-EI2gJQ0TehggrmZiNStK5wEz1Lt41dBnt00tuYWdvNgMBSffxDKrrcZhA8BQZBls
-1SH+GfyUJnfuleuC9m7xICsAQhXDQeuRGxR9TwDruIqAPfQkwsetAMH2L7nCdeFv
-5Pc4ziFiOrB5zuMBxZBbqiO5nlcCAwEAAaOCAzgwggM0MB8GA1UdIwQYMBaAFIG4
-DmOKiRIY5fo7O1CVn+blkBOFMB0GA1UdDgQWBBS5l/ww3EumPf1skwK6ksHL5lB6
-nDBpBgNVHREEYjBgggpnbGl0Y2guY29tggoqLmdvbWl4Lm1lgglnb21peC5jb22C
-CGdvbWl4Lm1lgglnbGl0Y2gubWWCDCouZ2xpdGNoLmNvbYILKi5nb21peC5jb22C
-CyouZ2xpdGNoLm1lMA4GA1UdDwEB/wQEAwIFoDAdBgNVHSUEFjAUBggrBgEFBQcD
-AQYIKwYBBQUHAwIwOwYDVR0fBDQwMjAwoC6gLIYqaHR0cDovL2NybC5yMm0wMS5h
-bWF6b250cnVzdC5jb20vcjJtMDEuY3JsMBMGA1UdIAQMMAowCAYGZ4EMAQIBMHUG
-CCsGAQUFBwEBBGkwZzAtBggrBgEFBQcwAYYhaHR0cDovL29jc3AucjJtMDEuYW1h
-em9udHJ1c3QuY29tMDYGCCsGAQUFBzAChipodHRwOi8vY3J0LnIybTAxLmFtYXpv
-bnRydXN0LmNvbS9yMm0wMS5jZXIwDAYDVR0TAQH/BAIwADCCAX8GCisGAQQB1nkC
-BAIEggFvBIIBawFpAHcA7s3QZNXbGs7FXLedtM0TojKHRny87N7DUUhZRnEftZsA
-AAGGdsIYiwAABAMASDBGAiEA9ZoylVZ1uxVwq8pg/4FUIDpr/ATbJUrGKV/qtOu9
-tb4CIQDUkC1upftKiDbJ8SY6pwWdRRhF4RemWnWk7NMJlEqg6wB3AHPZnokbTJZ4
-oCB9R53mssYc0FFecRkqjGuAEHrBd3K1AAABhnbCGOEAAAQDAEgwRgIhAOl6AWKw
-ER7jdba+1JsVxytqq/UXYxcagJr86N8/XTZjAiEAteNRdS0oPHaDUcsX3GKCd96b
-fvvIvl/xQ5LjPw9kZuQAdQBIsONr2qZHNA/lagL6nTDrHFIBy1bdLIHZu7+rOdiE
-cwAAAYZ2whinAAAEAwBGMEQCIFyQrYFFQAVc1GpIJVXKQLKg+0O8QWErE2VtSo8N
-9/0QAiBbnuzpTdIa6qqltabbj2JWw0I72l9GswXK5YM6RTDPdTANBgkqhkiG9w0B
-AQsFAAOCAQEAlaKQm/pbfZbmcECekZtLU9zQAmbcjKtfZ6IdbNx3+SV5u13/lUUO
-o/yUuQ/BRoTYKLYnTY5ojY1/O4en4cLd9msSN+C5nuAEw//twiczBCwv9aAA+eQw
-ssu1JNRB0qiV5wnpoyQ3/xF+TsOMT2heDOvpoG0WDLfrzuFJvWAfNwrRDjhORAQQ
-7M740SMXdSv9aAZ8R1Aj/QyQqlwKOGPImqHvUDDmStEtjSrrMPM+BpuHrEdpQpbi
-g6yC3gfHo2GQS2n3KDbk6JrqAk1ZIIhYrcU7TX9iuWj4MrEvse7mrL7GYF8ISrt8
-j141R75hpv7ieDAtvoIL33FHE59ikJRwkg==
------END CERTIFICATE-----`,
       // Colon-delimited list of permitted SSL Ciphers
       ciphers: "ECDHE-RSA-AES128-GCM-SHA256:!RC4",
       sniHostname: "http-me.glitch.me",

runtime/js-compute-runtime/builtins/body.cpp

@@ -65,7 +65,8 @@ bool FastlyBody::read(JSContext *cx, unsigned argc, JS::Value *vp) {
   auto &chunk = result.unwrap();
   JS::UniqueChars buffer = std::move(chunk.ptr);
   JS::RootedObject array_buffer(cx);
-  array_buffer.set(JS::NewArrayBufferWithContents(cx, chunk.len, buffer.get()));
+  array_buffer.set(JS::NewArrayBufferWithContents(
+      cx, chunk.len, buffer.get(), JS::NewArrayBufferOutOfMemory::CallerMustFreeMemory));
   if (!array_buffer) {
     JS_ReportOutOfMemory(cx);
     return false;

runtime/js-compute-runtime/builtins/cache-core.cpp

@@ -517,7 +517,8 @@ bool CacheEntry::userMetadata(JSContext *cx, unsigned argc, JS::Value *vp) {
   }
   auto metadata = std::move(res.unwrap());
   JS::RootedObject array_buffer(cx);
-  array_buffer.set(JS::NewArrayBufferWithContents(cx, metadata.len, metadata.ptr.get()));
+  array_buffer.set(JS::NewArrayBufferWithContents(
+      cx, metadata.len, metadata.ptr.get(), JS::NewArrayBufferOutOfMemory::CallerMustFreeMemory));
   if (!array_buffer) {
     JS_ReportOutOfMemory(cx);
     return false;

runtime/js-compute-runtime/builtins/client-info.cpp

@@ -187,7 +187,8 @@ bool ClientInfo::tls_client_hello_get(JSContext *cx, unsigned argc, JS::Value *v
     }
 
     auto hello = std::move(res.unwrap());
-    buffer.set(JS::NewArrayBufferWithContents(cx, hello.len, hello.ptr.get()));
+    buffer.set(JS::NewArrayBufferWithContents(cx, hello.len, hello.ptr.get(),
+                                              JS::NewArrayBufferOutOfMemory::CallerMustFreeMemory));
     if (!buffer) {
       // We can be here if the array buffer was too large -- if that was the case then a
       // JSMSG_BAD_ARRAY_LENGTH will have been created.
@@ -216,7 +217,8 @@ bool ClientInfo::tls_client_certificate_get(JSContext *cx, unsigned argc, JS::Va
     }
     auto cert = std::move(res.unwrap());
 
-    buffer.set(JS::NewArrayBufferWithContents(cx, cert.len, cert.ptr.get()));
+    buffer.set(JS::NewArrayBufferWithContents(cx, cert.len, cert.ptr.get(),
+                                              JS::NewArrayBufferOutOfMemory::CallerMustFreeMemory));
     if (!buffer) {
       // We can be here if the array buffer was too large -- if that was the case then a
       // JSMSG_BAD_ARRAY_LENGTH will have been created.

runtime/js-compute-runtime/builtins/crypto-algorithm.cpp

@@ -130,7 +130,8 @@ JSObject *digest(JSContext *cx, std::span<uint8_t> data, const EVP_MD *algorithm
   }
   // 3. Return a new ArrayBuffer containing result.
   JS::RootedObject array_buffer(cx);
-  array_buffer.set(JS::NewArrayBufferWithContents(cx, size, buf.get()));
+  array_buffer.set(JS::NewArrayBufferWithContents(
+      cx, size, buf.get(), JS::NewArrayBufferOutOfMemory::CallerMustFreeMemory));
   if (!array_buffer) {
     JS_ReportOutOfMemory(cx);
     return nullptr;
@@ -781,7 +782,7 @@ JSObject *CryptoAlgorithmHMAC_Sign_Verify::sign(JSContext *cx, JS::HandleObject
 
   // 2. Return a new ArrayBuffer object, associated with the relevant global object of this [HTML], and containing the bytes of mac.
   JS::RootedObject array_buffer(cx);
-  array_buffer.set(JS::NewArrayBufferWithContents(cx, size, sig.get()));
+  array_buffer.set(JS::NewArrayBufferWithContents(cx, size, sig.get(), JS::NewArrayBufferOutOfMemory::CallerMustFreeMemory));
   if (!array_buffer) {
     JS_ReportOutOfMemory(cx);
     return nullptr;
@@ -900,7 +901,7 @@ JSObject *CryptoAlgorithmECDSA_Sign_Verify::sign(JSContext *cx, JS::HandleObject
   std::memcpy(result.get() + rBytesSize, sBytes, sBytesSize);
 
   // 7. Return the result of creating an ArrayBuffer containing result.
-  JS::RootedObject buffer(cx, JS::NewArrayBufferWithContents(cx, resultSize, result.get()));
+  JS::RootedObject buffer(cx, JS::NewArrayBufferWithContents(cx, resultSize, result.get(), JS::NewArrayBufferOutOfMemory::CallerMustFreeMemory));
   if (!buffer) {
     // We can be here is the array buffer was too large -- if that was the case then a
     // JSMSG_BAD_ARRAY_LENGTH will have been created. No other failure scenarios in this path will
@@ -1054,7 +1055,7 @@ JSObject *CryptoAlgorithmRSASSA_PKCS1_v1_5_Sign_Verify::sign(JSContext *cx, JS::
 
   // 5. Return a new ArrayBuffer associated with the relevant global object of this [HTML], and
   // containing the bytes of signature.
-  JS::RootedObject buffer(cx, JS::NewArrayBufferWithContents(cx, signature_length, signature.get()));
+  JS::RootedObject buffer(cx, JS::NewArrayBufferWithContents(cx, signature_length, signature.get(), JS::NewArrayBufferOutOfMemory::CallerMustFreeMemory));
   if (!buffer) {
     // We can be here is the array buffer was too large -- if that was the case then a
     // JSMSG_BAD_ARRAY_LENGTH will have been created. No other failure scenarios in this path will

runtime/js-compute-runtime/builtins/crypto-key.cpp

@@ -657,8 +657,9 @@ JSObject *CryptoKey::createRSA(JSContext *cx, CryptoAlgorithmRSASSA_PKCS1_v1_5_I
   auto exp = keyData->exponent;
   std::copy(exp.begin(), exp.end(), p.get());
 
-  JS::RootedObject buffer(cx,
-                          JS::NewArrayBufferWithContents(cx, keyData->exponent.size(), p.get()));
+  JS::RootedObject buffer(
+      cx, JS::NewArrayBufferWithContents(cx, keyData->exponent.size(), p.get(),
+                                         JS::NewArrayBufferOutOfMemory::CallerMustFreeMemory));
   // `buffer` takes ownership of `p` if the call to NewArrayBufferWithContents was successful
   // if the call was not successful, we need to free `p` before exiting from the function.
   if (!buffer) {

runtime/js-compute-runtime/builtins/request-response.cpp

@@ -388,7 +388,9 @@ bool RequestOrResponse::parse_body(JSContext *cx, JS::HandleObject self, JS::Uni
   JS::RootedValue result(cx);
 
   if constexpr (result_type == RequestOrResponse::BodyReadResult::ArrayBuffer) {
-    JS::RootedObject array_buffer(cx, JS::NewArrayBufferWithContents(cx, len, buf.get()));
+    JS::RootedObject array_buffer(
+        cx, JS::NewArrayBufferWithContents(cx, len, buf.get(),
+                                           JS::NewArrayBufferOutOfMemory::CallerMustFreeMemory));
     if (!array_buffer) {
       return RejectPromiseWithPendingError(cx, result_promise);
     }

runtime/js-compute-runtime/builtins/shared/console.cpp

@@ -3,6 +3,7 @@
 #include <chrono>
 #include <map>
 
+#include "mozilla/Try.h"
 #include <js/Array.h>
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Winvalid-offsetof"
@@ -287,10 +288,16 @@ JS::Result<mozilla::Ok> ToSource(JSContext *cx, std::string &sourceOut, JS::Hand
     if (JS_ObjectIsFunction(obj)) {
       sourceOut += "[Function";
       std::string source;
-      auto id = JS_GetFunctionId(JS_ValueToFunction(cx, val));
-      if (id) {
+      JS::Rooted<JSFunction *> fun(cx, JS_ValueToFunction(cx, val));
+      if (fun) {
+        JS::RootedString name(cx);
+        if (!JS_GetFunctionId(cx, fun, &name)) {
+          return JS::Result<mozilla::Ok>(JS::Error());
+        }
+        if (!name) {
+          name = JS_AtomizeAndPinString(cx, "");
+        }
         sourceOut += " ";
-        JS::RootedString name(cx, id);
         auto msg = core::encode(cx, name);
         if (!msg) {
           return JS::Result<mozilla::Ok>(JS::Error());

runtime/js-compute-runtime/builtins/shared/text-encoder.cpp

@@ -29,7 +29,9 @@ bool TextEncoder::encode(JSContext *cx, unsigned argc, JS::Value *vp) {
   }
 
   auto chars = core::encode(cx, args[0]);
-  JS::RootedObject buffer(cx, JS::NewArrayBufferWithContents(cx, chars.len, chars.begin()));
+  JS::RootedObject buffer(
+      cx, JS::NewArrayBufferWithContents(cx, chars.len, chars.begin(),
+                                         JS::NewArrayBufferOutOfMemory::CallerMustFreeMemory));
   if (!buffer) {
     return false;
   }

runtime/js-compute-runtime/core/event_loop.cpp

@@ -206,7 +206,9 @@ bool process_body_read(JSContext *cx, JS::HandleObject streamSource, host_api::H
   // We don't release control of chunk's data until after we've checked that the array buffer
   // allocation has been successful, as that ensures that the return path frees chunk automatically
   // when necessary.
-  JS::RootedObject buffer(cx, JS::NewArrayBufferWithContents(cx, chunk.len, chunk.ptr.get()));
+  JS::RootedObject buffer(
+      cx, JS::NewArrayBufferWithContents(cx, chunk.len, chunk.ptr.get(),
+                                         JS::NewArrayBufferOutOfMemory::CallerMustFreeMemory));
   if (!buffer) {
     return error_stream_controller_with_pending_exception(cx, controller);
   }