fix: Make Response.redirect headers be immutable

Jake Champion · JakeChampion · commit 3527eaf62266 · 2023-10-25T14:15:27.000+01:00
diff --git a/runtime/js-compute-runtime/builtins/request-response.cpp b/runtime/js-compute-runtime/builtins/request-response.cpp
@@ -2423,6 +2423,7 @@ bool Response::redirect(JSContext *cx, unsigned argc, JS::Value *vp) {
   if (!builtins::Headers::maybe_add(cx, headers, "location", url_str.begin())) {
     return false;
   }
+  JS::SetReservedSlot(headers, static_cast<uint32_t>(builtins::Headers::Slots::Immutable), JS::TrueValue());
   JS::SetReservedSlot(response, static_cast<uint32_t>(Slots::Headers), JS::ObjectValue(*headers));
   JS::SetReservedSlot(response, static_cast<uint32_t>(Slots::Redirected), JS::FalseValue());
   // 8. Return responseObject.

Original file line number	Diff line number	Diff line change
`@@ -2423,6 +2423,7 @@ bool Response::redirect(JSContext cx, unsigned argc, JS::Value vp) {`
`2423`	`2423`	`if (!builtins::Headers::maybe_add(cx, headers, "location", url_str.begin())) {`
`2424`	`2424`	`return false;`
`2425`	`2425`	`}`
	`2426`	`+ JS::SetReservedSlot(headers, static_cast<uint32_t>(builtins::Headers::Slots::Immutable), JS::TrueValue());`
`2426`	`2427`	`JS::SetReservedSlot(response, static_cast<uint32_t>(Slots::Headers), JS::ObjectValue(*headers));`
`2427`	`2428`	`JS::SetReservedSlot(response, static_cast<uint32_t>(Slots::Redirected), JS::FalseValue());`
`2428`	`2429`	`// 8. Return responseObject.`