fix: debug build & tests (#818)

Author: Guy Bedford

.github/workflows/main.yml

@@ -166,9 +166,7 @@ jobs:
     name: Run Web Platform Tests
     strategy:
       matrix:
-        include:
-          - profile: debug
-          - profile: release
+        profile: [debug, release]
     needs: [build, ensure_cargo_installs]
     runs-on: ubuntu-latest
     steps:
@@ -228,6 +226,9 @@ jobs:
     if: github.ref != 'refs/heads/main'
     runs-on: ubuntu-latest
     needs: [build, ensure_cargo_installs]
+    strategy:
+      matrix:
+        profile: [debug, release]
     steps:
     - name: Checkout fastly/js-compute-runtime
       uses: actions/checkout@v3
@@ -262,12 +263,10 @@ jobs:
         echo "bailing out from the build early"
         exit 1
 
-    # https://github.com/fastly/js-compute-runtime/issues/361
-    # TODO: Use engine-debug on all apps once we upgrade to FF 109
     - name: Download Engine
       uses: actions/download-artifact@v3
       with:
-        name: 'engine-debug'
+        name: 'engine-${{ matrix.profile }}'
     - run: yarn install --frozen-lockfile
 
     - name: js-compute Integration Tests Job
@@ -364,6 +363,9 @@ jobs:
   starlingmonkey-build:
     name: StarlingMonkey Build
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        profile: [debug, release]
     steps:
     - uses: actions/checkout@v3
       with:
@@ -373,10 +375,14 @@ jobs:
         rustup toolchain install 1.77.1
         rustup target add wasm32-wasi --toolchain 1.77.1
     - name: Build
+      if: ${{ matrix.profile == 'release' }}
       run: npm run build:starlingmonkey
+    - name: Build
+      if: ${{ matrix.profile == 'debug' }}
+      run: npm run build:starlingmonkey:debug
     - uses: actions/upload-artifact@v3
       with:
-        name: starling-release
+        name: starling-${{ matrix.profile }}
         path: starling.wasm
 
   starlingmonkey-run_wpt:
@@ -438,6 +444,10 @@ jobs:
     strategy:
       matrix:
         platform: [viceroy, compute]
+        profile: [debug, release]
+        exclude:
+          - platform: compute
+            profile: release
     needs: [starlingmonkey-build]
     steps:
     - name: Checkout fastly/js-compute-runtime
@@ -475,7 +485,7 @@ jobs:
     - name: Download Engine
       uses: actions/download-artifact@v3
       with:
-        name: starling-release
+        name: starling-${{ matrix.profile }}
     - run: yarn install --frozen-lockfile
 
     - name: Yarn install

runtime/fastly/builtins/fetch/request-response.cpp

@@ -238,17 +238,14 @@ uint32_t RequestOrResponse::handle(JSObject *obj) {
 }
 
 bool RequestOrResponse::has_body(JSObject *obj) {
-  MOZ_ASSERT(is_instance(obj));
   return JS::GetReservedSlot(obj, static_cast<uint32_t>(Slots::HasBody)).toBoolean();
 }
 
 host_api::HttpBody RequestOrResponse::body_handle(JSObject *obj) {
-  MOZ_ASSERT(is_instance(obj));
   return host_api::HttpBody(JS::GetReservedSlot(obj, static_cast<uint32_t>(Slots::Body)).toInt32());
 }
 
 JSObject *RequestOrResponse::body_stream(JSObject *obj) {
-  MOZ_ASSERT(is_instance(obj));
   return JS::GetReservedSlot(obj, static_cast<uint32_t>(Slots::BodyStream)).toObjectOrNull();
 }
 
@@ -259,7 +256,6 @@ JSObject *RequestOrResponse::body_source(JSContext *cx, JS::HandleObject obj) {
 }
 
 bool RequestOrResponse::body_used(JSObject *obj) {
-  MOZ_ASSERT(is_instance(obj));
   return JS::GetReservedSlot(obj, static_cast<uint32_t>(Slots::BodyUsed)).toBoolean();
 }
 
@@ -1133,7 +1129,6 @@ bool RequestOrResponse::maybe_stream_body(JSContext *cx, JS::HandleObject body_o
 }
 
 JSObject *RequestOrResponse::create_body_stream(JSContext *cx, JS::HandleObject owner) {
-  MOZ_ASSERT(is_instance(owner));
   MOZ_ASSERT(!body_stream(owner));
   JS::RootedObject source(cx, NativeStreamSource::create(cx, owner, JS::UndefinedHandleValue,
                                                          body_source_pull_algorithm,
@@ -1159,7 +1154,6 @@ JSObject *RequestOrResponse::create_body_stream(JSContext *cx, JS::HandleObject
 
 bool RequestOrResponse::body_get(JSContext *cx, JS::CallArgs args, JS::HandleObject self,
                                  bool create_if_undefined) {
-  MOZ_ASSERT(is_instance(self));
   if (!has_body(self)) {
     args.rval().setNull();
     return true;
@@ -3072,10 +3066,6 @@ bool Response::init_class(JSContext *cx, JS::HandleObject global) {
 JSObject *Response::create(JSContext *cx, JS::HandleObject response,
                            host_api::HttpResp response_handle, host_api::HttpBody body_handle,
                            bool is_upstream, bool is_grip, JS::UniqueChars backend) {
-  // MOZ_ASSERT(cx);
-  // MOZ_ASSERT(is_instance(response));
-  // MOZ_ASSERT(response_handle);
-  // MOZ_ASSERT(body_handle);
   JS::SetReservedSlot(response, static_cast<uint32_t>(Slots::Response),
                       JS::Int32Value(response_handle.handle));
   JS::SetReservedSlot(response, static_cast<uint32_t>(Slots::Headers), JS::NullValue());

runtime/js-compute-runtime/builtins/request-response.cpp

@@ -224,17 +224,14 @@ uint32_t RequestOrResponse::handle(JSObject *obj) {
 }
 
 bool RequestOrResponse::has_body(JSObject *obj) {
-  MOZ_ASSERT(is_instance(obj));
   return JS::GetReservedSlot(obj, static_cast<uint32_t>(Slots::HasBody)).toBoolean();
 }
 
 host_api::HttpBody RequestOrResponse::body_handle(JSObject *obj) {
-  MOZ_ASSERT(is_instance(obj));
   return host_api::HttpBody(JS::GetReservedSlot(obj, static_cast<uint32_t>(Slots::Body)).toInt32());
 }
 
 JSObject *RequestOrResponse::body_stream(JSObject *obj) {
-  MOZ_ASSERT(is_instance(obj));
   return JS::GetReservedSlot(obj, static_cast<uint32_t>(Slots::BodyStream)).toObjectOrNull();
 }
 
@@ -245,7 +242,6 @@ JSObject *RequestOrResponse::body_source(JSContext *cx, JS::HandleObject obj) {
 }
 
 bool RequestOrResponse::body_used(JSObject *obj) {
-  MOZ_ASSERT(is_instance(obj));
   return JS::GetReservedSlot(obj, static_cast<uint32_t>(Slots::BodyUsed)).toBoolean();
 }
 
@@ -1125,7 +1121,6 @@ bool RequestOrResponse::maybe_stream_body(JSContext *cx, JS::HandleObject body_o
 }
 
 JSObject *RequestOrResponse::create_body_stream(JSContext *cx, JS::HandleObject owner) {
-  MOZ_ASSERT(is_instance(owner));
   MOZ_ASSERT(!body_stream(owner));
   JS::RootedObject source(cx, builtins::NativeStreamSource::create(
                                   cx, owner, JS::UndefinedHandleValue, body_source_pull_algorithm,
@@ -1151,7 +1146,6 @@ JSObject *RequestOrResponse::create_body_stream(JSContext *cx, JS::HandleObject
 
 bool RequestOrResponse::body_get(JSContext *cx, JS::CallArgs args, JS::HandleObject self,
                                  bool create_if_undefined) {
-  MOZ_ASSERT(is_instance(self));
   if (!has_body(self)) {
     args.rval().setNull();
     return true;
@@ -3070,10 +3064,6 @@ bool Response::init_class(JSContext *cx, JS::HandleObject global) {
 JSObject *Response::create(JSContext *cx, JS::HandleObject response,
                            host_api::HttpResp response_handle, host_api::HttpBody body_handle,
                            bool is_upstream, bool is_grip, JS::UniqueChars backend) {
-  // MOZ_ASSERT(cx);
-  // MOZ_ASSERT(is_instance(response));
-  // MOZ_ASSERT(response_handle);
-  // MOZ_ASSERT(body_handle);
   JS::SetReservedSlot(response, static_cast<uint32_t>(Slots::Response),
                       JS::Int32Value(response_handle.handle));
   JS::SetReservedSlot(response, static_cast<uint32_t>(Slots::Headers), JS::NullValue());