wpt fixes

Author: Guy Bedford

c-dependencies/js-compute-runtime/js-compute-runtime.cpp

@@ -115,7 +115,8 @@ bool init_js() {
   if (!js::UseInternalJobQueues(cx) || !JS::InitSelfHostedCode(cx))
     return false;
 
-  bool ENABLE_EXPERIMENTAL_BYOB_STREAMS = std::string(std::getenv("ENABLE_EXPERIMENTAL_BYOB_STREAMS")) == "1";
+  bool ENABLE_EXPERIMENTAL_BYOB_STREAMS =
+      std::string(std::getenv("ENABLE_EXPERIMENTAL_BYOB_STREAMS")) == "1";
 
   // TODO: check if we should set a different creation zone.
   JS::RealmOptions options;

src/compileApplicationToWasm.js

@@ -99,13 +99,16 @@ export async function compileApplicationToWasm(input, output, wasmEngine, enable
         shell: true,
         encoding: "utf-8",
         env: {
-          ENABLE_EXPERIMENTAL_BYOB_STREAMS: enableExperimentalByobStreams ? 1 : 0
+          ENABLE_EXPERIMENTAL_BYOB_STREAMS: enableExperimentalByobStreams ? '1' : '0'
         }
       }
     );
+    if (wizerProcess.status !== 0) {
+      throw new Error(`Wizer initialization failure`);
+    }
     process.exitCode = wizerProcess.status;
   } catch (error) {
-    console.error(`Error: Failed to compile JavaScript to Wasm`, error.message);
+    console.error(`Error: Failed to compile JavaScript to Wasm: `, error.message);
     process.exit(1);
   }
 }

tests/wpt-harness/build-wpt-runtime.sh

@@ -10,4 +10,4 @@ inputs=(
 )
 
 cat "${inputs[@]}" > "${script_dir}/wpt-test-runner.js"
-node "${script_dir}/../../js-compute-runtime-cli.js" "${script_dir}/wpt-test-runner.js" wpt-runtime.wasm
+node "${script_dir}/../../js-compute-runtime-cli.js" --enable-experimental-byob-streams "${script_dir}/wpt-test-runner.js" wpt-runtime.wasm

tests/wpt-harness/expectations/streams/readable-byte-streams/bad-buffers-and-views.any.js.json

@@ -57,7 +57,7 @@
     "status": "PASS"
   },
   "ReadableStream with byte source: respondWithNewView() throws if the supplied view's buffer is zero-length (in the closed state)": {
-    "status": "FAIL"
+    "status": "PASS"
   },
   "ReadableStream with byte source: respondWithNewView() throws if the supplied view is non-zero-length (in the closed state)": {
     "status": "PASS"

tests/wpt-harness/expectations/streams/readable-byte-streams/construct-byob-request.any.js.json

@@ -0,0 +1,50 @@
+{
+  "ReadableStreamBYOBRequest constructor should throw when passed a undefined ReadableByteStreamController and a undefined view": {
+    "status": "FAIL"
+  },
+  "ReadableStreamBYOBRequest constructor should throw when passed a undefined ReadableByteStreamController and a null view": {
+    "status": "FAIL"
+  },
+  "ReadableStreamBYOBRequest constructor should throw when passed a undefined ReadableByteStreamController and a fake view": {
+    "status": "FAIL"
+  },
+  "ReadableStreamBYOBRequest constructor should throw when passed a undefined ReadableByteStreamController and a real view": {
+    "status": "FAIL"
+  },
+  "ReadableStreamBYOBRequest constructor should throw when passed a null ReadableByteStreamController and a undefined view": {
+    "status": "FAIL"
+  },
+  "ReadableStreamBYOBRequest constructor should throw when passed a null ReadableByteStreamController and a null view": {
+    "status": "FAIL"
+  },
+  "ReadableStreamBYOBRequest constructor should throw when passed a null ReadableByteStreamController and a fake view": {
+    "status": "FAIL"
+  },
+  "ReadableStreamBYOBRequest constructor should throw when passed a null ReadableByteStreamController and a real view": {
+    "status": "FAIL"
+  },
+  "ReadableStreamBYOBRequest constructor should throw when passed a fake ReadableByteStreamController and a undefined view": {
+    "status": "FAIL"
+  },
+  "ReadableStreamBYOBRequest constructor should throw when passed a fake ReadableByteStreamController and a null view": {
+    "status": "FAIL"
+  },
+  "ReadableStreamBYOBRequest constructor should throw when passed a fake ReadableByteStreamController and a fake view": {
+    "status": "FAIL"
+  },
+  "ReadableStreamBYOBRequest constructor should throw when passed a fake ReadableByteStreamController and a real view": {
+    "status": "FAIL"
+  },
+  "ReadableStreamBYOBRequest constructor should throw when passed a real ReadableByteStreamController and a undefined view": {
+    "status": "FAIL"
+  },
+  "ReadableStreamBYOBRequest constructor should throw when passed a real ReadableByteStreamController and a null view": {
+    "status": "FAIL"
+  },
+  "ReadableStreamBYOBRequest constructor should throw when passed a real ReadableByteStreamController and a fake view": {
+    "status": "FAIL"
+  },
+  "ReadableStreamBYOBRequest constructor should throw when passed a real ReadableByteStreamController and a real view": {
+    "status": "FAIL"
+  }
+}

tests/wpt-harness/expectations/streams/readable-byte-streams/general.any.js.json

@@ -210,7 +210,7 @@
     "status": "PASS"
   },
   "calling respondWithNewView() twice on the same byobRequest should throw": {
-    "status": "FAIL"
+    "status": "PASS"
   },
   "calling respond(0) twice on the same byobRequest should throw even when closed": {
     "status": "PASS"
@@ -243,10 +243,10 @@
     "status": "FAIL"
   },
   "ReadableStream with byte source: respondWithNewView() with a smaller view": {
-    "status": "FAIL"
+    "status": "PASS"
   },
   "ReadableStream with byte source: respondWithNewView() with a zero-length view (in the closed state)": {
-    "status": "FAIL"
+    "status": "PASS"
   },
   "ReadableStream with byte source: respondWithNewView() with a transferred non-zero-length view (in the readable state)": {
     "status": "FAIL"
@@ -294,6 +294,6 @@
     "status": "FAIL"
   },
   "ReadableStream with byte source: autoAllocateChunkSize, read(), respondWithNewView()": {
-    "status": "FAIL"
+    "status": "PASS"
   }
 }