refactor Env to use the class BuiltinNoConstructor (#191)

Co-authored-by: Jake Champion <[email protected]>

Author: JakeChampion

c-dependencies/js-compute-runtime/builtins/env.cpp

@@ -1,11 +1,8 @@
 
 #include "env.h"
+namespace builtins {
 
-namespace Env {
-
-namespace {
-
-bool env_get(JSContext *cx, unsigned argc, JS::Value *vp) {
+bool Env::env_get(JSContext *cx, unsigned argc, JS::Value *vp) {
   JS::CallArgs args = CallArgsFromVp(argc, vp);
   if (!args.requireAtLeast(cx, "fastly.env.get", 1))
     return false;
@@ -23,14 +20,15 @@ bool env_get(JSContext *cx, unsigned argc, JS::Value *vp) {
   return true;
 }
 
-const JSFunctionSpec methods[] = {JS_FN("get", env_get, 1, JSPROP_ENUMERATE), JS_FS_END};
+const JSFunctionSpec Env::methods[] = {JS_FN("get", env_get, 1, JSPROP_ENUMERATE), JS_FS_END};
 
-} // namespace
+const JSPropertySpec Env::properties[] = {JS_PS_END};
 
-JSObject *create(JSContext *cx) {
+JSObject *Env::create(JSContext *cx) {
   JS::RootedObject env(cx, JS_NewPlainObject(cx));
   if (!env || !JS_DefineFunctions(cx, env, methods))
     return nullptr;
   return env;
 }
-} // namespace Env
+
+} // namespace builtins

c-dependencies/js-compute-runtime/builtins/env.h

@@ -3,8 +3,21 @@
 
 #include "builtin.h"
 
-namespace Env {
-JSObject *create(JSContext *cx);
-}
+namespace builtins {
+
+class Env : public BuiltinNoConstructor<Env> {
+private:
+  static bool env_get(JSContext *cx, unsigned argc, JS::Value *vp);
+
+public:
+  static constexpr const char *class_name = "Env";
+
+  static const JSFunctionSpec methods[];
+  static const JSPropertySpec properties[];
+
+  static JSObject *create(JSContext *cx);
+};
+
+} // namespace builtins
 
 #endif