Initial StarlingMonkey Build (#764)

Author: Guy Bedford

.github/workflows/starlingmonkey.yml

@@ -0,0 +1,88 @@
+name: StarlingMonkey
+concurrency:
+  group: ${{ github.head_ref }}-${{ github.workflow}}
+  cancel-in-progress: true
+on:
+  pull_request:
+  push:
+    branches: [main]
+defaults:
+  run:
+    shell: bash
+env:
+  viceroy_version: 0.9.4
+  wasm-tools_version: 1.0.28
+  fastly-cli_version: 10.4.0
+
+jobs:
+  build:
+    name: StarlingMonkey Build
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+      with:
+        submodules: true
+    - name: Install Rust 1.77.1
+      run: |
+        rustup toolchain install 1.77.1
+        rustup target add wasm32-wasi --toolchain 1.77.1
+    - name: Build
+      run: npm run build:starlingmonkey:debug
+    - uses: actions/upload-artifact@v3
+      with:
+        name: starling-debug
+        path: starling.wasm
+
+  sdktest:
+    if: github.ref != 'refs/heads/main'
+    runs-on: ubuntu-latest
+    needs: [build]
+    steps:
+    - name: Checkout fastly/js-compute-runtime
+      uses: actions/checkout@v3
+    - uses: actions/setup-node@v3
+      with:
+        node-version: 'lts/*'
+        cache: 'yarn'
+
+    - name: Set up Fastly CLI
+      uses: fastly/compute-actions/setup@v4
+      with:
+        token: ${{ secrets.GITHUB_TOKEN }}
+        cli_version: ${{ env.fastly-cli_version }}
+
+    - name: Restore Viceroy from cache
+      uses: actions/cache@v3
+      with:
+        path: "/home/runner/.cargo/bin/viceroy"
+        key: crate-cache-viceroy-${{ env.viceroy_version }}
+    
+    - name: Restore wasm-tools from cache
+      uses: actions/cache@v3
+      id: wasm-tools
+      with:
+        path: "/home/runner/.cargo/bin/wasm-tools"
+        key: crate-cache-wasm-tools-${{ env.wasm-tools_version }}
+
+    - name: "Check wasm-tools has been restored"
+      if: steps.wasm-tools.outputs.cache-hit != 'true'
+      run: |
+        echo "wasm-tools was not restored from the cache"
+        echo "bailing out from the build early"
+        exit 1
+
+    - name: Download Engine
+      uses: actions/download-artifact@v3
+      with:
+        name: starling-debug
+    - run: yarn install --frozen-lockfile
+
+    - name: Yarn install
+      run: |
+        yarn
+        cd ./integration-tests/js-compute
+        yarn
+
+    - run: |
+        cd ./integration-tests/js-compute
+        FASTLY_API_TOKEN=${{ secrets.FASTLY_API_TOKEN }} ./test.js --starlingmonkey --local

.gitignore

@@ -3,6 +3,8 @@
 /integration-tests/**/fixtures/**/fastly.toml
 /integration-tests/**/fixtures/**/*.wasm
 
+/runtime/fastly/build-*/
+
 /compute-js/
 node_modules/
 .DS_Store
@@ -13,6 +15,7 @@ node_modules/
 # compiler_flags
 /js-compute-runtime.wasm
 /js-compute-runtime-component.wasm
+/starling.wasm
 /runtime/js-compute-runtime/obj
 tests/wpt-harness/wpt-test-runner.js
 wpt-runtime.wasm

.gitmodules

@@ -8,3 +8,6 @@
 [submodule "runtime/js-compute-runtime/third_party/fmt"]
 	path = runtime/js-compute-runtime/third_party/fmt
 	url = https://github.com/fmtlib/fmt
+[submodule "runtime/StarlingMonkey"]
+	path = runtime/StarlingMonkey
+	url = [email protected]:bytecodealliance/StarlingMonkey

integration-tests/js-compute/compare-downstream-response.js

@@ -16,7 +16,7 @@ export async function compareDownstreamResponse (configResponse, actualResponse)
   let errors = [];
   // Status
   if (configResponse.status != actualResponse.statusCode) {
-    errors.push(new Error(`[DownstreamResponse: Status mismatch] Expected: ${configResponse.status} - Got: ${actualResponse.status}`));
+    errors.push(new Error(`[DownstreamResponse: Status mismatch] Expected: ${configResponse.status} - Got: ${actualResponse.statusCode}`));
   }
 
   // Headers

integration-tests/js-compute/fixtures/app/src/btoa.js

@@ -737,9 +737,16 @@ routes.set('/btoa', () => {
     if (error) { return error; }
     error = assertThrows(() => atob("--"))
     if (error) { return error; }
-    error = assertThrows(() => atob("__"))
-    if (error) { return error; }
   }
 
   return pass('ok')
 });
+
+routes.set('/btoa-doubleunderscore', () => {
+  let error;
+  
+  error = assertThrows(() => atob("__"))
+  if (error) { return error; }
+
+  return pass('ok');
+});

integration-tests/js-compute/fixtures/app/src/byte-repeater.js

@@ -1,8 +1,10 @@
 /* eslint-env serviceworker */
 
-import { CacheOverride } from 'fastly:cache-override';
+import * as cacheOverride from 'fastly:cache-override';
 import { routes } from "./routes";
 
+const { CacheOverride } = cacheOverride;
+
 routes.set('/byte-repeater', () => {
     let headers = new Headers();
     headers.set("AssemblyScriptHeader", "AssemblyScriptValue");

integration-tests/js-compute/fixtures/app/src/cache-core.js

@@ -3,8 +3,12 @@
 
 import { pass, assert, assertDoesNotThrow, assertThrows, sleep, streamToString, assertResolves } from "./assertions.js";
 import { routes } from "./routes.js";
-import { CoreCache, CacheEntry, CacheState, TransactionCacheEntry } from 'fastly:cache';
-import { FastlyBody } from "fastly:body";
+import { CoreCache, CacheEntry } from 'fastly:cache';
+import * as fastlyCache from 'fastly:cache';
+import * as fastlyBody from "fastly:body";
+
+const { CacheState, TransactionCacheEntry } = fastlyCache;
+const { FastlyBody } = fastlyBody;
 
 let error;
 

integration-tests/js-compute/fixtures/app/src/cache-override.js

@@ -1,7 +1,9 @@
-import { CacheOverride } from 'fastly:cache-override';
+import * as cacheOverride from 'fastly:cache-override';
 import { pass, assert, assertThrows, assertDoesNotThrow } from "./assertions.js";
 import { isRunningLocally, routes } from "./routes.js";
 
+const { CacheOverride } = cacheOverride;
+
 // CacheOverride constructor
 {
 

integration-tests/js-compute/fixtures/app/src/cache-simple.js

@@ -2,9 +2,12 @@
 /* eslint-env serviceworker */
 
 import { pass, assert, assertDoesNotThrow, assertThrows, assertRejects, iteratableToStream, streamToString, assertResolves } from "./assertions.js";
-import { SimpleCache, SimpleCacheEntry } from 'fastly:cache';
+import { SimpleCache } from 'fastly:cache';
+import * as fastlyCache from 'fastly:cache';
 import { routes, isRunningLocally } from "./routes.js";
 
+const { SimpleCacheEntry } = fastlyCache;
+
 let error;
 routes.set("/simple-cache/interface", () => {
     let actual = Reflect.ownKeys(SimpleCache)

integration-tests/js-compute/fixtures/app/src/config-store.js

@@ -1,8 +1,10 @@
 /* eslint-env serviceworker */
 import { pass, assert } from "./assertions.js";
-import { ConfigStore } from 'fastly:config-store'
+import * as configStore from 'fastly:config-store'
 import { routes } from "./routes.js";
 
+const { ConfigStore } = configStore;
+
 routes.set("/config-store", () => {
   let config = new ConfigStore("testconfig");
   let twitterValue = config.get("twitter");