Skip to content

Commit d971e1a

Browse files
Jake ChampionJakeChampion
authored andcommitted
chore: make geo tests not test the timezone offsets as they change when daylight savings is toggled
1 parent 2021237 commit d971e1a

File tree

1 file changed

+12
-5
lines changed
  • integration-tests/js-compute/fixtures/geoip/bin

1 file changed

+12
-5
lines changed

integration-tests/js-compute/fixtures/geoip/bin/index.js

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,19 +129,19 @@ let ipv4Expected = {
129129
country_code: "GB",
130130
country_code3: "GBR",
131131
country_name: "united kingdom",
132-
gmt_offset: 0,
133132
latitude: 53.42,
134133
longitude: -1.05,
135134
metro_code: 826039,
136135
postal_code: "dn11 8af",
137136
proxy_description: "?",
138137
proxy_type: "?",
139138
region: "NTT",
140-
utc_offset: 0
141139
}
142140

143141
routes.set("/fastly/getgeolocationforipaddress/parameter-ipv4-string", async () => {
144142
let geo = fastly.getGeolocationForIpAddress('2.216.196.179')
143+
delete geo.utc_offset;
144+
delete geo.gmt_offset;
145145
let error = assert(geo, ipv4Expected, `fastly.getGeolocationForIpAddress('2.216.196.179') == ipv4Expected`)
146146
if (error) { return error }
147147
return pass()
@@ -158,45 +158,52 @@ let expected = {
158158
country_code: "US",
159159
country_code3: "USA",
160160
country_name: "united states",
161-
gmt_offset: -600,
162161
latitude: 32.94,
163162
longitude: -96.84,
164163
metro_code: 623,
165164
postal_code: "75244",
166165
proxy_description: "?",
167166
proxy_type: "hosting",
168167
region: "TX",
169-
utc_offset: -600
170168
}
171169
routes.set("/fastly/getgeolocationforipaddress/parameter-compressed-ipv6-string", async () => {
172170
let geo = fastly.getGeolocationForIpAddress('2607:f0d0:1002:51::4')
173-
console.log({ geo })
171+
delete geo.utc_offset;
172+
delete geo.gmt_offset;
174173
let error = assert(geo, expected, `fastly.getGeolocationForIpAddress('2607:f0d0:1002:51::4') == expected`)
175174
if (error) { return error }
176175
return pass()
177176
});
178177
routes.set("/fastly/getgeolocationforipaddress/parameter-shortened-ipv6-string", async () => {
179178
let geo = fastly.getGeolocationForIpAddress('2607:f0d0:1002:0051:0:0:0:0004')
179+
delete geo.utc_offset;
180+
delete geo.gmt_offset;
180181
let error = assert(geo, expected, `fastly.getGeolocationForIpAddress('2607:f0d0:1002:0051:0:0:0:0004') == expected`)
181182
if (error) { return error }
182183
return pass()
183184
});
184185
routes.set("/fastly/getgeolocationforipaddress/parameter-expanded-ipv6-string", async () => {
185186
let geo = fastly.getGeolocationForIpAddress('2607:f0d0:1002:0051:0000:0000:0000:0004')
187+
delete geo.utc_offset;
188+
delete geo.gmt_offset;
186189
let error = assert(geo, expected, `fastly.getGeolocationForIpAddress('2607:f0d0:1002:0051:0000:0000:0000:0004') == expected`)
187190
if (error) { return error }
188191
return pass()
189192
});
190193
// TODO: Uncomment these tests once IPv4-in-6 is working in ipll
191194
// routes.set("/fastly/getgeolocationforipaddress/parameter-dual-ipv4-ipv6-string", async () => {
192195
// let geo = fastly.getGeolocationForIpAddress('::FFFF:2.216.196.179')
196+
// delete geo.utc_offset;
197+
// delete geo.gmt_offset;
193198
// let error = assert(geo, expected, `fastly.getGeolocationForIpAddress('::2.216.196.179') == expected`)
194199
// if (error) { return error }
195200
// return pass()
196201
// });
197202

198203
routes.set("/fastly/getgeolocationforipaddress/called-unbound", async () => {
199204
let geo = fastly.getGeolocationForIpAddress.call(undefined, '2607:f0d0:1002:0051:0000:0000:0000:0004')
205+
delete geo.utc_offset;
206+
delete geo.gmt_offset;
200207
let error = assert(geo, expected, `fastly.getGeolocationForIpAddress.call(undefined, '2607:f0d0:1002:0051:0000:0000:0000:0004') == expected`)
201208
if (error) { return error }
202209
return pass()

0 commit comments

Comments
 (0)