refactor console to extend from BuiltinNoConstructor class

Author: Jake Champion

c-dependencies/js-compute-runtime/builtins/console.cpp

@@ -1,6 +1,7 @@
 #include "console.h"
 
-namespace Console {
+namespace builtins {
+
 template <const char *prefix, uint8_t prefix_len>
 static bool console_out(JSContext *cx, unsigned argc, JS::Value *vp) {
   JS::CallArgs args = CallArgsFromVp(argc, vp);
@@ -32,20 +33,22 @@ static constexpr char PREFIX_INFO[] = "Info";
 static constexpr char PREFIX_WARN[] = "Warn";
 static constexpr char PREFIX_ERROR[] = "Error";
 
-const JSFunctionSpec methods[] = {
+const JSFunctionSpec Console::methods[] = {
     JS_FN("log", (console_out<PREFIX_LOG, 3>), 1, JSPROP_ENUMERATE),
     JS_FN("debug", (console_out<PREFIX_DEBUG, 5>), 1, JSPROP_ENUMERATE),
     JS_FN("info", (console_out<PREFIX_INFO, 4>), 1, JSPROP_ENUMERATE),
     JS_FN("warn", (console_out<PREFIX_WARN, 4>), 1, JSPROP_ENUMERATE),
     JS_FN("error", (console_out<PREFIX_ERROR, 5>), 1, JSPROP_ENUMERATE),
     JS_FS_END};
 
-bool create(JSContext *cx, JS::HandleObject global) {
+const JSPropertySpec Console::properties[] = {JS_PS_END};
+
+bool Console::create(JSContext *cx, JS::HandleObject global) {
   JS::RootedObject console(cx, JS_NewPlainObject(cx));
   if (!console)
     return false;
   if (!JS_DefineProperty(cx, global, "console", console, JSPROP_ENUMERATE))
     return false;
   return JS_DefineFunctions(cx, console, methods);
 }
-} // namespace Console
+} // namespace builtins

c-dependencies/js-compute-runtime/builtins/console.h

@@ -3,8 +3,19 @@
 
 #include "builtin.h"
 
-namespace Console {
-bool create(JSContext *cx, JS::HandleObject global);
-}
+namespace builtins {
+
+class Console : public BuiltinNoConstructor<Console> {
+private:
+public:
+  static constexpr const char *class_name = "Console";
+  enum Slots { Count };
+  static const JSFunctionSpec methods[];
+  static const JSPropertySpec properties[];
+
+  static bool create(JSContext *cx, JS::HandleObject global);
+};
+
+} // namespace builtins
 
 #endif

c-dependencies/js-compute-runtime/js-compute-builtins.cpp

@@ -4887,7 +4887,7 @@ bool define_fastly_sys(JSContext *cx, HandleObject global) {
 
   if (!builtins::Fastly::create(cx, global))
     return false;
-  if (!Console::create(cx, global))
+  if (!builtins::Console::create(cx, global))
     return false;
   if (!builtins::Crypto::create(cx, global))
     return false;