Skip to content

Commit e17cdfd

Browse files
authored
fix: Bump to spidermonkey 110, and viceroy 0.3.5 (#420)
* Bump ci vicroy to 0.3.5 * Bump spidermonkey * Update calls to JS_InitClass
1 parent ce5c4bb commit e17cdfd

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ defaults:
1010
run:
1111
shell: bash
1212
env:
13-
viceroy_version: 0.3.2
13+
viceroy_version: 0.3.5
1414

1515
jobs:
1616
build:
@@ -100,7 +100,7 @@ jobs:
100100
matrix:
101101
include:
102102
- crate: viceroy
103-
version: 0.3.2 # Note: workflow-level env vars can't be used in matrix definitions
103+
version: 0.3.5 # Note: workflow-level env vars can't be used in matrix definitions
104104
options: ""
105105
runs-on: ubuntu-latest
106106
steps:

c-dependencies/js-compute-runtime/builtin.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@
5454
\
5555
bool init_class_impl(JSContext *cx, JS::HandleObject global, \
5656
JS::HandleObject parent_proto = nullptr) { \
57-
proto_obj.init(cx, JS_InitClass(cx, global, parent_proto, &class_, constructor, ctor_length, \
58-
properties, methods, nullptr, nullptr)); \
57+
proto_obj.init(cx, JS_InitClass(cx, global, &class_, parent_proto, #cls, constructor, \
58+
ctor_length, properties, methods, nullptr, nullptr)); \
5959
return proto_obj; \
6060
};
6161

@@ -182,9 +182,9 @@ template <typename Impl> class BuiltinImpl {
182182

183183
static bool init_class_impl(JSContext *cx, JS::HandleObject global,
184184
JS::HandleObject parent_proto = nullptr) {
185-
proto_obj.init(cx, JS_InitClass(cx, global, parent_proto, &class_, Impl::constructor,
186-
Impl::ctor_length, Impl::properties, Impl::methods, nullptr,
187-
nullptr));
185+
proto_obj.init(cx, JS_InitClass(cx, global, &class_, parent_proto, Impl::class_name,
186+
Impl::constructor, Impl::ctor_length, Impl::properties,
187+
Impl::methods, nullptr, nullptr));
188188

189189
return proto_obj != nullptr;
190190
}

0 commit comments

Comments
 (0)