StarlingMonkey WPT tests (#810)

Co-authored-by: Trevor Elliott <[email protected]>

Author: Guy Bedford

.github/workflows/starlingmonkey.yml

@@ -57,7 +57,7 @@ jobs:
       if: steps.cache-crate.outputs.cache-hit != 'true'
 
   run_wpt:
-    if: github.ref != 'refs/heads/main' && false
+    if: github.ref != 'refs/heads/main'
     name: Run Web Platform Tests
     needs: [build, ensure_cargo_installs]
     runs-on: ubuntu-latest
@@ -107,7 +107,7 @@ jobs:
 
     - name: Run tests
       timeout-minutes: 20
-      run: node ./tests/wpt-harness/run-wpt.mjs --starlingmonkey -vv
+      run: node ./tests/wpt-harness/run-wpt.mjs -vv
 
   sdktest:
     if: github.ref != 'refs/heads/main'

runtime/StarlingMonkey

@@ -2879,9 +2879,7 @@ bool Response::constructor(JSContext *cx, unsigned argc, JS::Value *vp) {
       return false;
     }
     if (!statusText_val.isUndefined()) {
-      auto statusText_str = core::encode(cx, statusText_val);
-      std::string s(statusText_str.ptr.get(), statusText_str.len);
-      auto status_text_result = convertJSValueToByteString(cx, s);
+      auto status_text_result = convertJSValueToByteString(cx, statusText_val);
       if (status_text_result.isErr()) {
         JS_ReportErrorNumberASCII(cx, FastlyGetErrorMessage, nullptr,
                                   JSMSG_RESPONSE_CONSTRUCTOR_INVALID_STATUS_TEXT);

runtime/fastly/builtins/fetch/request-response.cpp

@@ -1,3 +1,4 @@
+#include "../StarlingMonkey/builtins/web/performance.h"
 #include "./builtins/fetch-event.h"
 #include "./host-api/fastly.h"
 #include "./host-api/host_api_fastly.h"
@@ -14,14 +15,16 @@ namespace fastly::runtime {
 
 api::Engine *ENGINE;
 
+// Install corresponds to Wizer time, so we configure the engine here
 bool install(api::Engine *engine) {
   ENGINE = engine;
+  engine->enable_module_mode(false);
   return true;
 }
 
 void handle_incoming(host_api::Request req) {
-  // TODO(GB): reimplement
-  // builtins::Performance::timeOrigin.emplace(std::chrono::high_resolution_clock::now());
+  builtins::web::performance::Performance::timeOrigin.emplace(
+      std::chrono::high_resolution_clock::now());
 
   double total_compute = 0;
   auto start = system_clock::now();

runtime/fastly/handler.cpp

@@ -33,15 +33,15 @@ void sleep_until(uint64_t time_ns, uint64_t now) {
   }
 }
 
-size_t api::AsyncTask::select(std::vector<api::AsyncTask *> *tasks) {
-  size_t tasks_len = tasks->size();
+size_t api::AsyncTask::select(std::vector<api::AsyncTask *> &tasks) {
+  size_t tasks_len = tasks.size();
   std::vector<fastly_compute_at_edge_async_io_handle_t> handles;
   handles.reserve(tasks_len);
   uint64_t now = 0;
   uint64_t soonest_deadline = 0;
   size_t soonest_deadline_idx = -1;
   for (size_t idx = 0; idx < tasks_len; ++idx) {
-    auto *task = tasks->at(idx);
+    auto *task = tasks.at(idx);
     uint64_t deadline = task->deadline();
     // Select for completed task deadlines before performing the task select host call.
     if (deadline > 0) {
@@ -86,7 +86,7 @@ size_t api::AsyncTask::select(std::vector<api::AsyncTask *> *tasks) {
       // non-timer task.
       size_t task_idx = 0;
       for (size_t idx = 0; idx < tasks_len; ++idx) {
-        if (tasks->at(idx)->id() != NEVER_HANDLE) {
+        if (tasks.at(idx)->id() != NEVER_HANDLE) {
           if (ret.val == task_idx) {
             return idx;
           }
@@ -1819,11 +1819,13 @@ const std::optional<std::string> FastlySendError::message() const {
   /// The system encountered a DNS error when trying to find an IP address for the backend
   /// hostname. The fields dns_error_rcode and dns_error_info_code may be set in the
   /// send_error_detail.
-  // TODO(GB): reenable DNS error codes
   case dns_error: {
-    return "DNS error (rcode={}, info_code={})" /*, this->dns_error_rcode,
-                        this->dns_error_info_code*/
-        ;
+    // allocate maximum len of error message
+    char buf[34 + 10 + 1];
+    int written = snprintf(buf, sizeof(buf), "DNS error (rcode=%d, info_code=%d)",
+                           this->dns_error_rcode, this->dns_error_info_code);
+    MOZ_ASSERT(written > 34);
+    return std::string(buf, written);
   }
   /// The system cannot determine which backend to use, or the specified backend was invalid.
   case destination_not_found: {

runtime/fastly/host-api/host_api.cpp

@@ -7,7 +7,7 @@ edition = "2018"
 crate-type = ["staticlib"]
 
 [dependencies]
-url = "2.5.0"
+url = "2.5.2"
 
 [profile.release]
 lto = true

runtime/js-compute-runtime/rust-url/Cargo.lock

@@ -564,7 +564,7 @@
     "status": "PASS"
   },
   "URL: Setting <foo://somehost/some/path>.pathname = '' Non-special URLs can have their paths erased": {
-    "status": "FAIL"
+    "status": "PASS"
   },
   "URL: Setting <foo:///some/path>.pathname = '' Non-special URLs with an empty host can have their paths erased": {
     "status": "FAIL"