Merge pull request cms-sw#43274 from Dr15Jones/SonicUseExternalFailureException

cmsbuild · web-flow · commit 23517a312f05 · 2023-11-17T00:31:04.000+01:00
Change Sonic to use ExternalFailure exception
diff --git a/HeterogeneousCore/SonicCore/src/SonicClientBase.cc b/HeterogeneousCore/SonicCore/src/SonicClientBase.cc
@@ -54,8 +54,8 @@ void SonicClientBase::finish(bool success, std::exception_ptr eptr) {
     }
     //prepare an exception if exceeded
     else {
-      cms::Exception ex("SonicCallFailed");
-      ex << "call failed after max " << tries_ << " tries";
+      edm::Exception ex(edm::errors::ExternalFailure);
+      ex << "SonicCallFailed: call failed after max " << tries_ << " tries";
       eptr = make_exception_ptr(ex);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -54,8 +54,8 @@ void SonicClientBase::finish(bool success, std::exception_ptr eptr) {`
`54`	`54`	`}`
`55`	`55`	`//prepare an exception if exceeded`
`56`	`56`	`else {`
`57`		`- cms::Exception ex("SonicCallFailed");`
`58`		`- ex << "call failed after max " << tries_ << " tries";`
	`57`	`+ edm::Exception ex(edm::errors::ExternalFailure);`
	`58`	`+ ex << "SonicCallFailed: call failed after max " << tries_ << " tries";`
`59`	`59`	`eptr = make_exception_ptr(ex);`
`60`	`60`	`}`
`61`	`61`	`}`