Bug fixes from geometry validation

Author: cvuosalo

Geometry/EcalCommonData/plugins/dd4hep/DDEcalBarrelNewAlgo.cc

@@ -449,6 +449,11 @@ namespace {
     return ns.rotation(ns.prepend(nam));
   }
 
+  const Rotation3D& myrot(cms::DDNamespace& ns, const string& nam, const Rotation3D& r) {
+    ns.addRotation(nam, r);
+    return ns.rotation(ns.prepend(nam));
+  }
+
   Solid mytrap(const std::string& nam, const EcalTrapezoidParameters& t) {
 #ifdef EDM_ML_DEBUG
     edm::LogVerbatim("EBGeom") << nam << " Trap " << convertRadToDeg(t.theta()) << ":" << convertRadToDeg(t.phi())
@@ -1169,10 +1174,12 @@ static long algorithm(dd4hep::Detector& /* description */, cms::DDParsingContext
               const double yy(radius * sin(phi));
               const double xx(radius * cos(phi));
               ++ptmCopy;
-              xilyLog.placeVolume(
-                  ilyPTMLog,
-                  ptmCopy,
-                  Transform3D(RotationZ(phi), Position(xx, yy, ily.vecIlyPTMZ[ilyPTM] - ilyLengthHalf)));
+              xilyLog.placeVolume(ilyPTMLog,
+                                  ptmCopy,
+                                  Transform3D(myrot(ns,
+                                                    std::string(ilyPTMLog.name()) + "_rot" + std::to_string(ptmCopy),
+                                                    Rotation3D(RotationZ(phi))),
+                                              Position(xx, yy, ily.vecIlyPTMZ[ilyPTM] - ilyLengthHalf)));
 #ifdef EDM_ML_DEBUG
               edm::LogVerbatim("EBGeomX")
                   << ilyPTMLog.name() << ":" << ptmCopy << " positioned in " << xilyLog.name() << " at ("
@@ -1189,10 +1196,13 @@ static long algorithm(dd4hep::Detector& /* description */, cms::DDParsingContext
               const double yy(radius * sin(phi));
               const double xx(radius * cos(phi));
               ++fanOutCopy;
-              xilyLog.placeVolume(ilyFanOutLog,
-                                  fanOutCopy,
-                                  Transform3D(RotationZ(phi) * RotationY(180._deg),
-                                              Position(xx, yy, ily.vecIlyFanOutZ[ilyFO] - ilyLengthHalf)));
+              xilyLog.placeVolume(
+                  ilyFanOutLog,
+                  fanOutCopy,
+                  Transform3D(myrot(ns,
+                                    std::string(ilyFanOutLog.name()) + "_rot" + std::to_string(fanOutCopy),
+                                    RotationZ(phi) * RotationY(180._deg)),
+                              Position(xx, yy, ily.vecIlyFanOutZ[ilyFO] - ilyLengthHalf)));
 #ifdef EDM_ML_DEBUG
               edm::LogVerbatim("EBGeomX")
                   << ilyFanOutLog.name() << ":" << fanOutCopy << " positioned in " << xilyLog.name() << " at ("
@@ -1207,10 +1217,12 @@ static long algorithm(dd4hep::Detector& /* description */, cms::DDParsingContext
               const double yy(radius * sin(phi));
               const double xx(radius * cos(phi));
               ++femCopy;
-              xilyLog.placeVolume(
-                  ilyFEMLog,
-                  femCopy,
-                  Transform3D(RotationZ(phi), Position(xx, yy, ily.vecIlyFEMZ[ilyFEM] - ilyLengthHalf)));
+              xilyLog.placeVolume(ilyFEMLog,
+                                  femCopy,
+                                  Transform3D(myrot(ns,
+                                                    std::string(ilyFEMLog.name()) + "_rot" + std::to_string(femCopy),
+                                                    Rotation3D(RotationZ(phi))),
+                                              Position(xx, yy, ily.vecIlyFEMZ[ilyFEM] - ilyLengthHalf)));
 #ifdef EDM_ML_DEBUG
               edm::LogVerbatim("EBGeomX")
                   << ilyFEMLog.name() << ":" << femCopy << " positioned in " << xilyLog.name() << " at ("
@@ -1242,8 +1254,11 @@ static long algorithm(dd4hep::Detector& /* description */, cms::DDParsingContext
                 xilyLog.placeVolume(
                     ilyPipeLog[type],
                     copyNum[type],
-                    Transform3D(Rotation3D(ROOT::Math::AxisAngle(ROOT::Math::AxisAngle::XYZVector(xx, yy, 0), 90._deg)),
-                                Position(xx, yy, zz)));
+                    Transform3D(
+                        myrot(ns,
+                              std::string(ilyPipeLog[type].name()) + "_rot" + std::to_string(ly),
+                              Rotation3D(ROOT::Math::AxisAngle(ROOT::Math::AxisAngle::XYZVector(xx, yy, 0), 90._deg))),
+                        Position(xx, yy, zz)));
 #ifdef EDM_ML_DEBUG
                 edm::LogVerbatim("EBGeomX") << ilyPipeLog[type].name() << ":" << copyNum[type] << " positioned in "
                                             << xilyLog.name() << " at (" << cms::convert2mm(xx) << ","
@@ -1390,7 +1405,7 @@ static long algorithm(dd4hep::Detector& /* description */, cms::DDParsingContext
 
     Solid fawSolid = SubtractionSolid(fawSolid1,
                                       fawCutBox,
-                                      Transform3D(myrot(ns, fawCutName + "R", fawCutForm.getRotation()),
+                                      Transform3D(myrot(ns, fawCutName + "_rot", fawCutForm.getRotation()),
                                                   Position(fawCutForm.getTranslation().x(),
                                                            fawCutForm.getTranslation().y(),
                                                            fawCutForm.getTranslation().z())));
@@ -1413,7 +1428,7 @@ static long algorithm(dd4hep::Detector& /* description */, cms::DDParsingContext
         ns.assembly(alvWedge.hawRName),
         copyOne,
         Transform3D(
-            myrot(ns, alvWedge.hawRName + "R", hawRform.getRotation()),
+            myrot(ns, alvWedge.hawRName + "_rot", hawRform.getRotation()),
             Position(hawRform.getTranslation().x(), hawRform.getTranslation().y(), hawRform.getTranslation().z())));
 #ifdef EDM_ML_DEBUG
     edm::LogVerbatim("EBGeomX") << ns.assembly(alvWedge.hawRName).name() << ":" << copyOne << " positioned in "
@@ -1426,7 +1441,10 @@ static long algorithm(dd4hep::Detector& /* description */, cms::DDParsingContext
         ns.assembly(alvWedge.hawRName),
         copyTwo,
         Transform3D(
-            Rotation3D(1., 0., 0., 0., 1., 0., 0., 0., -1.) * RotationY(M_PI),  // rotate about Y after refl thru Z
+            myrot(
+                ns,
+                alvWedge.hawRName + "R2",
+                Rotation3D(1., 0., 0., 0., 1., 0., 0., 0., -1.) * RotationY(M_PI)),  // rotate about Y after refl thru Z
             Position(-hawRform.getTranslation().x(), -hawRform.getTranslation().y(), -hawRform.getTranslation().z())));
 #ifdef EDM_ML_DEBUG
     edm::LogVerbatim("EBGeomX") << ns.assembly(alvWedge.hawRName).name() << ":" << copyTwo << " positioned in "
@@ -1489,7 +1507,7 @@ static long algorithm(dd4hep::Detector& /* description */, cms::DDParsingContext
       ns.assembly(alvWedge.hawRName)
           .placeVolume(gridLog,
                        copyOne,
-                       Transform3D(myrot(ns, grid.name + "R", gridForm.getRotation()),
+                       Transform3D(myrot(ns, grid.name + "_rot", gridForm.getRotation()),
                                    Position(gridForm.getTranslation().x(),
                                             gridForm.getTranslation().y(),
                                             gridForm.getTranslation().z())));
@@ -1559,7 +1577,7 @@ static long algorithm(dd4hep::Detector& /* description */, cms::DDParsingContext
       );
 
       const string cryDDName(cry.name + sType);
-      Solid crySolid = mytrap(cry.name, trapCry);
+      Solid crySolid = mytrap(cryDDName, trapCry);
       Volume cryLog = Volume(cryDDName, crySolid, ns.material(cry.mat));
 
       //++++++++++++++++++++++++++++++++++  APD ++++++++++++++++++++++++++++++++++

Geometry/TrackerCommonData/data/PhaseI/v2/pixfwdInnerDiskZminus.xml

@@ -11,7 +11,7 @@
 <!-- support ring solids - refer to outer disk comments -->
 <Algorithm name="track:DDCutTubsFromPoints">
   <rParent name="pixfwdDisks:PixelForwardDiskZminus"/>
-  <String  name="SolidName"        value="PixelForwardInnerDiskOuterRing"/> 
+  <String  name="SolidName"        value="PixelForwardInnerDiskOuterRingZminus"/> 
   <String  name="Material"         value="pixfwdMaterials:C_C_InnerOuterRing"/> 
   <Numeric name="zPos"             value="[OuterRingZ]"/>
   <Numeric name="rMin"             value="[pixfwdSupportRingParameters:InnerDiskOuterRingRMin]"/>
@@ -22,7 +22,7 @@
 </Algorithm>
 <Algorithm name="track:DDCutTubsFromPoints">
   <rParent name="pixfwdDisks:PixelForwardDiskZminus"/>
-  <String  name="SolidName"        value="PixelForwardInnerDiskCFOuterRing"/> 
+  <String  name="SolidName"        value="PixelForwardInnerDiskCFOuterRingZminus"/> 
   <String  name="Material"         value="pixfwdMaterials:FPix_CFSkin_InnerOuterRing"/> 
   <Numeric name="zPos"             value="[OuterRingZ]"/>
   <Numeric name="rMin"             value="[pixfwdSupportRingParameters:InnerDiskOuterRingCFRMin]"/>
@@ -33,7 +33,7 @@
 </Algorithm>
 <Algorithm name="track:DDCutTubsFromPoints">
   <rParent name="pixfwdDisks:PixelForwardDiskZminus"/>
-  <String  name="SolidName"        value="PixelForwardInnerDiskInnerRing"/> 
+  <String  name="SolidName"        value="PixelForwardInnerDiskInnerRingZminus"/> 
   <String  name="Material"         value="pixfwdMaterials:C_C_InnerInnerRing"/> 
   <Numeric name="zPos"             value="[InnerRingZ]"/>
   <Numeric name="rMin"             value="[pixfwdSupportRingParameters:InnerDiskInnerRingRMin]"/>
@@ -44,7 +44,7 @@
 </Algorithm>
 <Algorithm name="track:DDCutTubsFromPoints">
   <rParent name="pixfwdDisks:PixelForwardDiskZminus"/>
-  <String  name="SolidName"        value="PixelForwardInnerDiskCFInnerRing"/> 
+  <String  name="SolidName"        value="PixelForwardInnerDiskCFInnerRingZminus"/> 
   <String  name="Material"         value="pixfwdMaterials:FPix_CFSkin_InnerInnerRing"/> 
   <Numeric name="zPos"             value="[InnerRingZ]"/>
   <Numeric name="rMin"             value="[pixfwdSupportRingParameters:InnerDiskInnerRingCFRMin]"/>

Geometry/TrackerCommonData/data/PhaseI/v2/pixfwdInnerDiskZplus.xml

@@ -11,7 +11,7 @@
 <!-- support ring solids - refer to outer disk comments -->
 <Algorithm name="track:DDCutTubsFromPoints">
   <rParent name="pixfwdDisks:PixelForwardDiskZplus"/>
-  <String  name="SolidName"        value="PixelForwardInnerDiskOuterRing"/> 
+  <String  name="SolidName"        value="PixelForwardInnerDiskOuterRingZplus"/> 
   <String  name="Material"         value="pixfwdMaterials:C_C_InnerOuterRing"/> 
   <Numeric name="zPos"             value="[OuterRingZ]"/>
   <Numeric name="rMin"             value="[pixfwdSupportRingParameters:InnerDiskOuterRingRMin]"/>
@@ -22,7 +22,7 @@
 </Algorithm>
 <Algorithm name="track:DDCutTubsFromPoints">
   <rParent name="pixfwdDisks:PixelForwardDiskZplus"/>
-  <String  name="SolidName"        value="PixelForwardInnerDiskCFOuterRing"/> 
+  <String  name="SolidName"        value="PixelForwardInnerDiskCFOuterRingZplus"/> 
   <String  name="Material"         value="pixfwdMaterials:FPix_CFSkin_InnerOuterRing"/> 
   <Numeric name="zPos"             value="[OuterRingZ]"/>
   <Numeric name="rMin"             value="[pixfwdSupportRingParameters:InnerDiskOuterRingCFRMin]"/>
@@ -33,7 +33,7 @@
 </Algorithm>
 <Algorithm name="track:DDCutTubsFromPoints">
   <rParent name="pixfwdDisks:PixelForwardDiskZplus"/>
-  <String  name="SolidName"        value="PixelForwardInnerDiskInnerRing"/> 
+  <String  name="SolidName"        value="PixelForwardInnerDiskInnerRingZplus"/> 
   <String  name="Material"         value="pixfwdMaterials:C_C_InnerInnerRing"/> 
   <Numeric name="zPos"             value="[InnerRingZ]"/>
   <Numeric name="rMin"             value="[pixfwdSupportRingParameters:InnerDiskInnerRingRMin]"/>
@@ -44,7 +44,7 @@
 </Algorithm>
 <Algorithm name="track:DDCutTubsFromPoints">
   <rParent name="pixfwdDisks:PixelForwardDiskZplus"/>
-  <String  name="SolidName"        value="PixelForwardInnerDiskCFInnerRing"/> 
+  <String  name="SolidName"        value="PixelForwardInnerDiskCFInnerRingZplus"/> 
   <String  name="Material"         value="pixfwdMaterials:FPix_CFSkin_InnerInnerRing"/> 
   <Numeric name="zPos"             value="[InnerRingZ]"/>
   <Numeric name="rMin"             value="[pixfwdSupportRingParameters:InnerDiskInnerRingCFRMin]"/>

Geometry/TrackerCommonData/data/PhaseI/v2/pixfwdOuterDiskZminus.xml

@@ -20,7 +20,7 @@
 --> 
 <Algorithm name="track:DDCutTubsFromPoints">
   <rParent name="pixfwdDisks:PixelForwardDiskZminus"/>
-  <String  name="SolidName"        value="PixelForwardOuterDiskOuterRing"/> 
+  <String  name="SolidName"        value="PixelForwardOuterDiskOuterRingZminus"/> 
   <String  name="Material"         value="pixfwdMaterials:C_C_OuterOuterRing"/> 
   <Numeric name="zPos"             value="[OuterRingZ]"/>
   <Numeric name="rMin"             value="[pixfwdSupportRingParameters:OuterDiskOuterRingRMin]"/>
@@ -31,7 +31,7 @@
 </Algorithm>
 <Algorithm name="track:DDCutTubsFromPoints">
   <rParent name="pixfwdDisks:PixelForwardDiskZminus"/>
-  <String  name="SolidName"        value="PixelForwardOuterDiskCFOuterRing"/> 
+  <String  name="SolidName"        value="PixelForwardOuterDiskCFOuterRingZminus"/> 
   <String  name="Material"         value="pixfwdMaterials:FPix_CFSkin_OuterOuterRing"/> 
   <Numeric name="zPos"             value="[OuterRingZ]"/>
   <Numeric name="rMin"             value="[pixfwdSupportRingParameters:OuterDiskOuterRingCFRMin]"/>
@@ -42,7 +42,7 @@
 </Algorithm>
 <Algorithm name="track:DDCutTubsFromPoints">
   <rParent name="pixfwdDisks:PixelForwardDiskZminus"/>
-  <String  name="SolidName"        value="PixelForwardOuterDiskInnerRing"/> 
+  <String  name="SolidName"        value="PixelForwardOuterDiskInnerRingZminus"/> 
   <String  name="Material"         value="pixfwdMaterials:C_C_OuterInnerRing"/> 
   <Numeric name="zPos"             value="[InnerRingZ]"/>
   <Numeric name="rMin"             value="[pixfwdSupportRingParameters:OuterDiskInnerRingRMin]"/>
@@ -53,7 +53,7 @@
 </Algorithm>
 <Algorithm name="track:DDCutTubsFromPoints">
   <rParent name="pixfwdDisks:PixelForwardDiskZminus"/>
-  <String  name="SolidName"        value="PixelForwardOuterDiskCFInnerRing"/> 
+  <String  name="SolidName"        value="PixelForwardOuterDiskCFInnerRingZminus"/> 
   <String  name="Material"         value="pixfwdMaterials:FPix_CFSkin_OuterInnerRing"/> 
   <Numeric name="zPos"             value="[InnerRingZ]"/>
   <Numeric name="rMin"             value="[pixfwdSupportRingParameters:OuterDiskInnerRingCFRMin]"/>

Geometry/TrackerCommonData/data/PhaseI/v2/pixfwdOuterDiskZplus.xml

@@ -20,7 +20,7 @@
 --> 
 <Algorithm name="track:DDCutTubsFromPoints">
   <rParent name="pixfwdDisks:PixelForwardDiskZplus"/>
-  <String  name="SolidName"        value="PixelForwardOuterDiskOuterRing"/> 
+  <String  name="SolidName"        value="PixelForwardOuterDiskOuterRingZplus"/> 
   <String  name="Material"         value="pixfwdMaterials:C_C_OuterOuterRing"/> 
   <Numeric name="zPos"             value="[OuterRingZ]"/>
   <Numeric name="rMin"             value="[pixfwdSupportRingParameters:OuterDiskOuterRingRMin]"/>
@@ -31,7 +31,7 @@
 </Algorithm>
 <Algorithm name="track:DDCutTubsFromPoints">
   <rParent name="pixfwdDisks:PixelForwardDiskZplus"/>
-  <String  name="SolidName"        value="PixelForwardOuterDiskCFOuterRing"/> 
+  <String  name="SolidName"        value="PixelForwardOuterDiskCFOuterRingZplus"/> 
   <String  name="Material"         value="pixfwdMaterials:FPix_CFSkin_OuterOuterRing"/> 
   <Numeric name="zPos"             value="[OuterRingZ]"/>
   <Numeric name="rMin"             value="[pixfwdSupportRingParameters:OuterDiskOuterRingCFRMin]"/>
@@ -42,7 +42,7 @@
 </Algorithm>
 <Algorithm name="track:DDCutTubsFromPoints">
   <rParent name="pixfwdDisks:PixelForwardDiskZplus"/>
-  <String  name="SolidName"        value="PixelForwardOuterDiskInnerRing"/> 
+  <String  name="SolidName"        value="PixelForwardOuterDiskInnerRingZplus"/> 
   <String  name="Material"         value="pixfwdMaterials:C_C_OuterInnerRing"/> 
   <Numeric name="zPos"             value="[InnerRingZ]"/>
   <Numeric name="rMin"             value="[pixfwdSupportRingParameters:OuterDiskInnerRingRMin]"/>
@@ -53,7 +53,7 @@
 </Algorithm>
 <Algorithm name="track:DDCutTubsFromPoints">
   <rParent name="pixfwdDisks:PixelForwardDiskZplus"/>
-  <String  name="SolidName"        value="PixelForwardOuterDiskCFInnerRing"/> 
+  <String  name="SolidName"        value="PixelForwardOuterDiskCFInnerRingZplus"/> 
   <String  name="Material"         value="pixfwdMaterials:FPix_CFSkin_OuterInnerRing"/> 
   <Numeric name="zPos"             value="[InnerRingZ]"/>
   <Numeric name="rMin"             value="[pixfwdSupportRingParameters:OuterDiskInnerRingCFRMin]"/>

Geometry/TrackerCommonData/plugins/dd4hep/DDTECModuleAlgo.cc

@@ -409,6 +409,7 @@ static long algorithm(Detector& /* description */, cms::DDParsingContext& ctxt,
     dy = 0.5 * pitchThick;
     dz = 0.5 * pitchHeight;
     solid = Box(dx, dy, dz);
+    name += "Box";
     ns.addSolidNS(name, solid);
     edm::LogVerbatim("TECGeom") << "Solid:\t" << name << " " << solid.name() << " Box made of " << pitchMat
                                 << " of dimensions " << dx << ", " << dy << ", " << dz;
@@ -419,6 +420,7 @@ static long algorithm(Detector& /* description */, cms::DDParsingContext& ctxt,
     bl2 = 0.5 * pitchHeight - 0.5 * dz * sin(detTilt);
     thet = atan((bl1 - bl2) / (2. * dz));
     solid = Trap(dz, thet, 0, h1, bl1, bl1, 0, h1, bl2, bl2, 0);
+    name += "Trap";
     ns.addSolidNS(name, solid);
     edm::LogVerbatim("TECGeom") << "Solid:\t" << name << " " << solid.name() << " Trap made of " << pitchMat
                                 << " of dimensions " << dz << ", " << convertRadToDeg(thet) << ", 0, " << h1 << ", "

Geometry/TrackerCommonData/plugins/dd4hep/DDTIBLayerAlgo.cc

@@ -252,7 +252,7 @@ static long algorithm(Detector& /* description */, cms::DDParsingContext& contex
     double dz = 0.5 * layerL - 2. * fillerDz;
     double _rmi = std::min(rin + 0.5 * dd4hep::mm, rout - 0.5 * dd4hep::mm);
     double _rma = std::max(rin + 0.5 * dd4hep::mm, rout - 0.5 * dd4hep::mm);
-    solid = ns.addSolidNS(name, Tube(_rmi, _rma, dz, -0.5 * width, width));
+    solid = ns.addSolidNS(name, Tube(_rmi, _rma, dz, -0.5 * width, 0.5 * width));
     LogDebug("TIBGeom") << solid.name() << " Tubs made of " << ribMat << " from " << -0.5 * convertRadToDeg(width)
                         << " to " << 0.5 * convertRadToDeg(width) << " with Rin " << rin + 0.5 * dd4hep::mm << " Rout "
                         << rout - 0.5 * dd4hep::mm << " ZHalf " << dz;
@@ -490,7 +490,7 @@ static long algorithm(Detector& /* description */, cms::DDParsingContext& contex
         break;
     }
 
-    solid = ns.addSolidNS(name, Tube(pillarRin, pillarRout, pillarDz, -pillarDPhi, 2. * pillarDPhi));
+    solid = ns.addSolidNS(name, Tube(pillarRin, pillarRout, pillarDz, -pillarDPhi, pillarDPhi));
     Volume Pillar = ns.addVolumeNS(Volume(name, solid, ns.material(pillarMaterial)));
     LogDebug("TIBGeom") << solid.name() << " Tubs made of " << pillarMaterial << " from " << -pillarDPhi << " to "
                         << pillarDPhi << " with Rin " << pillarRin << " Rout " << pillarRout << " ZHalf " << pillarDz;