Merge pull request cms-sw#42675 from missirol/devel_hltFilterLabel

make `trigger::TriggerEvent::filterLabel` return `std::string_view`

Author: cmsbuild

Calibration/HcalAlCaRecoProducers/plugins/AlCaHcalIsotrkProducer.cc

@@ -654,10 +654,10 @@ void AlCaHcalIsotrkProducer::produce(edm::Event& iEvent, edm::EventSetup const&
             //loop over all trigger filters in event (i.e. filters passed)
             for (unsigned int ifilter = 0; ifilter < triggerEvent.sizeFilters(); ++ifilter) {
               std::vector<int> Keys;
-              std::string label = triggerEvent.filterTag(ifilter).label();
+              auto const label = triggerEvent.filterLabel(ifilter);
               //loop over keys to objects passing this filter
               for (unsigned int imodule = 0; imodule < moduleLabels.size(); imodule++) {
-                if (label.find(moduleLabels[imodule]) != std::string::npos) {
+                if (label.find(moduleLabels[imodule]) != label.npos) {
 #ifdef EDM_ML_DEBUG
                   if (debug_)
                     edm::LogVerbatim("HcalIsoTrack") << "FilterName " << label;

DataFormats/HLTReco/interface/TriggerEvent.h

@@ -16,6 +16,7 @@
 #include "FWCore/Utilities/interface/InputTag.h"
 #include "DataFormats/Common/interface/traits.h"
 #include <string>
+#include <string_view>
 #include <vector>
 #include <cassert>
 
@@ -109,10 +110,10 @@ namespace trigger {
       return edm::InputTag(triggerFilters_.at(index).filterTag_);
     }
     const std::string& filterTagEncoded(trigger::size_type index) const { return triggerFilters_.at(index).filterTag_; }
-    std::string filterLabel(trigger::size_type index) const {
-      const std::string& tag = triggerFilters_.at(index).filterTag_;
-      std::string::size_type idx = tag.find(':');
-      return (idx == std::string::npos ? tag : tag.substr(0, idx));
+    std::string_view filterLabel(trigger::size_type index) const {
+      std::string_view tag = triggerFilters_.at(index).filterTag_;
+      auto const idx = tag.find(':');
+      return (idx == tag.npos ? tag : tag.substr(0, idx));
     }
     const Vids& filterIds(trigger::size_type index) const { return triggerFilters_.at(index).filterIds_; }
     const Keys& filterKeys(trigger::size_type index) const { return triggerFilters_.at(index).filterKeys_; }

PhysicsTools/PatAlgos/plugins/PATTriggerProducer.cc

@@ -743,7 +743,7 @@ void PATTriggerProducer::produce(Event& iEvent, const EventSetup& iSetup) {
       auto triggerFilters = std::make_unique<TriggerFilterCollection>();
       triggerFilters->reserve(sizeFilters);
       for (size_t iF = 0; iF < sizeFilters; ++iF) {
-        const std::string nameFilter(handleTriggerEvent->filterTag(iF).label());
+        const std::string nameFilter(handleTriggerEvent->filterLabel(iF));
         const trigger::Keys& keys = handleTriggerEvent->filterKeys(iF);  // not cached
         const trigger::Vids& types = handleTriggerEvent->filterIds(iF);  // not cached
         TriggerFilter triggerFilter(nameFilter);