[ANALYSIS] Apply code-checks-all with misc-definitions-in-headers additional check

Author: smuzaffar

JetMETCorrections/MCJet/bin/Utilities.h

@@ -146,7 +146,7 @@ std::vector<T> CommandLine::getVector(const std::string& name) {
     std::string::size_type pos;
     if (!tmp.empty()) {
       do {
-        pos = tmp.find(",");
+        pos = tmp.find(',');
         std::stringstream ss;
         ss << tmp.substr(0, pos);
         tmp.erase(0, pos + 1);
@@ -189,7 +189,7 @@ bool CommandLine::parse(int argc, char** argv) {
 
   for (int i = 1; i < argc; i++) {
     std::string opt = argv[i];
-    if (0 != opt.find("-")) {
+    if (0 != opt.find('-')) {
       if (i == 1) {
         bool success = parse_file(opt);
         if (!success)
@@ -210,7 +210,7 @@ bool CommandLine::parse(int argc, char** argv) {
     i++;
     if (i < argc - 1) {
       next = argv[i + 1];
-      while (next.find("-") != 0) {
+      while (next.find('-') != 0) {
         _options[opt].first += "," + next;
         i++;
         next = (i < argc - 1) ? argv[i + 1] : "-";
@@ -254,7 +254,7 @@ void CommandLine::print() {
       std::string::size_type length = tmp.length();
       std::string::size_type pos;
       do {
-        pos = tmp.find(",");
+        pos = tmp.find(',');
         if (tmp.length() == length) {
           std::cout << std::setiosflags(std::ios::left) << std::setw(22) << it->first
                     << std::resetiosflags(std::ios::left) << std::setw(3) << "=" << std::setiosflags(std::ios::right)
@@ -308,8 +308,8 @@ bool CommandLine::parse_file(const std::string& file_name) {
       last_token = "";
       value = "";
     } else if (!last_token.empty()) {
-      if (last_token.find("\"") == 0) {
-        if (last_token.rfind("\"") == last_token.length() - 1) {
+      if (last_token.find('\"') == 0) {
+        if (last_token.rfind('\"') == last_token.length() - 1) {
           last_token = last_token.substr(1, last_token.length() - 2);
           value += (!value.empty()) ? "," + last_token : last_token;
           last_token = token;
@@ -324,7 +324,7 @@ bool CommandLine::parse_file(const std::string& file_name) {
     ss >> token;
   }
   if (!last_token.empty()) {
-    if (last_token.find("\"") == 0 && last_token.rfind("\"") == last_token.length() - 1)
+    if (last_token.find('\"') == 0 && last_token.rfind('\"') == last_token.length() - 1)
       last_token = last_token.substr(1, last_token.length() - 2);
     value += (!value.empty()) ? "," + last_token : last_token;
   }

MuonAnalysis/MomentumScaleCalibration/plugins/Histograms.h

@@ -28,10 +28,12 @@
 #include "TCanvas.h"
 
 #include "TLorentzVector.h"
-#include <vector>
-#include <string>
-#include <iostream>
+#include <memory>
+
 #include "TMath.h"
+#include <iostream>
+#include <string>
+        #include <vector>
 
 class Histograms {
 public:
@@ -2288,8 +2290,8 @@ class HMassResolutionVSPart : public Histograms {
     }
 
     // single particles histograms
-    muMinus.reset(new HDelta("muMinus"));
-    muPlus.reset(new HDelta("muPlus"));
+    muMinus = std::make_unique<HDelta>("muMinus");
+    muPlus = std::make_unique<HDelta>("muPlus");
   }
 
   ~HMassResolutionVSPart() override {

PhysicsTools/UtilAlgos/interface/CachingVariable.h

@@ -333,7 +333,7 @@ class ExpressionVariable : public CachingVariable {
         //do something fancy for multiple variable from one PSet
         std::vector<std::string> vars = arg.iConfig.getParameter<std::vector<std::string> >("vars");
         for (unsigned int v = 0; v != vars.size(); ++v) {
-          unsigned int sep = vars[v].find(":");
+          unsigned int sep = vars[v].find(':');
           std::string name = vars[v].substr(0, sep);
           std::string expr = vars[v].substr(sep + 1);
 

PhysicsTools/UtilAlgos/interface/StringBasedNTupler.h

@@ -100,12 +100,12 @@ class StringLeaveHelper {
     //empty vector if product not found
     if (oH.failedToGet()) {
       edm::LogError("StringBranchHelper") << "cannot open: " << B.src();
-      value_.reset(new std::vector<float>(0));
+      value_ = std::make_unique<std::vector<float>>(0);
     } else {
       //parser for the object expression
       StringObjectFunction<Object> expr(B.expr());
       //allocate enough memory for the data holder
-      value_.reset(new std::vector<float>(1));
+      value_ = std::make_unique<std::vector<float>>(1);
       try {
         (*value_)[0] = (expr)(*oH);
       } catch (...) {
@@ -138,12 +138,12 @@ class StringBranchHelper {
       if (!(iEvent.isRealData() && B.className() == "reco::GenParticle")) {  //don't output genparticle error in data
         edm::LogError("StringBranchHelper") << "cannot open: " << B.src() << "  " << B.className();
       }
-      value_.reset(new std::vector<float>());
+      value_ = std::make_unique<std::vector<float>>();
     } else {
       //parser for the object expression
       StringObjectFunction<Object> expr(B.expr());
       //allocate enough memory for the data holder
-      value_.reset(new std::vector<float>());
+      value_ = std::make_unique<std::vector<float>>();
       value_->reserve(oH->size());
 
       StringCutObjectSelector<Object>* selection = nullptr;
@@ -238,12 +238,12 @@ class StringBasedNTupler : public NTupler {
           uint sep = leavesS[l].find(separator);
           std::string name = leavesS[l].substr(0, sep);
           //removes spaces from the variable name
-          /*uint*/ int space = name.find(" ");
+          /*uint*/ int space = name.find(' ');
           while (space != -1 /*std::string::npos*/) {
             std::string first = name.substr(0, space);
             std::string second = name.substr(space + 1);
             name = first + second;
-            space = name.find(" ");
+            space = name.find(' ');
           }
           std::string expr = leavesS[l].substr(sep + 1);
           std::string branchAlias = branches[b] + "_" + name;

PhysicsTools/Utilities/interface/NumericalIntegration.h

@@ -7,12 +7,12 @@
  * Gauss Legendre and Gauss algorithms based on ROOT implementation
  *
  */
+#include "Math/AllIntegrationTypes.h"
 #include "Math/Functor.h"
 #include "Math/Integrator.h"
-#include "Math/AllIntegrationTypes.h"
-#include <vector>
 #include <cmath>
 #include <memory>
+#include <vector>
 
 namespace funct {
 
@@ -142,15 +142,15 @@ namespace funct {
       relTol_ = o.relTol_;
       size_ = o.size_;
       rule_ = o.rule_;
-      integrator_.reset(new ROOT::Math::Integrator(type_, absTol_, relTol_, size_, rule_));
+      integrator_ = std::make_unique<ROOT::Math::Integrator>(type_, absTol_, relTol_, size_, rule_);
     }
     RootIntegrator& operator=(const RootIntegrator& o) {
       type_ = o.type_;
       absTol_ = o.absTol_;
       relTol_ = o.relTol_;
       size_ = o.size_;
       rule_ = o.rule_;
-      integrator_.reset(new ROOT::Math::Integrator(type_, absTol_, relTol_, size_, rule_));
+      integrator_ = std::make_unique<ROOT::Math::Integrator>(type_, absTol_, relTol_, size_, rule_);
       return *this;
     }
     template <typename F>

TopQuarkAnalysis/TopKinFitter/plugins/TtFullLepKinSolutionProducer.h

@@ -408,7 +408,8 @@ void TtFullLepKinSolutionProducer::produce(edm::Event& evt, const edm::EventSetu
   if (weightsV.empty()) {
     //create dmummy vector
     std::vector<int> idcs;
-    for (int i = 0; i < 6; ++i)
+    idcs.reserve(6);
+ for (int i = 0; i < 6; ++i)
       idcs.push_back(-1);
 
     idcsV.push_back(idcs);