Merge pull request cms-sw#42553 from NJManganelli/master-metoverflowfix

cmsbuild · web-flow · commit 75b5f3c3f14a · 2023-09-11T17:29:52.000+02:00
Phase 2 GTT MET cosLUT overflow fix
diff --git a/L1Trigger/L1TTrackMatch/interface/L1TkEtMissEmuAlgo.h b/L1Trigger/L1TTrackMatch/interface/L1TkEtMissEmuAlgo.h
@@ -29,7 +29,7 @@ namespace l1tmetemu {
   const unsigned int kCosLUTSize{10};
   const unsigned int kCosLUTMagSize{1};
   const unsigned int kCosLUTTableSize{10};
-  const unsigned int kCosLUTBins{1 << kCosLUTTableSize};
+  const unsigned int kCosLUTBins{(1 << kCosLUTTableSize) + 1};
   const unsigned int kCosLUTShift{TTTrack_TrackWord::TrackBitWidths::kPhiSize - kCosLUTTableSize};
   const unsigned int kAtanLUTSize{64};
   const unsigned int kAtanLUTMagSize{2};
diff --git a/L1Trigger/L1TTrackMatch/plugins/L1TrackerEtMissEmulatorProducer.cc b/L1Trigger/L1TTrackMatch/plugins/L1TrackerEtMissEmulatorProducer.cc
@@ -227,9 +227,6 @@ void L1TrackerEtMissEmulatorProducer::produce(edm::Event& iEvent, const edm::Eve
               << " Emu Cos(Phi): " << cosLUT_[(phiQuadrants_[4] - 1 - globalPhi) >> l1tmetemu::kCosLUTShift]
               << " Emu Sin(Phi): -" << cosLUT_[(globalPhi - phiQuadrants_[3]) >> l1tmetemu::kCosLUTShift] << "\n";
         }
-      } else {
-        temppx = 0;
-        temppy = 0;
       }
 
       int link_number = (track->phiSector() * 2) + ((EtaSector) ? 0 : 1);

Original file line number	Diff line number	Diff line change
`@@ -227,9 +227,6 @@ void L1TrackerEtMissEmulatorProducer::produce(edm::Event& iEvent, const edm::Eve`
`227`	`227`	`<< " Emu Cos(Phi): " << cosLUT_[(phiQuadrants_[4] - 1 - globalPhi) >> l1tmetemu::kCosLUTShift]`
`228`	`228`	`<< " Emu Sin(Phi): -" << cosLUT_[(globalPhi - phiQuadrants_[3]) >> l1tmetemu::kCosLUTShift] << "\n";`
`229`	`229`	`}`
`230`		`- } else {`
`231`		`- temppx = 0;`
`232`		`- temppy = 0;`
`233`	`230`	`}`
`234`	`231`
`235`	`232`	`int link_number = (track->phiSector() * 2) + ((EtaSector) ? 0 : 1);`