[CORE] Apply code-checks-all with misc-definitions-in-headers additional check

Author: smuzaffar

DataFormats/Common/interface/DetSetVectorNew.h

@@ -107,11 +107,11 @@ namespace edmNew {
           size = rh.size;
           return *this;
         }
-        Item(Item&& rh) noexcept : id(std::move(rh.id)), offset(int(rh.offset)), size(std::move(rh.size)) {}
+        Item(Item&& rh) noexcept : id(rh.id), offset(int(rh.offset)), size(rh.size) {}
         Item& operator=(Item&& rh) noexcept {
-          id = std::move(rh.id);
+          id = rh.id;
           offset = int(rh.offset);
-          size = std::move(rh.size);
+          size = rh.size;
           return *this;
         }
 

DataFormats/Common/interface/Ref.h

@@ -253,7 +253,7 @@ namespace edm {
     key_type index() const { return index_; }
 
     /// Returns true if container referenced by the Ref has been cached
-    bool hasProductCache() const { return product_.productPtr() != 0; }
+    bool hasProductCache() const { return product_.productPtr() != nullptr; }
 
     /// Checks if collection is in memory or available
     /// in the Event. No type checking is done.

DataFormats/Common/interface/RefProd.h

@@ -127,7 +127,7 @@ namespace edm {
     EDProductGetter const* productGetter() const { return product_.productGetter(); }
 
     /// Checks if product is in memory.
-    bool hasCache() const { return product_.productPtr() != 0; }
+    bool hasCache() const { return product_.productPtr() != nullptr; }
 
     /// Checks if product is in memory.
     bool hasProductCache() const { return hasCache(); }

DataFormats/Common/interface/ValidHandle.h

@@ -22,12 +22,12 @@ namespace edm {
     using element_type = T;
 
     ValidHandle() = delete;
-    ValidHandle(T const* prod, ProductID id) noexcept(false) : product_(prod), id_(std::move(id)) {
+    ValidHandle(T const* prod, ProductID id) noexcept(false) : product_(prod), id_(id) {
       vhhelper::throwIfNotValid(prod);
     }
 
     //NOTE: C++ disallows references to null
-    ValidHandle(T const& prod, ProductID id) noexcept(true) : product_(&prod), id_(std::move(id)) {}
+    ValidHandle(T const& prod, ProductID id) noexcept(true) : product_(&prod), id_(id) {}
     ValidHandle(const ValidHandle<T>&) = default;
     ValidHandle<T>& operator=(ValidHandle<T> const& rhs) = default;
     ~ValidHandle() = default;

FWCore/Utilities/src/stemFromPath.cc

@@ -2,9 +2,9 @@
 
 namespace edm {
   std::string_view stemFromPath(std::string_view path) {
-    auto begin = path.rfind("/");
+    auto begin = path.rfind('/');
     if (begin == std::string_view::npos) {
-      begin = path.rfind(":");
+      begin = path.rfind(':');
       if (begin == std::string_view::npos) {
         // shouldn't really happen?
         begin = 0;
@@ -14,7 +14,7 @@ namespace edm {
     } else {
       begin += 1;
     }
-    auto end = path.find(".", begin);
+    auto end = path.find('.', begin);
     return path.substr(begin, end - begin);
   }
 }  // namespace edm