Merge pull request cms-sw#33798 from ggovi/conddb-PoolDBESSource-fix-for-deleted-records-1-120X

GT Initialization: ignoring non-existing record in the plugins pre-load

Author: cmsbuild

CondCore/ESSources/plugins/CondDBESSource.cc

@@ -231,8 +231,12 @@ CondDBESSource::CondDBESSource(const edm::ParameterSet& iConfig)
   std::vector<std::unique_ptr<cond::DataProxyWrapperBase>> proxyWrappers(m_tagCollection.size());
   size_t ipb = 0;
   for (it = itBeg; it != itEnd; ++it) {
-    proxyWrappers[ipb++] = std::unique_ptr<cond::DataProxyWrapperBase>{
-        cond::ProxyFactory::get()->create(buildName(it->second.recordName()))};
+    size_t ind = ipb++;
+    proxyWrappers[ind] = std::unique_ptr<cond::DataProxyWrapperBase>{
+        cond::ProxyFactory::get()->tryToCreate(buildName(it->second.recordName()))};
+    if (!proxyWrappers[ind].get()) {
+      edm::LogWarning("CondDBESSource") << "Plugin for Record " << it->second.recordName() << " has not been found.";
+    }
   }
 
   // now all required libraries have been loaded
@@ -267,17 +271,19 @@ CondDBESSource::CondDBESSource(const edm::ParameterSet& iConfig)
     // ownership...
     ProxyP proxy(std::move(proxyWrappers[ipb++]));
     //  instert in the map
-    m_proxies.insert(std::make_pair(it->second.recordName(), proxy));
-    // initialize
-    boost::posix_time::ptime tagSnapshotTime = snapshotTime;
-    auto tagSnapshotIter = specialSnapshots.find(it->first);
-    if (tagSnapshotIter != specialSnapshots.end())
-      tagSnapshotTime = tagSnapshotIter->second;
-    // finally, if the snapshot is set to infinity, reset the snapshot to null, to take the full iov set...
-    if (tagSnapshotTime == boost::posix_time::time_from_string(std::string(cond::time::MAX_TIMESTAMP)))
-      tagSnapshotTime = boost::posix_time::ptime();
-
-    proxy->lateInit(nsess, tag, tagSnapshotTime, it->second.recordLabel(), connStr, &m_queue, &m_mutex);
+    if (proxy.get()) {
+      m_proxies.insert(std::make_pair(it->second.recordName(), proxy));
+      // initialize
+      boost::posix_time::ptime tagSnapshotTime = snapshotTime;
+      auto tagSnapshotIter = specialSnapshots.find(it->first);
+      if (tagSnapshotIter != specialSnapshots.end())
+        tagSnapshotTime = tagSnapshotIter->second;
+      // finally, if the snapshot is set to infinity, reset the snapshot to null, to take the full iov set...
+      if (tagSnapshotTime == boost::posix_time::time_from_string(std::string(cond::time::MAX_TIMESTAMP)))
+        tagSnapshotTime = boost::posix_time::ptime();
+
+      proxy->lateInit(nsess, tag, tagSnapshotTime, it->second.recordLabel(), connStr, &m_queue, &m_mutex);
+    }
   }
 
   // one loaded expose all other tags to the Proxy!