Skip to content

Commit b37a23e

Browse files
committed
[CalibFormats/SiPixelObjects] Remove explicit copy-assignment operator (rule-of-three violation)
1 parent d59e80b commit b37a23e

File tree

6 files changed

+0
-33
lines changed

6 files changed

+0
-33
lines changed

CalibFormats/SiPixelObjects/interface/PixelHdwAddress.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@ namespace pos {
4646

4747
friend std::ostream& pos::operator<<(std::ostream& s, const PixelHdwAddress& pixelroc);
4848

49-
const PixelHdwAddress& operator=(const PixelHdwAddress& aROC);
50-
5149
bool operator()(const PixelHdwAddress& roc1, const PixelHdwAddress& roc2) const;
5250

5351
// Checks for equality of all parts except the ROC numbers and portaddress.

CalibFormats/SiPixelObjects/interface/PixelModuleName.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,6 @@ namespace pos {
7777

7878
friend std::ostream& operator<<(std::ostream& s, const PixelModuleName& pixelroc);
7979

80-
const PixelModuleName& operator=(const PixelModuleName& aROC);
81-
8280
const bool operator<(const PixelModuleName& aROC) const { return id_ < aROC.id_; }
8381

8482
const bool operator==(const PixelModuleName& aModule) const { return id_ == aModule.id_; }

CalibFormats/SiPixelObjects/interface/PixelROCName.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,6 @@ namespace pos {
7777

7878
friend std::ostream& pos::operator<<(std::ostream& s, const PixelROCName& pixelroc);
7979

80-
const PixelROCName& operator=(const PixelROCName& aROC);
81-
8280
const bool operator<(const PixelROCName& aROC) const { return id_ < aROC.id_; }
8381

8482
const bool operator==(const PixelROCName& aROC) const { return id_ == aROC.id_; }

CalibFormats/SiPixelObjects/src/PixelHdwAddress.cc

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -62,21 +62,6 @@ std::ostream& pos::operator<<(std::ostream& s, const PixelHdwAddress& pixelroc)
6262
return s;
6363
}
6464

65-
//====================================================================================
66-
const PixelHdwAddress& PixelHdwAddress::operator=(const PixelHdwAddress& aROC) {
67-
fecnumber_ = aROC.fecnumber_;
68-
mfec_ = aROC.mfec_;
69-
mfecchannel_ = aROC.mfecchannel_;
70-
portaddress_ = aROC.portaddress_;
71-
hubaddress_ = aROC.hubaddress_;
72-
rocid_ = aROC.rocid_;
73-
fednumber_ = aROC.fednumber_;
74-
fedchannel_ = aROC.fedchannel_;
75-
fedrocnumber_ = aROC.fedrocnumber_;
76-
77-
return *this;
78-
}
79-
8065
//====================================================================================
8166
// Added by Dario
8267
void PixelHdwAddress::setAddress(std::string what, int value) {

CalibFormats/SiPixelObjects/src/PixelModuleName.cc

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -245,9 +245,3 @@ ostream& pos::operator<<(ostream& s, const PixelModuleName& pixelroc) {
245245

246246
return s;
247247
}
248-
249-
const PixelModuleName& PixelModuleName::operator=(const PixelModuleName& aROC) {
250-
id_ = aROC.id_;
251-
252-
return *this;
253-
}

CalibFormats/SiPixelObjects/src/PixelROCName.cc

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -286,9 +286,3 @@ std::ostream& pos::operator<<(std::ostream& s, const PixelROCName& pixelroc) {
286286

287287
return s;
288288
}
289-
290-
const PixelROCName& PixelROCName::operator=(const PixelROCName& aROC) {
291-
id_ = aROC.id_;
292-
293-
return *this;
294-
}

0 commit comments

Comments
 (0)