Skip to content

Commit e719501

Browse files
committed
Remove the extra random flat, extend unittest.
Remove the extra random number advance in global end lumi. Extend the unit test to 50 events.
1 parent 91e9bdd commit e719501

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

GeneratorInterface/Core/interface/ConcurrentGeneratorFilter.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -375,12 +375,10 @@ namespace edm {
375375
void ConcurrentGeneratorFilter<HAD, DEC>::globalEndLuminosityBlockProduce(LuminosityBlock& lumi,
376376
EventSetup const&,
377377
gen::GenLumiSummary const* iSummary) const {
378-
// Advance the random number generator so next begin lumi starts with new seed
379-
Service<RandomNumberGenerator> rng;
380-
rng->getEngine(lumi.index()).flat();
381378

382379
lumi.put(std::move(iSummary->lumiInfo_));
383380
}
381+
384382
template <class HAD, class DEC>
385383
void ConcurrentGeneratorFilter<HAD, DEC>::streamEndRun(StreamID id, Run const& run, EventSetup const&) const {
386384
auto rCache = this->runCache(run.index());

GeneratorInterface/Pythia8Interface/test/test_Pythia8ConcurrentGeneratorFilter_WZ_TuneCP5_13TeV-pythia8.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ cd ${LOCALTOP}/src
55
scram b
66
cd ../..
77

8-
cmsDriver.py Configuration/GenProduction/python/BTV-RunIISummer20UL17GEN-00002-fragment.py --python_filename test_BTV-RunIISummer20UL17GEN-00002_1_cfg.py --eventcontent RAWSIM --customise Configuration/DataProcessing/Utils.addMonitoring --datatier GEN --fileout file:test_BTV-RunIISummer20UL17GEN-00002.root --conditions auto:run2_mc --beamspot Realistic25ns13TeVEarly2017Collision --customise_commands process.source.numberEventsInLuminosityBlock="cms.untracked.uint32(100)" --step GEN --geometry DB:Extended --era Run2_2017 --no_exec --mc -n 10 --nThreads 2 --nConcurrentLumis 0
8+
cmsDriver.py Configuration/GenProduction/python/BTV-RunIISummer20UL17GEN-00002-fragment.py --python_filename test_BTV-RunIISummer20UL17GEN-00002_1_cfg.py --eventcontent RAWSIM --customise Configuration/DataProcessing/Utils.addMonitoring --datatier GEN --fileout file:test_BTV-RunIISummer20UL17GEN-00002.root --conditions auto:run2_mc --beamspot Realistic25ns13TeVEarly2017Collision --customise_commands process.source.numberEventsInLuminosityBlock="cms.untracked.uint32(10)" --step GEN --geometry DB:Extended --era Run2_2017 --no_exec --mc -n 50 --nThreads 4 --nConcurrentLumis 0
99

1010
sed -i "s/Pythia8GeneratorFilter/Pythia8ConcurrentGeneratorFilter/g" test_BTV-RunIISummer20UL17GEN-00002_1_cfg.py
1111

0 commit comments

Comments
 (0)