Skip to content

Commit da3a9b7

Browse files
committed
split session events to multiple enums (#2519)
1 parent e2dede7 commit da3a9b7

File tree

18 files changed

+321
-80
lines changed

18 files changed

+321
-80
lines changed

apps/desktop/src/components/main/body/sessions/index.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ export const TabItemNote: TabItem<Extract<Tab, { type: "sessions" }>> = ({
3535
main.STORE_ID,
3636
);
3737
const sessionMode = useListener((state) => state.getSessionMode(tab.id));
38-
const isActive =
39-
sessionMode === "running_active" || sessionMode === "finalizing";
38+
const isActive = sessionMode === "active" || sessionMode === "finalizing";
4039

4140
return (
4241
<TabItemBase

apps/desktop/src/components/main/body/sessions/note-input/header.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ export function Header({
333333
}) {
334334
const sessionMode = useListener((state) => state.getSessionMode(sessionId));
335335
const isBatchProcessing = sessionMode === "running_batch";
336-
const isLiveProcessing = sessionMode === "running_active";
336+
const isLiveProcessing = sessionMode === "active";
337337

338338
if (editorTabs.length === 1 && editorTabs[0].type === "raw") {
339339
return null;
@@ -408,7 +408,7 @@ export function useEditorTabs({
408408
main.STORE_ID,
409409
);
410410

411-
if (sessionMode === "running_active" || sessionMode === "running_batch") {
411+
if (sessionMode === "active" || sessionMode === "running_batch") {
412412
return [{ type: "raw" }, { type: "transcript" }];
413413
}
414414

apps/desktop/src/components/main/body/sessions/note-input/transcript/shared/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export function TranscriptContainer({
2929

3030
const sessionMode = useListener((state) => state.getSessionMode(sessionId));
3131
const currentActive =
32-
sessionMode === "running_active" || sessionMode === "finalizing";
32+
sessionMode === "active" || sessionMode === "finalizing";
3333
const editable =
3434
sessionMode === "inactive" && Object.keys(operations ?? {}).length > 0;
3535

apps/desktop/src/components/main/body/sessions/outer-header/listen.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ function InMeetingIndicator({ sessionId }: { sessionId: string }) {
229229
muted: state.live.muted,
230230
}));
231231

232-
const active = mode === "running_active" || mode === "finalizing";
232+
const active = mode === "active" || mode === "finalizing";
233233
const finalizing = mode === "finalizing";
234234

235235
if (!active) {

apps/desktop/src/components/main/body/sessions/outer-header/overflow/listening.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export function Listening({ sessionId }: { sessionId: string }) {
1010
mode: state.getSessionMode(sessionId),
1111
stop: state.stop,
1212
}));
13-
const isListening = mode === "running_active" || mode === "finalizing";
13+
const isListening = mode === "active" || mode === "finalizing";
1414
const isFinalizing = mode === "finalizing";
1515
const isBatching = mode === "running_batch";
1616
const startListening = useStartListening(sessionId);

apps/desktop/src/components/main/body/sessions/shared.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export function useCurrentNoteTab(
2626
): EditorView {
2727
const sessionMode = useListener((state) => state.getSessionMode(tab.id));
2828
const isListenerActive =
29-
sessionMode === "running_active" || sessionMode === "finalizing";
29+
sessionMode === "active" || sessionMode === "finalizing";
3030

3131
const enhancedNoteIds = main.UI.useSliceRowIds(
3232
main.INDEXES.enhancedNotesBySession,
@@ -68,8 +68,7 @@ export function RecordingIcon({ disabled }: { disabled?: boolean }) {
6868

6969
export function useListenButtonState(sessionId: string) {
7070
const sessionMode = useListener((state) => state.getSessionMode(sessionId));
71-
const active =
72-
sessionMode === "running_active" || sessionMode === "finalizing";
71+
const active = sessionMode === "active" || sessionMode === "finalizing";
7372
const batching = sessionMode === "running_batch";
7473

7574
const taskId = createTaskId(sessionId, "enhance");

apps/desktop/src/hooks/useAutoEnhance.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,7 @@ export function useAutoEnhance(tab: Extract<Tab, { type: "sessions" }>) {
9191

9292
useEffect(() => {
9393
const listenerJustStopped =
94-
prevListenerStatus === "running_active" &&
95-
listenerStatus !== "running_active";
94+
prevListenerStatus === "active" && listenerStatus !== "active";
9695

9796
if (listenerJustStopped) {
9897
createAndStartEnhance();

apps/desktop/src/hooks/useEnhancedNotes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ export function useEnsureDefaultSummary(sessionId: string) {
148148
useEffect(() => {
149149
if (
150150
!hasTranscript ||
151-
sessionMode === "running_active" ||
151+
sessionMode === "active" ||
152152
sessionMode === "running_batch" ||
153153
sessionMode === "finalizing" ||
154154
(enhancedNoteIds && enhancedNoteIds.length > 0)

apps/desktop/src/routes/app/main/_layout.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ function Component() {
4848
return true;
4949
}
5050
const mode = getSessionMode(tab.id);
51-
return mode !== "running_active" && mode !== "finalizing";
51+
return mode !== "active" && mode !== "finalizing";
5252
});
5353
}, [registerCanClose, getSessionMode]);
5454

apps/desktop/src/store/zustand/listener/general.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ describe("General Listener Slice", () => {
1616
expect(state.live.loading).toBe(false);
1717
expect(state.live.amplitude).toEqual({ mic: 0, speaker: 0 });
1818
expect(state.live.seconds).toBe(0);
19-
expect(state.live.sessionEventUnlisten).toBeUndefined();
19+
expect(state.live.eventUnlisteners).toBeUndefined();
2020
expect(state.live.intervalId).toBeUndefined();
2121
expect(state.batch).toEqual({});
2222
});

0 commit comments

Comments
 (0)