feat: add assets library page for managing Supabase storage files #2738
+596
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new route at /app/assets for authenticated users - Implement file navigator with folder navigation and breadcrumbs - Support single/multiple file upload and folder upload - Add multi-select functionality for bulk delete - Implement copy public URL feature - Add folder creation capability - Create Supabase migration for assets storage bucket with RLS policies Co-Authored-By: [email protected] <[email protected]>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+114
to
+121
| for (const item of data || []) { | ||
| if (item.id === null && !seenFolders.has(item.name)) { | ||
| seenFolders.add(item.name); | ||
| items.push({ name: item.name, isFolder: true }); | ||
| } else if (item.id !== null) { | ||
| items.push({ ...item, isFolder: false }); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
The folder detection logic filters items where id === null as folders. However, the .keep files created by createFolderMutation (line 178) will have a non-null id and will appear as regular files in the listing. This means users will see .keep placeholder files in their folder view, which breaks the folder abstraction.
// Filter out .keep files from the display
for (const item of data || []) {
if (item.name === '.keep') continue; // Skip .keep files
if (item.id === null && !seenFolders.has(item.name)) {
// ... folder handling
}
}
Suggested change
| for (const item of data || []) { | |
| if (item.id === null && !seenFolders.has(item.name)) { | |
| seenFolders.add(item.name); | |
| items.push({ name: item.name, isFolder: true }); | |
| } else if (item.id !== null) { | |
| items.push({ ...item, isFolder: false }); | |
| } | |
| } | |
| for (const item of data || []) { | |
| if (item.name === '.keep') continue; // Skip .keep files | |
| if (item.id === null && !seenFolders.has(item.name)) { | |
| seenFolders.add(item.name); | |
| items.push({ name: item.name, isFolder: true }); | |
| } else if (item.id !== null) { | |
| items.push({ ...item, isFolder: false }); | |
| } | |
| } |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new Assets Library page at
/app/assetsfor marketers to manage images, videos, and other files in Supabase storage. This is a web-based file navigator with CRUD operations.Features implemented:
Database changes:
assetsbucket (public) with RLS policies scoped to user ID foldersReview & Testing Checklist for Human
webkitdirectoryattribute is non-standard; verify it works in Chrome/Edge (may not work in Firefox/Safari)Recommended test plan:
/app/assetswhile logged inNotes
public = true- all uploaded files will be publicly accessible via URL. Confirm this is the desired behavior for marketing assets.Link to Devin run: https://app.devin.ai/sessions/55d4032bd5d34421976e5264fcea8191
Requested by: [email protected] (@ComputelessComputer)