diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 127d266..b0b804f 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - ruby-version: ["3.4", "3.3", "3.2", "3.1", "3.0", "2.7", "2.6", "2.5"] + ruby-version: ["3.4", "3.3", "3.2", "3.1", "3.0", "2.7", "2.6", "2.5", "2.4", "2.3"] steps: - uses: actions/checkout@v2 diff --git a/CHANGELOG.md b/CHANGELOG.md index 571dc37..9f8f574 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,7 @@ - [BUGFIX: example](https://github.com/fastruby/next_rails/pull/) - [CHORE: Create an entry point for the BundleReport command](https://github.com/fastruby/next_rails/pull/154) +- [CHORE: Bring back support of Ruby 2.3, 2.4 and 2.5](https://github.com/fastruby/next_rails/pull/155) * Your changes/patches go here. diff --git a/lib/next_rails/bundle_report/cli.rb b/lib/next_rails/bundle_report/cli.rb index db578bc..cefd1f4 100644 --- a/lib/next_rails/bundle_report/cli.rb +++ b/lib/next_rails/bundle_report/cli.rb @@ -3,6 +3,7 @@ require "optparse" require "next_rails" require "next_rails/bundle_report" +require "byebug" class NextRails::BundleReport::CLI def initialize(argv) @@ -21,11 +22,11 @@ def validate_arguments(argv) end argv.each do |arg| - if arg.start_with?("--rails-version") && !arg.match?(/--rails-version=+\d+(\.\d+)*$/) + if arg.start_with?("--rails-version") && !/--rails-version=+\d+(\.\d+)*$/.match(arg) raise ArgumentError, "Invalid Rails version format. Example: --rails-version=5.0.7" end - if arg.start_with?("--ruby-version") && !arg.match?(/--ruby-version=+\d+(\.\d+)*$/) + if arg.start_with?("--ruby-version") && !/--ruby-version=+\d+(\.\d+)*$/.match(arg) raise ArgumentError, "Invalid Ruby version format. Example: --ruby-version=3.3" end end diff --git a/next_rails.gemspec b/next_rails.gemspec index dc59c4b..ce160b9 100644 --- a/next_rails.gemspec +++ b/next_rails.gemspec @@ -29,6 +29,7 @@ Gem::Specification.new do |spec| spec.add_development_dependency "simplecov", "~> 0.17.1" spec.add_development_dependency "timecop", "~> 0.9.1" spec.add_development_dependency "byebug" - spec.add_development_dependency "rexml", "3.3.8" # limited on purpose, new versions don't work with old rubies - spec.add_development_dependency "webmock", "3.20.0" + spec.add_development_dependency "rexml", "3.2.5" # limited on purpose, new versions don't work with old rubies + spec.add_development_dependency "webmock", "3.16.2" + spec.add_development_dependency "base64" end