Skip to content

GitHub information with no user name shows a blank name in the views #317

@arielj

Description

@arielj

Branch/Commit:

Main branch.

Expected behavior:

When a GitHub user information is missing the name, we should fallback to other information, like the github handle.

Actual behavior:

When the Github user name is empty, the name is blank:
image

Steps to reproduce:

How do I achieve this behavior? Use the following format to provide a step-by-step guide:

  1. Log in into Points with a Github user that has no name
  2. Add some estimates
  3. Go to the report page

Also, add comments to a story, in the comments we also use the user's name.

Aditional information

We'll probably need to update the ombu_labs-auth game for this https://github.com/fastruby/ombu_labs-auth/blob/main/app/models/concerns/ombu_labs_authenticable.rb#L16

I will abide by the code of conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions