Skip to content

Commit 69b57de

Browse files
committed
Close edit modal when overlay is clicked
Remove unnecessary dataset action check in modal close method. Update modal overlay to use click event for closing, ensuring consistent modal dismissal behavior.
1 parent e762bb6 commit 69b57de

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

app/javascript/controllers/modal_controller.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ export default class extends Controller {
44
static targets = ["content"]
55

66
close(event) {
7-
if (event.target.dataset.action === "modal#close") {
8-
this.element.remove()
9-
}
7+
this.element.remove()
108
}
119
}

app/views/puzzles/edit.html.erb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
21
<turbo-frame id="modal">
3-
<div data-controller="modal" data-action="modal#close"class="modal-overlay">
2+
<div data-controller="modal" data-action="click->modal#close"class="modal-overlay">
43
<div data-modal-target="content"
54
class="modal-content"
65
onclick="event.stopPropagation()">

0 commit comments

Comments
 (0)