Address reek and rubocop errors

Author: bronzdoc

lib/skunk/cli/application.rb

@@ -11,6 +11,7 @@
 module Skunk
   module Cli
     # Knows how to execute command line commands
+    # :reek:InstanceVariableAssumption
     class Application < RubyCritic::Cli::Application
       COVERAGE_FILE = "coverage/.resultset.json"
 
@@ -24,6 +25,7 @@ def execute
         parsed_options = @options.parse.to_h
         reporter = Skunk::Cli::CommandFactory.create(parsed_options).execute
 
+        # :reek:NilCheck
         @parsed_options = @options.parse.to_h
         reporter = Skunk::Cli::CommandFactory.create(@parsed_options).execute
 
@@ -41,12 +43,13 @@ def warn_coverage_info
         warn "warning: Having no coverage metrics will make your SkunkScore worse."
       end
 
+      # :reek:NilCheck
       def print(message)
         filename = @parsed_options[:output_filename]
         if filename.nil?
           $stdout.puts(message)
         else
-          File.open(filename, "w") { |f| f.puts(message) }
+          File.open(filename, "w") { |file| file.puts(message) }
         end
       end
     end

lib/skunk/cli/options/argv.rb

@@ -9,6 +9,7 @@ class Options
       # Extends RubyCritic::Cli::Options::Argv to parse a subset of the
       # parameters accepted by RubyCritic
       class Argv < RubyCritic::Cli::Options::Argv
+        # :reek:Attribute
         attr_accessor :output_filename
 
         def parse # rubocop:disable Metrics/MethodLength
@@ -36,7 +37,7 @@ def parse # rubocop:disable Metrics/MethodLength
         end
 
         def to_h
-          super.merge({ output_filename: output_filename })
+          super.merge(output_filename: output_filename)
         end
       end
     end

test/lib/skunk/application_test.rb

@@ -46,7 +46,8 @@
           end
         end
 
-        _(File.read("tmp/generated_report.txt")).must_equal File.read("test/samples/console_output.txt")
+        _(File.read("tmp/generated_report.txt"))
+          .must_equal File.read("test/samples/console_output.txt")
       end
     end
   end