tweaked syntax for functions without arguments

shorthand does more harm than good

Author: FND

lib/manager.js

@@ -30,9 +30,9 @@ module.exports = class AssetManager {
 		}
 
 		return createFile(filepath, data).
-			then(_ => this.manifest &&
+			then(() => this.manifest &&
 					this._updateManifest(originalPath, filepath, targetDir)).
-			then(_ => {
+			then(() => {
 				reportFileStatus(originalPath, this.referenceDir, error);
 				if(error && this.exitOnError) {
 					throw error;

lib/util/files/index.js

@@ -11,7 +11,7 @@ let LOCKS = new Map();
 module.exports = function createFile(filepath, contents) {
 	let lock = LOCKS.get(filepath);
 	if(lock) { // defer
-		return lock.then(_ => createFile(filepath, contents));
+		return lock.then(() => createFile(filepath, contents));
 	}
 
 	// create directory if necessary
@@ -22,7 +22,7 @@ module.exports = function createFile(filepath, contents) {
 
 	let prom = writeFile(filepath, contents);
 	LOCKS.set(filepath, prom);
-	return prom.then(_ => {
+	return prom.then(() => {
 		LOCKS.delete(filepath);
 	});
 };

lib/util/runner.js

@@ -8,7 +8,7 @@ module.exports = class SerializedRunner {
 	run(...args) {
 		if(!this._pending) { // prevent concurrent execution
 			this._pending = augment(this.asyncOp(...args)).
-				finally(_ => {
+				finally(() => {
 					this._pending = null;
 				});
 		}
@@ -25,10 +25,10 @@ module.exports = class SerializedRunner {
 		let res = this.run(...args);
 		if(enqueue) {
 			this._queued = res = augment(res).
-				finally(_ => {
+				finally(() => {
 					this._queued = null;
 				}).
-				then(_ => this.run(...args));
+				then(() => this.run(...args));
 		}
 		return res;
 	}

test/test_manager.js

@@ -7,7 +7,7 @@ let assert = require("assert");
 
 let assertSame = assert.strictEqual;
 
-describe("asset manager", _ => {
+describe("asset manager", () => {
 	let root = path.resolve(__dirname, "fixtures");
 	let cwd;
 	let { exit } = process;

test/test_manifest.js

@@ -7,7 +7,7 @@ let assert = require("assert");
 
 let assertSame = assert.strictEqual;
 
-describe("manifest", _ => {
+describe("manifest", () => {
 	let root = path.resolve(__dirname, "fixtures");
 	let cwd;
 
@@ -23,18 +23,18 @@ describe("manifest", _ => {
 	it("maps original to actual file names with deterministic serialization", () => {
 		let manifest = new Manifest(root);
 		return manifest.set("foo.png", "foo-abc123.png").
-			then(_ => {
+			then(() => {
 				assertSame(JSON.stringify(manifest), '{"foo.png":"/foo-abc123.png"}');
 
 				return manifest.set("bar.css", "bar-def456.css");
 			}).
-			then(_ => {
+			then(() => {
 				assertSame(JSON.stringify(manifest),
 						'{"bar.css":"/bar-def456.css","foo.png":"/foo-abc123.png"}');
 
 				return manifest.set("xox.js", "xox-ghi789.js");
 			}).
-			then(_ => {
+			then(() => {
 				assertSame(JSON.stringify(manifest), // eslint-disable-next-line max-len
 						'{"bar.css":"/bar-def456.css","foo.png":"/foo-abc123.png","xox.js":"/xox-ghi789.js"}');
 			});

test/test_plugins.js

@@ -30,7 +30,7 @@ let DEFAULTS = {
 let { NODE_PATH } = process.env;
 let CUSTOM_NODE_PATH = path.resolve(ROOT, "node_modules");
 
-describe("plugin registration", _ => {
+describe("plugin registration", () => {
 	before(() => {
 		updateNodePath(NODE_PATH, CUSTOM_NODE_PATH);
 	});
@@ -105,7 +105,7 @@ describe("plugin registration", _ => {
 	});
 });
 
-describe("plugin resolution", _ => {
+describe("plugin resolution", () => {
 	let { exit } = process;
 
 	before(() => {

test/test_runner.js

@@ -4,7 +4,7 @@
 let SerializedRunner = require("../lib/util/runner");
 let { strictEqual: assertSame, deepStrictEqual: assertDeep } = require("assert");
 
-describe("watch mode", _ => {
+describe("watch mode", () => {
 	it("avoids concurrent compilation, queueing recompilation", () => {
 		let bundle = new MockBundle();
 
@@ -13,7 +13,7 @@ describe("watch mode", _ => {
 		bundle.compile(); // skipped due to queue limit
 		let prevLog; // keeps track of compilation sequence
 		return bundle.compile(). // skipped due to queue limit
-			then(_ => {
+			then(() => {
 				let log = bundle.executionLog;
 				assertSame(log.length, 2); // compiled, then recompiled once
 				prevLog = [].concat(log);
@@ -23,15 +23,15 @@ describe("watch mode", _ => {
 				bundle.compile(); // skipped due to queue limit
 				return bundle.compile(); // skipped due to queue limit
 			}).
-			then(_ => {
+			then(() => {
 				let log = bundle.executionLog;
 				assertSame(log.length, 4); // compiled, then recompiled once
 				assertDeep(log.slice(0, prevLog.length), prevLog);
 				prevLog = [].concat(bundle.executionLog);
 
 				return bundle.compile(); // starts compilation
 			}).
-			then(_ => {
+			then(() => {
 				let log = bundle.executionLog;
 				assertSame(log.length, 5);
 				assertDeep(log.slice(0, prevLog.length), prevLog);
@@ -57,7 +57,7 @@ class MockBundle {
 
 	_compile(id) {
 		return wait(1).
-			then(_ => {
+			then(() => {
 				if(id) {
 					this.executionLog.push(id);
 				}
@@ -67,6 +67,6 @@ class MockBundle {
 
 function wait(delay) {
 	return new Promise(resolve => {
-		setTimeout(_ => { resolve(); }, delay);
+		setTimeout(() => { resolve(); }, delay);
 	});
 }

test/test_server.js

@@ -6,7 +6,7 @@ let assert = require("assert");
 
 let assertSame = assert.strictEqual;
 
-describe("server host parsing", _ => {
+describe("server host parsing", () => {
 	let { exit } = process;
 
 	before(() => {

test/test_util.js

@@ -11,7 +11,7 @@ let assertDeep = assert.deepStrictEqual;
 
 let FIXTURES_PATH = path.resolve(__dirname, "fixtures");
 
-describe("fingerprinting", _ => {
+describe("fingerprinting", () => {
 	it("generates a content-dependent hash", () => {
 		let fingerprint = generateFingerprint("/path/to/foo.js", "lorem ipsum");
 		assertSame(fingerprint, "/path/to/foo-80a751fde577028640c419000e33eba6.js");
@@ -26,7 +26,7 @@ describe("fingerprinting", _ => {
 	});
 });
 
-describe("FileFinder", _ => {
+describe("FileFinder", () => {
 	it("finds all files within a folder", () => {
 		let fileFinder = new FileFinder(FIXTURES_PATH);