Skip to content

Commit a7f5b2b

Browse files
committed
Remove liveserver option
[live-server](https://www.npmjs.com/package/live-server) has not been updated in over four years, and has severe security issues.
1 parent 2a19f94 commit a7f5b2b

File tree

3 files changed

+5
-15
lines changed

3 files changed

+5
-15
lines changed

lib/cli.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ Options:
2323
reduce output size (where supported)
2424
--serve [HOST:]PORT
2525
serve generated files via HTTP
26-
--liveserve [HOST:]PORT
27-
serve generated files via HTTP with live reloading
2826
`.trim();
2927

3028
exports.parseCLI = async function parseCLI() {
@@ -78,6 +76,10 @@ exports.parseCLI = async function parseCLI() {
7876
liveserve: values.liveserve
7977
};
8078

79+
if(values.liveserve) {
80+
abort("The --liveserve option was removed. Please use --serve instead", 0);
81+
}
82+
8183
if(options.watch && options.fingerprint) { // for convenience
8284
console.error("you might consider disabling fingerprinting in watch " +
8385
"mode to avoid littering your file system with obsolete bundles");

lib/index.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ let { SerializedRunner } = require("./util/runner");
99
let browserslist = require("browserslist");
1010

1111
exports.faucetDispatch = async function faucetDispatch(referenceDir, config,
12-
{ watch, fingerprint, sourcemaps, compact, serve, liveserve }) {
12+
{ watch, fingerprint, sourcemaps, compact, serve }) {
1313
config = await config;
1414

1515
let assetManager = new AssetManager(referenceDir, {
@@ -47,13 +47,8 @@ exports.faucetDispatch = async function faucetDispatch(referenceDir, config,
4747
});
4848
}
4949

50-
if(serve && liveserve) {
51-
abort("ERROR: serve and liveserve must not be used together");
52-
}
5350
if(serve) {
5451
server.static(serve, assetManager.manifest.webRoot);
55-
} else if(liveserve) {
56-
server.live(liveserve, assetManager.manifest.webRoot);
5752
}
5853

5954
return res; // notifies consumers once the initial build has completed

lib/server.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,6 @@ exports.static = async (config, webroot) => {
1313
console.error(`serving ${repr(webroot)} at http://${host}:${port}`);
1414
};
1515

16-
exports.live = async (config, root) => {
17-
let liveServer = await loadExtension("live-server", "failed to activate live-server");
18-
let [host, port] = parseHost(config);
19-
20-
liveServer.start({ port, host, root, open: false });
21-
};
22-
2316
exports._parseHost = parseHost;
2417

2518
function parseHost(config) {

0 commit comments

Comments
 (0)